Not allow null value for cache default_ttl

[tolean]

Not allow null value for cache default_ttl

[dbu]

hi @tolean, hm, what is the reason to set the default_ttl to null? can't you omit the configuration completely when you don't want to set it? we don't have a default value in the configuration, so not setting it at all should achieve what you want, no?

[tolean]

@dbu, if I omit this config, the default value from the cache plugin is applied, see https://github.com/php-http/cache-plugin/blob/9e4b50f8aea93720ca745cd81b6154bcb6713898/src/CachePlugin.php#L356

[dbu]

oh, thanks you are right, we need to support explicit null.

do you want to do a pull request for the Configuration.php class to allow that?

[tolean]

I'll be happy to fix it. Problem is here

HttplugBundle/src/DependencyInjection/Configuration.php

Line 716 in 1036c17

->integerNode('default_ttl')

But isn't clear for me how to make nullable numeric node

[dbu]

sorry, this went under. it looks like symfony integerNode can not be nullable. i think we need to change this to a scalarNode and then add a custom validation that says its either null or is_int is true, and mark it invalid if its anything else.

do you want to give that a try?

[dbu]

https://github.com/php-http/HttplugBundle/releases/tag/1.26.0