Comments (7)
awesome if you have time to add phpstan and fix easy issues / generate a baseline for the rest. we have it set up in https://github.com/php-http/httplug/ - if you can do it similar that will help with consistency across the repositories. 👍
from httplugbundle.
@dbu I looked into this, but how is this supposed to be handled for this bundle? I think it can only be done in v2?
from httplugbundle.
yep, we can't avoid this without a BC break.
we did prepare in #427 , exposing the psr stuff for autowiring.
i don't have much time for OS atm, but would not be oposed to people looking into a new major version and getting rid of legacy things. the current version seems really stable - it is used in quite some places and there are very little complaints. so making 2.0 should not impact 1.x users too much as not much is going on anyways.
we could weed out quite a bit of the DI configuration code, and also simplify the documentation because we don't need to explain that much deprecated stuff anymore.
from httplugbundle.
fixed in #439, will be in version 2.
from httplugbundle.
Hello @dbu do you have a date to release 2.0 ? It looks like it's pretty stable, do you need help on something to release it ?
from httplugbundle.
hi, yeah we should release soon. the one thing missing is cleaning up the code for strict typing, as that is a BC break when people extend classes. and #321 as well.
if you have some time to check that all class properties, arguments and methods are typed, that would certainly help. if you could do a pull request with it, all the better.
if not i will try to find time for it later this week.
from httplugbundle.
What about adding PHPStan and Easy Coding Standard (it use PHP-CS-Fixer) to the CI ?
It will help keeping some basic rules for this repository and I think it can take care of some types requirements.
I will start creating the PR you mentioned and then see if PHPStan and ECS can be added and have any benefits.
EDIT: I didn't notice that PHP CS fixer was already used so no need for ECS, then PHPStan can be the way to detect issues with non typed properties.
from httplugbundle.
Related Issues (20)
- The httplug.collector.twig.http_message service is deprecated since version 1.17 HOT 5
- Collector not compatible with Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface HOT 9
- Xdebug nested issue HOT 1
- The data collector does not have reset tag HOT 1
- Can't test throwing an exception. Help needed
- 1.22 crash on cache clear in symfony 4.4 HOT 1
- Not allow null value for cache default_ttl HOT 6
- ErrorPlugin cannot be configured HOT 1
- The collector formatter needs to implement Http\Message\Formatter::formatResponseForRequest HOT 1
- [Profiler] No captured body (Symfony Client) HOT 4
- Switch from Http\Client\HttpClient to Psr\Http\Client\ClientInterface HOT 4
- Header authentication service configuration HOT 2
- Support Symfony 7
- Add Factory for NoPrivateNetworkHttpClient HOT 3
- [Symfony 7.1] The `Symfony\Component\HttpKernel\DependencyInjection\Extension` class is considered internal since Symfony 7.1, to be deprecated in 8.1; use `Symfony\Component\DependencyInjection\Extension\Extension` instead HOT 1
- "message":"User Deprecated: Class \"Nyholm\\Psr7\\Factory\\HttplugFactory\" is deprecated since version 1.8, use \"Nyholm\\Psr7\\Factory\\Psr17Factory\" HOT 1
- phpstan: add vcr plugin for stricter checks
- raise minimum php and symfony versions HOT 2
- increase phpstan level
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from httplugbundle.