Giter Site home page Giter Site logo

Comments (5)

bigtimebuddy avatar bigtimebuddy commented on May 22, 2024 1

Released in v1.4.2

from sound.

bigtimebuddy avatar bigtimebuddy commented on May 22, 2024

Is this error thrown with the examples?

from sound.

hendrysadrak avatar hendrysadrak commented on May 22, 2024

The examples dont work because of ES6 syntax :D

from sound.

bigtimebuddy avatar bigtimebuddy commented on May 22, 2024

Looks like a pretty easy fix. I added this to the dev branch, but will also probably make a patch release to master for this. The offending line is here:

https://github.com/pixijs/pixi-sound/blob/master/src/SoundInstance.ts#L245

this._source.start(0, start, (end ? end - start : undefined));

For iOS 9, this should be:

if (end) {
  this._source.start(0, start,  end - start);
} else {
  this._source.start(0, start);
}

from sound.

hendrysadrak avatar hendrysadrak commented on May 22, 2024

Perfect! Thank you for the quick response! When will you merge dev to master or create a patch?

from sound.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.