Comments (4)
Hey @chienerh,
Thank you for the feedback. I will carefully review the code and reply to you soon.
from overlapnet.
Hey @chienerh,
Thank you so much to point the problem out!
You are right. The old script is wrong, which may be caused when we created the demo.
I've already corrected the function and please have a check here
Thank you again for following our work and help us to improve our code!
Best,
Xieyuanli
from overlapnet.
Hi @Chen-Xieyuanli,
Thanks a lot for the quick responding.
The updated code makes sense for me now.
Thanks for your update!
from overlapnet.
Hi @Chen-Xieyuanli, following this issue, I see the com_overlap_yaw() function, when you compute the overlap:
overlap = np.count_nonzero( abs(reference_range[reference_range > 0] - current_range[reference_range > 0]) < 1) / valid_num overlaps.append(overlap)
I understood the idea is to account only valid points, so I assume, we should have current_range[current_range > 0] rather than current_range[reference_range > 0] here? Let me know what do you think, thanks.
from overlapnet.
Related Issues (20)
- Questions about my test HOT 2
- Questions about overlapnet HOT 2
- Using overlapnet for a different dataset HOT 6
- Question about covariance ? HOT 2
- Way to integrate with ROS ?? HOT 5
- Preprocessing time HOT 2
- Question about how to judge a loop closure True Positive or not HOT 4
- FileNotFoundError: [Errno 2] No such file or directory: 'config/demo.yml'
- some errors encountered during training HOT 7
- Some confusion about normalize_data.py HOT 3
- Requirements of pytorch HOT 3
- Some confusion about real overlap calculation HOT 10
- Pytorch version training. HOT 4
- Questions when Generating train_set HOT 6
- Pytorch version training HOT 8
- Problem in the first version HOT 2
- ground truth HOT 1
- Datasets HOT 1
- How to generate train_set HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from overlapnet.