Giter Site home page Giter Site logo

prince-chrismc / conan-center-index-pending-review Goto Github PK

View Code? Open in Web Editor NEW
14.0 3.0 0.0 422.6 MB

A simple repository to automatically track which conan-center-index pull requests are ready for review

Home Page: https://prince-chrismc.github.io/conan-center-index-pending-review/

License: MIT License

Go 100.00%
go golang go-application conan-center github github-api rest-api

conan-center-index-pending-review's Issues

Pull Requests Ready to be Reviewed

✨ Summary of Pull Requests Pending Review!

☑️ Selection Criteria:

  • There has been at least one approval on the head commit
  • The last commit occurred after any reviews
  • Must not have a label indicating stopped or auto merge

Legend

Icon Description
🆕 Adding a recipe which does not yet exist
📝 Modification to an existing recipe
📗 Documentation change [1]
⚙️ GitHub configuration/workflow changes [1]
⏱️ or ⚠️ The commit status does not indicate success [2]
🔔 The last review was more than 12 days ago
👀 It's been more than 3 days since the last commit and there are no reviews
  • [1]: closely matches the label
  • [2]: depending whether the PR is under way or ready to merge

🤓 Please Review!

There are 215 pull requests currently under way 🕵️

PR By Opened Recipe Weight Reviews Last 🛑 Blockers 🌟 Approvers
#16074 Jihadist Feb 16 🆕 krb5 L 1 Feb 25 🔔 valgur
#18570 samuel-emrys Jul 16 📝 xorg 🟢 XS 4 Mar 24 🔔 jwillikers, SSE4, valgur
#18672 valgur Jul 19 📝 kcov L 1 Feb 26 🔔 jwillikers
#18680 valgur Jul 19 📝 kealib L 2 Jan 16 🔔
#18715 valgur Jul 20 📝 scc L 1 Mar 25 🔔 jwillikers
#18739 valgur Jul 20 📝 unleash-client-cpp L 1 Mar 25 🔔 jwillikers
#18810 valgur Jul 22 📝 daggy L 3 Apr 3 🔔
#18812 valgur Jul 22 📝 libjxl XL 3 Apr 30 jwillikers
#18816 valgur Jul 22 📝 dd-opentracing-cpp L 4 May 7 danimtb, DS-Alex-AG
#18820 valgur Jul 22 📝 pagmo2 L 1 Mar 25 🔔 jwillikers
#18837 valgur Jul 22 ⏱️ qcoro L 0 👀
#18842 valgur Jul 23 📝 azure-storage-cpp L 2 Apr 20 🔔 jwillikers
#18852 valgur Jul 23 📝 libtommath L 3 Apr 9 🔔
#18938 valgur Jul 28 📝 makefile-project-workspace-creator M 3 Mar 24 🔔 jwillikers
#18948 valgur Jul 28 📝 hiredis L 1 Mar 25 🔔 jwillikers
#18949 valgur Jul 28 📝 userspace-rcu L 1 Mar 25 🔔 jwillikers
#18950 valgur Jul 28 📝 pbc L 1 Mar 25 🔔 jwillikers
#18979 valgur Jul 31 📝 libfabric L 1 Mar 1 🔔 jwillikers
#18986 valgur Jul 31 📝 librhash L 1 Mar 25 🔔 jwillikers
#19082 bog-dan-ro Aug 7 ⏱️ qt 🟢 XS 4 Mar 24 🔔 jwillikers, MartinDelille
#19234 cjbradfield Aug 16 🆕 quictls-openssl XL 0 👀
#19239 valgur Aug 17 📝 pro-mdnsd L 1 Aug 21 🔔 steinerthomas
#19726 bryce-cahill Sep 10 📝 pcre2 M 3 Mar 24 🔔 SpaceIm, valgur
#19942 Woazim Sep 18 📝 imagl M 1 Mar 24 🔔 valgur
#19980 valgur Sep 20 📝 glslang L 6 Apr 21 🔔 jwillikers
#20172 Wawha Sep 27 ⏱️ tensorflow-lite 🟢 XS 2 Mar 24 🔔 valgur
#20270 valgur Oct 2 📝 libsndfile M 2 Oct 27 🔔 ericLemanissier, jwillikers
#20290 jwillikers Oct 2 📝 libsystemd L 2 Mar 24 🔔 valgur
#20336 SpaceIm Oct 3 📝 boost 🟢 XS 3 Feb 28 🔔 RubenRBS jwillikers, valgur
#20369 SpaceIm Oct 5 ⏱️ pipes 🟦 S 2 Mar 24 🔔 jwillikers, valgur
#20373 jwillikers Oct 5 🆕 libblkid M 1 Mar 19 🔔 valgur
#20381 SpaceIm Oct 5 📝 sdl L 10 Mar 22 🔔 jwillikers, valgur
#20392 bverhagen Oct 6 ⏱️ onnxruntime M 11 Oct 31 🔔 jwillikers
#20465 gjasny Oct 9 📝 resiprocate L 2 Feb 23 🔔 valgur
#20507 jwillikers Oct 10 📝 libmount M 3 Mar 26 🔔
#20586 valgur Oct 16 📝 pcre2 M 1 Nov 20 🔔 jwillikers
#20725 mayeut Oct 21 ⏱️ podofo 🟢 XS 0
#20987 toge Nov 8 ⏱️ octo-keygen-cpp 🟢 XS 0 👀
#21085 SpaceIm Nov 12 📝 msdfgen L 4 Mar 17 🔔 jwillikers, valgur
#21207 toge Nov 18 📝 structopt 🟢 XS 4 Feb 28 🔔 uilianries jwillikers, valgur
#21238 valgur Nov 19 📝 brunsli 🟢 XS 2 Jan 3 🔔 jwillikers, ericLemanissier
#21246 SpaceIm Nov 19 📝 libdisplay-info 🟦 S 3 Feb 23 🔔 jwillikers, valgur
#21389 valgur Nov 26 📝 getdns L 1 Mar 25 🔔 jwillikers
#21391 ashley-b Nov 27 📝 qwt L 4 Mar 25 🔔
#21512 valgur Nov 30 📝 proj L 3 Apr 18 🔔
#21558 mayeut Dec 3 📝 libcurl L 1 Dec 7 🔔 uilianries
#21575 ngrodzitski Dec 3 📝 logr M 14 Apr 9 🔔 RubenRBS uilianries, valgur
#21622 valgur Dec 5 📝 protobuf L 0 👀
#21626 SpaceIm Dec 5 📝 ginkgo M 5 Mar 24 🔔 jwillikers, valgur
#21664 valgur Dec 6 📝 sundials M 3 Apr 18 🔔 danimtb jwillikers
#21666 valgur Dec 6 📝 seqan3 🟦 S 1 Mar 25 🔔 jwillikers
#21689 PodnimatelPingvinov Dec 8 ⏱️ clickhouse-cpp 🟢 XS 1 Mar 24 🔔 valgur
#21713 tpaustian Dec 11 ⏱️ boost 🟢 XS 1 Mar 24 🔔 valgur
#21740 rainman110 Dec 13 🆕 gtlab-logging M 6 May 9 valgur
#21763 talyz Dec 14 📝 tensorflow-lite L 5 Mar 24 🔔 jwillikers, valgur
#21767 toge Dec 14 📝 wasm-micro-runtime M 1 Mar 24 🔔 valgur
#21855 valgur Dec 21 📝 aeron 🟦 S 1 Mar 25 🔔 jwillikers
#21910 valgur Dec 26 📝 mariadb-connector-c L 1 Mar 25 🔔 jwillikers
#21926 valgur Dec 26 📝 armadillo L 2 Jan 10 🔔
#21927 valgur Dec 26 📝 aruco 🟦 S 3 Mar 27 🔔 jwillikers
#21945 toge Dec 26 📝 leptonica M 3 Mar 26 🔔 valgur
#21954 valgur Dec 26 ⏱️ libsigcpp L 1 Jan 6 🔔 RubenRBS
#21985 mayeut Dec 27 📝 dcmtk 🟦 S 3 Apr 10 🔔
#21987 valgur Dec 27 📝 libaec L 1 Feb 26 🔔 jwillikers
#21989 valgur Dec 27 🆕 libmd M 1 Mar 22 🔔 jwillikers
#22002 valgur Dec 27 📝 sdl_net 🟦 S 1 Mar 22 🔔 jwillikers
#22019 valgur Dec 28 📝 apr-util L 1 Mar 25 🔔 jwillikers
#22023 valgur Dec 28 📝 glibmm L 1 Mar 25 🔔 jwillikers
#22040 valgur Dec 28 📝 tk L 0 👀
#22094 anonymousdouble Jan 1 ⏱️ dbus 🟢 XS 0 👀
#22120 toge Jan 3 ⏱️ mbits-lngs 🟢 XS 1 Mar 24 🔔 valgur
#22132 jwillikers Jan 3 📝 qt 🟦 S 1 Apr 19 🔔
#22152 valgur Jan 4 📝 pcl L 2 Apr 30
#22155 fdgStilla Jan 4 📝 onnxruntime M 1 Mar 24 🔔 valgur
#22165 wu-vincent Jan 5 🆕 minhook M 2 Mar 24 🔔 valgur
#22197 valgur Jan 7 📝 libxpm M 2 Apr 25 🔔 jwillikers
#22204 ericLemanissier Jan 8 📝 gdal L 8 May 6 jwillikers
#22229 valgur Jan 9 🆕 libcudacxx M 2 Apr 26 🔔 jwillikers
#22267 jacobfriedman Jan 11 ⏱️ libgit2 M 0 👀
#22290 valgur Jan 13 📝 cimg L 1 Mar 5 🔔
#22318 valgur Jan 13 📝 libbasisu L 1 Mar 25 🔔 jwillikers
#22325 valgur Jan 14 📗 docs L 2 Jan 15 🔔
#22353 valgur Jan 15 📝 llvm-openmp XL 7 Apr 30 jwillikers
#22406 st9007a Jan 17 📝 aws-c-sdkutils 🟦 S 4 Mar 25 🔔 valgur
#22418 valgur Jan 18 📝 tesseract 🟢 XS 1 Mar 25 🔔 jwillikers
#22427 st9007a Jan 18 📝 aws-c-cal 🟢 XS 2 Mar 25 🔔 valgur
#22432 anthonyliot Jan 19 ⏱️ libx264 🟢 XS 3 Mar 24 🔔 valgur
#22456 toge Jan 20 ⏱️ proposal 🟢 XS 1 Mar 24 🔔 valgur
#22539 Artalus Jan 25 📝 abseil 🟢 XS 1 Jan 29 🔔
#22557 fdgStilla Jan 26 ⏱️ onnxruntime L 0 👀
#22574 toge Jan 28 📝 reflect-cpp 🟦 S 9 May 9 franramirez688 RubenRBS, uilianries, czoido
#22575 Ahajha Jan 28 📝 sdl_image 🟦 S 3 Apr 25 🔔
#22584 choll Jan 29 📝 xtr 🟢 XS 1 Mar 24 🔔 valgur
#22614 RazielXYZ Feb 1 📝 async_simple L 12 May 9 danimtb
#22657 StellaSmith Feb 5 📝 glm M 2 Mar 19 🔔 jwillikers, valgur
#22667 valgur Feb 5 📝 gperftools M 4 Mar 25 🔔 jwillikers
#22690 Kaaml Feb 6 📝 date 🟢 XS 2 Mar 24 🔔 ericLemanissier
#22692 Nekto89 Feb 6 📗 docs 🟦 S 0 👀
#22698 toge Feb 7 🆕 battery-embed M 1 Mar 24 🔔
#22708 toge Feb 7 📝 stringzilla L 6 Mar 24 🔔
#22747 jeremy-rifkin Feb 11 ⏱️ folly 🟢 XS 1 Mar 24 🔔 valgur
#22795 Alex-PLACET Feb 16 📝 sqlitecpp 🟦 S 8 Mar 24 🔔
#22823 toge Feb 19 🆕 fpng M 2 Mar 24 🔔 valgur
#22832 klausholstjacobsen Feb 20 ⏱️ openssl 🟦 S 1 Mar 24 🔔 valgur
#22851 valgur Feb 22 📝 stdgpu 🟦 S 1 Mar 13 🔔 jwillikers
#22861 toge Feb 22 📝 miniscript L 4 Mar 24 🔔 valgur
#22865 samuaz Feb 22 🆕 mariadb-connector-cpp L 4 Mar 24 🔔
#22910 Tradias Feb 27 📝 asio-grpc M 1 Mar 24 🔔 valgur
#22951 mologie Mar 1 📝 xnnpack 🟦 S 1 Mar 24 🔔 valgur
#22952 jwillikers Mar 1 📝 libselinux L 1 Mar 24 🔔
#22958 jwillikers Mar 2 📝 fltk 🟢 XS 0 👀
#22983 Ahajha Mar 5 📝 re2 🟦 S 1 Mar 19 🔔 valgur
#22991 jwillikers Mar 5 🆕 pipewire L 6 Mar 26 🔔
#22994 irieger Mar 5 ⏱️ openexr 🟢 XS 1 Mar 24 🔔 valgur
#22997 planetmarshall Mar 5 📝 llvm-core XL 8 Apr 19 🔔 jwillikers
#22998 toge Mar 6 📝 aws-c-auth 🟦 S 3 Apr 11 🔔
#22999 toge Mar 6 ⏱️ aws-c-mqtt 🟢 XS 2 Mar 25 🔔 jwillikers, valgur
#23043 irieger Mar 10 ⏱️ opencolorio 🟢 XS 1 Mar 24 🔔 valgur
#23052 uilianries Mar 11 📗 docs 🟦 S 2 Mar 11 🔔 jcar87
#23066 YSaxon Mar 11 ⏱️ libffi 🟦 S 1 Mar 24 🔔
#23080 RazielXYZ Mar 13 🆕 gaia-ecs M 5 Apr 16 🔔 jwillikers
#23087 spiderkeys Mar 13 🆕 libsndio M 11 Apr 2 🔔
#23095 sophieeihpos Mar 14 📝 protobuf L 10 Apr 26 🔔
#23131 mayeut Mar 17 ⏱️ libsixel 🟢 XS 1 Mar 24 🔔
#23134 mayeut Mar 17 📝 leptonica M 2 Apr 1 🔔 valgur
#23135 mayeut Mar 17 ⏱️ itk 🟦 S 1 Mar 24 🔔
#23138 mayeut Mar 17 ⏱️ freeimage 🟢 XS 2 Apr 20 🔔 jwillikers, valgur
#23143 mayeut Mar 17 ⏱️ gdk-pixbuf 🟦 S 1 Mar 24 🔔
#23147 mayeut Mar 17 ⏱️ opencv 🟢 XS 1 Mar 24 🔔
#23148 mayeut Mar 17 📝 opencv 🟦 S 1 Mar 24 🔔
#23153 js-nano Mar 18 📝 grpc 🟦 S 1 Mar 24 🔔 valgur
#23214 valgur Mar 22 🆕 vlfeat L 0 👀
#23217 StellaSmith Mar 22 ⏱️ libtiff 🟢 XS 1 Mar 24 🔔 valgur
#23221 toge Mar 23 📝 mold 🟢 XS 3 May 3 jwillikers
#23223 valgur Mar 23 📝 premake L 5 Mar 23 🔔
#23241 toge Mar 25 ⏱️ ssp 🟢 XS 1 Mar 25 🔔 valgur
#23252 valgur Mar 25 ⏱️ cfitsio L 0 👀
#23253 valgur Mar 25 📝 dav1d M 0 👀
#23255 valgur Mar 25 📝 harfbuzz L 3 Apr 1 🔔 RubenRBS jwillikers
#23256 valgur Mar 25 📝 hwloc 🟦 S 1 Mar 25 🔔
#23257 valgur Mar 25 📝 jasper L 1 Apr 1 🔔 jwillikers
#23270 xyz1001 Mar 26 🆕 platformfolders M 1 May 9 danimtb
#23272 johningve Mar 26 📝 glfw 🟦 S 2 Apr 9 🔔 jwillikers
#23304 gegles Mar 29 📝 openssl 🟦 S 4 Apr 26 🔔 jcar87 valgur, Croydon
#23319 toge Mar 31 📝 harfbuzz 🟦 S 3 May 9 jwillikers
#23336 valgur Apr 2 📝 libcvd 🟦 S 0 👀
#23346 sizeak Apr 2 📝 android-ndk 🟦 S 0 👀
#23347 MikeLankamp Apr 2 📝 diligent-core L 1 Apr 3 🔔 valgur
#23359 AndreyMlashkin Apr 3 ⏱️ gcc 🟢 XS 0 👀
#23362 Ahajha Apr 4 📝 libffi L 1 Apr 8 🔔
#23383 valgur Apr 5 📝 libpcap M 1 Apr 9 🔔 jwillikers
#23392 gouriano Apr 5 📝 ncbi-cxx-toolkit-public XL 0
#23393 valgur Apr 5 📝 onetbb 🟦 S 1 Apr 9 🔔 jwillikers
#23394 Ahajha Apr 6 📝 cpython L 11 Apr 10 🔔 jwillikers
#23409 mayeut Apr 7 📝 onnxruntime L 0 👀
#23429 toge Apr 9 📝 aws-lambda-cpp 🟦 S 0 👀
#23481 elvisdukaj Apr 11 📝 mingw-builds M 1 Apr 17 🔔
#23502 Jie-Cheng Apr 12 ⏱️ simdjson 🟢 XS 0 👀
#23517 mayeut Apr 13 ⏱️ qt 🟦 S 4 May 7 jwillikers, MartinDelille
#23521 toge Apr 14 🆕 tidwall-neco M 1 Apr 15 🔔
#23530 valgur Apr 15 🆕 coin-buildtools M 0 👀
#23539 tkhyn Apr 15 📝 osqp L 6 Apr 15 🔔
#23559 valgur Apr 15 📝 glib M 2 May 8 ericLemanissier
#23571 ericLemanissier Apr 16 📝 qt XL 9 Apr 23 🔔 jwillikers
#23594 uilianries Apr 17 ⚙️ .c3i 🟦 S 3 Apr 17 🔔 jcar87 RubenRBS, jwillikers
#23598 MartinDelille Apr 17 📝 openapi-generator 🟦 S 0 👀
#23602 adamws Apr 17 📝 cyrus-sasl 🟢 XS 2 Apr 20 🔔 valgur
#23607 Arenoros Apr 17 ⏱️ lief M 0 👀
#23612 basiliscos Apr 17 📝 util-linux-libuuid 🟢 XS 2 Apr 20 🔔 Ahajha
#23626 mayeut Apr 17 ⏱️ xmlsec 🟢 XS 0 👀
#23629 toge Apr 18 📝 duckdb M 1 May 9 RubenRBS
#23632 pichi-router Apr 18 📝 botan 🟢 XS 1 Apr 20 🔔
#23639 HappySeaFox Apr 18 📝 sail 🟢 XS 0 👀
#23645 anton-danielsson Apr 18 📝 qcustomplot M 7 Apr 20 🔔 ericLemanissier
#23648 Ahajha Apr 19 📝 cpython 🟢 XS 0 👀
#23653 robomics Apr 19 ⏱️ boost 🟢 XS 0 👀
#23654 robomics Apr 19 📝 libarchive 🟢 XS 0 👀
#23656 TheHugeManatee Apr 19 📝 kdbindings 🟢 XS 0 👀
#23663 trns1997 Apr 19 🆕 azure-sdk-for-cpp L 2 May 3
#23666 mayeut Apr 20 ⏱️ libxmlpp 🟢 XS 0
#23667 mayeut Apr 20 ⏱️ libspatialite 🟢 XS 2 May 8 jwillikers
#23668 mayeut Apr 20 ⏱️ libgphoto2 🟢 XS 0
#23671 laci-aura Apr 20 🆕 zxcvbn L 0 👀
#23677 toge Apr 20 📝 metall 🟦 S 0 👀
#23680 valgur Apr 20 📝 flac 🟦 S 0 👀
#23683 valgur Apr 20 📝 libssh2 M 0 👀
#23695 dbolduc Apr 22 📝 google-cloud-cpp L 0 👀
#23696 toge Apr 22 📝 oatpp L 1 Apr 22 🔔
#23704 anton-danielsson Apr 22 📝 openscenegraph XL 1 May 9 czoido
#23709 toge Apr 23 📝 mimalloc L 0 👀
#23720 valgur Apr 23 🆕 libosmium M 3 Apr 30
#23731 tbeu Apr 23 📝 laszip M 0 👀
#23733 PLeVasseur Apr 23 🆕 up-cpp L 0 👀
#23735 valgur Apr 23 📝 assimp 🟦 S 1 Apr 28
#23757 jcar87 Apr 25 ⚙️ .github L 2 Apr 25 🔔
#23762 lubomirjurukov Apr 25 ⏱️ ixwebsocket 🟢 XS 0 👀
#23779 SpaceIm Apr 26 📝 glfw 🟢 XS 2 May 2 jwillikers
#23780 SpaceIm Apr 26 📝 xkbcommon 🟢 XS 1 Apr 27 🔔 jwillikers
#23782 valgur Apr 26 🆕 pangolin L 0 👀
#23787 mologie Apr 27 ⏱️ pybind11_json 🟢 XS 0 👀
#23788 DoomHammer Apr 27 📝 ohpipeline 🟢 XS 0 👀
#23806 mayeut Apr 29 📝 tar M 2 Apr 30 jwillikers
#23810 toge Apr 29 📝 libsvtav1 🟢 XS 2 Apr 30 jwillikers
#23846 Mi-La May 2 📝 zserio M 0 👀
#23852 jmdaly May 2 📝 ouster_sdk 🟢 XS 1 May 6 valgur
#23853 ericLemanissier May 3 📝 libwebsockets 🟦 S 4 May 8 Croydon
#23864 gegles May 3 ⏱️ restinio 🟢 XS 0
#23889 valgur May 6 🆕 stella-cv-fbow M 2 May 9 RubenRBS
#23890 gegles May 6 ⏱️ gegles-spdlog_setup 🟢 XS 1 May 6 hoyhoy
#23894 datalogics-staylor May 6 📝 qr-code-generator M 0
#23901 toge May 7 📝 daw_utf_range 🟦 S 0
#23907 soroosh-sdi May 7 📝 lzham 🟦 S 2 May 9 RubenRBS
#23920 franramirez688 May 8 ⏱️ yomm2 M 2 May 9
#23935 toge May 9 📝 nghttp3 🟢 XS 0
#23937 ErniGH May 9 ⏱️ freeimage 🟦 S 2 May 9 RubenRBS

✔️ Ready to Merge

Currently 2 pull requests are waiting to be merged 🎉

PR By Opened Recipe Reviews 🌟 Approvers
#22876 RubenRBS Feb 24 🆕 dispenso 3 uilianries, jwillikers
#23936 ErniGH May 9 📝 libelfin 2 RubenRBS, uilianries

📋 Statistics

⚠️ These are just rough metrics counting the labels and may not reflect the actual state of pull requests

  • Commit: ac56a08
  • Pull Requests:
    • Open: 591
    • Draft: 53
    • Average Age: 126 days, 17 hours, and 26.78 minutes
    • Stop Label: 280

Raw JSON data

📊 Open Versus Merged

Legend

Pull requests are depicted as:

  • Open 🟩
  • Closed 🟥
  • Merged 🟪
    • Darker bottom section indicated merged within 7 days of being opened

For reference:

  • 100% is 252 (most in the last year)
  • 60% is 151

ovm

⌛ Time Spent in Review

If you are wondering how long it will take for you pull request to get merged; this graph should give you an idea.

tir

Found this useful? Give it a ⭐ 🙏

add the Pull Requests title in the table

Also, I'm not sure I understand the selection criteria, but is it right that PRs disappear from this list 24h after creation, if they get no review ? Wouldn't it be better to simply list all PR which have at least one approval, or no approval and no blocker, regardless of the creation date ?

Time in review: Daily average

In recent weeks, end of March 2021, there has been an apparent slump in the number of PRs being merged.... but it's always better to qualify things!

With a rich GoLang environment there are many 'data visualization' like

  • go-chart 👈 This supported overlapping lines which was desired
  • go-echarts

Objectives

  1. Trend graph with daily in review and merged pull requests
    • two axes graph comparing how many of each (ideally a moving line) #21
  2. Analysis graph of the average time a PR spend in review #12
    • I would love a stock analysis graph to see the range in the moving average This is difficult since there's no "open/close" values only "low, average, high"
  3. Seeing the big picture is nice, but it would be great to have a better view with a 60 day graph #21
    • 30 or 60 day linear regression on the full chart

Considerations

  • data storage and retrieval, branch or new comment?
  • image storage and format?
    • go-chart only supports PNG
    • it was trivial to save it in the git repo
  • retrospectively gathering data, from when?
    • TBA: basic is cheap on API calls and can be run on the fly
  • including weekends?
    • Typically no changes but oddly enough it's never "0"
  • Consider PRs based on closed date instead of open?
  • Should there be a ceiling since the graph library does not support exponential scaling

Update table every 10 minutes

What do you think about updating the table not every 24 hours, but every 10 minutes?

This way, the merged PRs will disappear faster, and the PRs which waited for > 24 hours will really wait maximum for 24h10min.

Two downsides:

  • the number of queries allowed.
  • we need to be careful with notifications about changes - if nothing has changed, there should be no notification.

CI status indicator is out of date

There is some new beautiful integration between c3i and GitHub statuses...

image

...which makes the implementation out of date! Now it will never show a warning.

func (s *RepositoryService) GetCommitStatus(ctx context.Context, owner string, repo string, sha string) (*RepoStatus, *Response, error) {
statuses, resp, err := s.client.Repositories.ListStatuses(ctx, owner, repo, sha, &ListOptions{
Page: 0,
PerPage: 1,

Since only the first (no longer the only) status is checked.

Approving then commenting does not dismiss approval

This has been a TODO but i finally had a realy PR where this was meaningful

case "COMMENTED":
// Out-dated Approvals are transformed into comments https://github.com/conan-io/conan-center-index/pull/3855#issuecomment-770120073
// TODO: Figure out how GitHub knows what they were!
default:

conan-io/conan-center-index#14703

[
  {
    "id": 1215615204,
    "node_id": "PRR_kwDODDMJAM5IdNDk",
    "user": {
      "login": "uilianries",
      "id": 4870173,
      "node_id": "MDQ6VXNlcjQ4NzAxNzM=",
      "avatar_url": "https://avatars.githubusercontent.com/u/4870173?u=4da785f36e3fca58a19ba19779bdfcfd348dd77d&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/uilianries",
      "html_url": "https://github.com/uilianries",
      "followers_url": "https://api.github.com/users/uilianries/followers",
      "following_url": "https://api.github.com/users/uilianries/following{/other_user}",
      "gists_url": "https://api.github.com/users/uilianries/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/uilianries/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/uilianries/subscriptions",
      "organizations_url": "https://api.github.com/users/uilianries/orgs",
      "repos_url": "https://api.github.com/users/uilianries/repos",
      "events_url": "https://api.github.com/users/uilianries/events{/privacy}",
      "received_events_url": "https://api.github.com/users/uilianries/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1215615204",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703",
    "author_association": "MEMBER",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1215615204"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703"
      }
    },
    "submitted_at": "2022-12-13T14:42:11Z",
    "commit_id": "d3778ba17527fdcc198157635b0888ee917032d1"
  },
  {
    "id": 1215616053,
    "node_id": "PRR_kwDODDMJAM5IdNQ1",
    "user": {
      "login": "uilianries",
      "id": 4870173,
      "node_id": "MDQ6VXNlcjQ4NzAxNzM=",
      "avatar_url": "https://avatars.githubusercontent.com/u/4870173?u=4da785f36e3fca58a19ba19779bdfcfd348dd77d&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/uilianries",
      "html_url": "https://github.com/uilianries",
      "followers_url": "https://api.github.com/users/uilianries/followers",
      "following_url": "https://api.github.com/users/uilianries/following{/other_user}",
      "gists_url": "https://api.github.com/users/uilianries/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/uilianries/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/uilianries/subscriptions",
      "organizations_url": "https://api.github.com/users/uilianries/orgs",
      "repos_url": "https://api.github.com/users/uilianries/repos",
      "events_url": "https://api.github.com/users/uilianries/events{/privacy}",
      "received_events_url": "https://api.github.com/users/uilianries/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "Thank you for your contribution. I see you are using Conan in your project already 😸 ",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1215616053",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703",
    "author_association": "MEMBER",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1215616053"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703"
      }
    },
    "submitted_at": "2022-12-13T14:50:39Z",
    "commit_id": "d3778ba17527fdcc198157635b0888ee917032d1"
  },
  {
    "id": 1221749995,
    "node_id": "PRR_kwDODDMJAM5I0mzr",
    "user": {
      "login": "bennyhuo",
      "id": 6336960,
      "node_id": "MDQ6VXNlcjYzMzY5NjA=",
      "avatar_url": "https://avatars.githubusercontent.com/u/6336960?u=d0d5a2882488efebe256beba1883d2aa44c3db8d&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/bennyhuo",
      "html_url": "https://github.com/bennyhuo",
      "followers_url": "https://api.github.com/users/bennyhuo/followers",
      "following_url": "https://api.github.com/users/bennyhuo/following{/other_user}",
      "gists_url": "https://api.github.com/users/bennyhuo/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/bennyhuo/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/bennyhuo/subscriptions",
      "organizations_url": "https://api.github.com/users/bennyhuo/orgs",
      "repos_url": "https://api.github.com/users/bennyhuo/repos",
      "events_url": "https://api.github.com/users/bennyhuo/events{/privacy}",
      "received_events_url": "https://api.github.com/users/bennyhuo/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1221749995",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703",
    "author_association": "NONE",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1221749995"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703"
      }
    },
    "submitted_at": "2022-12-17T08:03:52Z",
    "commit_id": "d3778ba17527fdcc198157635b0888ee917032d1"
  },
  {
    "id": 1221750124,
    "node_id": "PRR_kwDODDMJAM5I0m1s",
    "user": {
      "login": "bennyhuo",
      "id": 6336960,
      "node_id": "MDQ6VXNlcjYzMzY5NjA=",
      "avatar_url": "https://avatars.githubusercontent.com/u/6336960?u=d0d5a2882488efebe256beba1883d2aa44c3db8d&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/bennyhuo",
      "html_url": "https://github.com/bennyhuo",
      "followers_url": "https://api.github.com/users/bennyhuo/followers",
      "following_url": "https://api.github.com/users/bennyhuo/following{/other_user}",
      "gists_url": "https://api.github.com/users/bennyhuo/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/bennyhuo/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/bennyhuo/subscriptions",
      "organizations_url": "https://api.github.com/users/bennyhuo/orgs",
      "repos_url": "https://api.github.com/users/bennyhuo/repos",
      "events_url": "https://api.github.com/users/bennyhuo/events{/privacy}",
      "received_events_url": "https://api.github.com/users/bennyhuo/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1221750124",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703",
    "author_association": "NONE",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1221750124"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703"
      }
    },
    "submitted_at": "2022-12-17T08:05:35Z",
    "commit_id": "d3778ba17527fdcc198157635b0888ee917032d1"
  },
  {
    "id": 1221754527,
    "node_id": "PRR_kwDODDMJAM5I0n6f",
    "user": {
      "login": "bennyhuo",
      "id": 6336960,
      "node_id": "MDQ6VXNlcjYzMzY5NjA=",
      "avatar_url": "https://avatars.githubusercontent.com/u/6336960?u=d0d5a2882488efebe256beba1883d2aa44c3db8d&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/bennyhuo",
      "html_url": "https://github.com/bennyhuo",
      "followers_url": "https://api.github.com/users/bennyhuo/followers",
      "following_url": "https://api.github.com/users/bennyhuo/following{/other_user}",
      "gists_url": "https://api.github.com/users/bennyhuo/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/bennyhuo/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/bennyhuo/subscriptions",
      "organizations_url": "https://api.github.com/users/bennyhuo/orgs",
      "repos_url": "https://api.github.com/users/bennyhuo/repos",
      "events_url": "https://api.github.com/users/bennyhuo/events{/privacy}",
      "received_events_url": "https://api.github.com/users/bennyhuo/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1221754527",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703",
    "author_association": "NONE",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1221754527"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703"
      }
    },
    "submitted_at": "2022-12-17T08:29:08Z",
    "commit_id": "d3778ba17527fdcc198157635b0888ee917032d1"
  },
  {
    "id": 1263503119,
    "node_id": "PRR_kwDODDMJAM5LT4cP",
    "user": {
      "login": "uilianries",
      "id": 4870173,
      "node_id": "MDQ6VXNlcjQ4NzAxNzM=",
      "avatar_url": "https://avatars.githubusercontent.com/u/4870173?u=4da785f36e3fca58a19ba19779bdfcfd348dd77d&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/uilianries",
      "html_url": "https://github.com/uilianries",
      "followers_url": "https://api.github.com/users/uilianries/followers",
      "following_url": "https://api.github.com/users/uilianries/following{/other_user}",
      "gists_url": "https://api.github.com/users/uilianries/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/uilianries/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/uilianries/subscriptions",
      "organizations_url": "https://api.github.com/users/uilianries/orgs",
      "repos_url": "https://api.github.com/users/uilianries/repos",
      "events_url": "https://api.github.com/users/uilianries/events{/privacy}",
      "received_events_url": "https://api.github.com/users/uilianries/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "@bennyhuo  Thank you for your contribution! Please, take a look on my review",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1263503119",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703",
    "author_association": "MEMBER",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1263503119"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703"
      }
    },
    "submitted_at": "2023-01-20T12:46:25Z",
    "commit_id": "bb2e1c54324fc12dee422af1b81c2cc1dabfbdc5"
  },
  {
    "id": 1376580934,
    "node_id": "PRR_kwDODDMJAM5SDPVG",
    "user": {
      "login": "prince-chrismc",
      "id": 16867443,
      "node_id": "MDQ6VXNlcjE2ODY3NDQz",
      "avatar_url": "https://avatars.githubusercontent.com/u/16867443?u=d7c5b45b864fe5d26e44d38645a22f8af18a2a16&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/prince-chrismc",
      "html_url": "https://github.com/prince-chrismc",
      "followers_url": "https://api.github.com/users/prince-chrismc/followers",
      "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}",
      "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions",
      "organizations_url": "https://api.github.com/users/prince-chrismc/orgs",
      "repos_url": "https://api.github.com/users/prince-chrismc/repos",
      "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}",
      "received_events_url": "https://api.github.com/users/prince-chrismc/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "Overall looks good, since this has been open for a while (sorry about that) there's more updates I'd like to sneak in",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1376580934",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1376580934"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703"
      }
    },
    "submitted_at": "2023-04-07T21:07:57Z",
    "commit_id": "6b173fd061c77e5eb51990f372d9c138f14bd7fa"
  },
  {
    "id": 1376588362,
    "node_id": "PRR_kwDODDMJAM5SDRJK",
    "user": {
      "login": "prince-chrismc",
      "id": 16867443,
      "node_id": "MDQ6VXNlcjE2ODY3NDQz",
      "avatar_url": "https://avatars.githubusercontent.com/u/16867443?u=d7c5b45b864fe5d26e44d38645a22f8af18a2a16&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/prince-chrismc",
      "html_url": "https://github.com/prince-chrismc",
      "followers_url": "https://api.github.com/users/prince-chrismc/followers",
      "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}",
      "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions",
      "organizations_url": "https://api.github.com/users/prince-chrismc/orgs",
      "repos_url": "https://api.github.com/users/prince-chrismc/repos",
      "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}",
      "received_events_url": "https://api.github.com/users/prince-chrismc/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "I have some concerns about this project, since it's a fork we usually do not allow those\r\n\r\nand when they add enough value we ask for teh author prefix... but when I was looking into I noticed this has a copy of \r\n\r\nhttps://github.com/tinycthread/tinycthread\r\n\r\nembeeded inside ... which is fine but for conan that  would ideal be a dependency since people could want to use two lirbaries that depend on it this and something else that would hit linkage issues.\r\n\r\nHave you considered linking against  this library instead of copying it?\r\n\r\nhttps://github.com/mbrossard/threadpool/compare/master...bennyhuo:tinycthreadpool:master#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1376588362",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1376588362"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703"
      }
    },
    "submitted_at": "2023-04-07T21:13:24Z",
    "commit_id": "6b173fd061c77e5eb51990f372d9c138f14bd7fa"
  },
  {
    "id": 1387342546,
    "node_id": "PRR_kwDODDMJAM5SsSrS",
    "user": {
      "login": "prince-chrismc",
      "id": 16867443,
      "node_id": "MDQ6VXNlcjE2ODY3NDQz",
      "avatar_url": "https://avatars.githubusercontent.com/u/16867443?u=d7c5b45b864fe5d26e44d38645a22f8af18a2a16&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/prince-chrismc",
      "html_url": "https://github.com/prince-chrismc",
      "followers_url": "https://api.github.com/users/prince-chrismc/followers",
      "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}",
      "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions",
      "organizations_url": "https://api.github.com/users/prince-chrismc/orgs",
      "repos_url": "https://api.github.com/users/prince-chrismc/repos",
      "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}",
      "received_events_url": "https://api.github.com/users/prince-chrismc/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "APPROVED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1387342546",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1387342546"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703"
      }
    },
    "submitted_at": "2023-04-17T06:20:36Z",
    "commit_id": "15a34845a485c62667cd48ba4dd6c3b7b5738364"
  },
  {
    "id": 1387393721,
    "node_id": "PRR_kwDODDMJAM5SsfK5",
    "user": {
      "login": "prince-chrismc",
      "id": 16867443,
      "node_id": "MDQ6VXNlcjE2ODY3NDQz",
      "avatar_url": "https://avatars.githubusercontent.com/u/16867443?u=d7c5b45b864fe5d26e44d38645a22f8af18a2a16&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/prince-chrismc",
      "html_url": "https://github.com/prince-chrismc",
      "followers_url": "https://api.github.com/users/prince-chrismc/followers",
      "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}",
      "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions",
      "organizations_url": "https://api.github.com/users/prince-chrismc/orgs",
      "repos_url": "https://api.github.com/users/prince-chrismc/repos",
      "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}",
      "received_events_url": "https://api.github.com/users/prince-chrismc/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1387393721",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1387393721"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703"
      }
    },
    "submitted_at": "2023-04-17T07:03:01Z",
    "commit_id": "15a34845a485c62667cd48ba4dd6c3b7b5738364"
  },
  {
    "id": 1387394336,
    "node_id": "PRR_kwDODDMJAM5SsfUg",
    "user": {
      "login": "prince-chrismc",
      "id": 16867443,
      "node_id": "MDQ6VXNlcjE2ODY3NDQz",
      "avatar_url": "https://avatars.githubusercontent.com/u/16867443?u=d7c5b45b864fe5d26e44d38645a22f8af18a2a16&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/prince-chrismc",
      "html_url": "https://github.com/prince-chrismc",
      "followers_url": "https://api.github.com/users/prince-chrismc/followers",
      "following_url": "https://api.github.com/users/prince-chrismc/following{/other_user}",
      "gists_url": "https://api.github.com/users/prince-chrismc/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/prince-chrismc/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/prince-chrismc/subscriptions",
      "organizations_url": "https://api.github.com/users/prince-chrismc/orgs",
      "repos_url": "https://api.github.com/users/prince-chrismc/repos",
      "events_url": "https://api.github.com/users/prince-chrismc/events{/privacy}",
      "received_events_url": "https://api.github.com/users/prince-chrismc/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1387394336",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/14703#pullrequestreview-1387394336"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/14703"
      }
    },
    "submitted_at": "2023-04-17T07:03:32Z",
    "commit_id": "15a34845a485c62667cd48ba4dd6c3b7b5738364"
  }
]

[bug] Approval, Request Change, Approve produces incorrect counting of valid approvals

Seems like this code is not working 🤔

if !new { // Duplicate review (usually an accident)
break


Update:

Seems to be a consequence of #4, by maintaining a unique list of blockers/approvers we need to decrement the counter when approvals are disregarded

summary.HeadCommitApprovals = removeUnique(summary.HeadCommitApprovals, reviewerName)

Valid PR changing github config are rejected

16926 rejected for the files, or lack thereof, make this PR invalid

https://github.com/prince-chrismc/conan-center-index-pending-review/actions/runs/4635084174/jobs/8201840810#step:6:235


https://api.github.com/repos/conan-io/conan-center-index/pulls/16926/files

[
  {
    "sha": "b2733bea8c3a6b0a91b16f06a9e3627501640c1e",
    "filename": ".gitignore",
    "status": "modified",
    "additions": 1,
    "deletions": 0,
    "changes": 1,
    "blob_url": "https://github.com/conan-io/conan-center-index/blob/78324089bb218ee4bff6a49259f485ed1dc1014a/.gitignore",
    "raw_url": "https://github.com/conan-io/conan-center-index/raw/78324089bb218ee4bff6a49259f485ed1dc1014a/.gitignore",
    "contents_url": "https://api.github.com/repos/conan-io/conan-center-index/contents/.gitignore?ref=78324089bb218ee4bff6a49259f485ed1dc1014a",
    "patch": "@@ -1,5 +1,6 @@\n # Conan specific\n **/test_package/build/\n+**/test_package/build-*/\n **/test_package/test_output/\n conan.lock\n conanbuildinfo.txt"
  }
]

https://api.github.com/repos/conan-io/conan-center-index/pulls/16926

{
  "url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16926",
  "id": 1304761391,
  "node_id": "PR_kwDODDMJAM5NxRQv",
  "html_url": "https://github.com/conan-io/conan-center-index/pull/16926",
  "diff_url": "https://github.com/conan-io/conan-center-index/pull/16926.diff",
  "patch_url": "https://github.com/conan-io/conan-center-index/pull/16926.patch",
  "issue_url": "https://api.github.com/repos/conan-io/conan-center-index/issues/16926",
  "number": 16926,
  "state": "open",
  "locked": false,
  "title": "Ignore more test_package build dir patterns",
  "user": {
    "login": "gjasny",
    "id": 1165598,
    "node_id": "MDQ6VXNlcjExNjU1OTg=",
    "avatar_url": "https://avatars.githubusercontent.com/u/1165598?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/gjasny",
    "html_url": "https://github.com/gjasny",
    "followers_url": "https://api.github.com/users/gjasny/followers",
    "following_url": "https://api.github.com/users/gjasny/following{/other_user}",
    "gists_url": "https://api.github.com/users/gjasny/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/gjasny/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/gjasny/subscriptions",
    "organizations_url": "https://api.github.com/users/gjasny/orgs",
    "repos_url": "https://api.github.com/users/gjasny/repos",
    "events_url": "https://api.github.com/users/gjasny/events{/privacy}",
    "received_events_url": "https://api.github.com/users/gjasny/received_events",
    "type": "User",
    "site_admin": false
  },
  "body": "In the binutils recipe (PR #16920) with `basic_layout`, a `recipes/binutils/all/test_package/build-release/`\r\ndirectory appears.\r\n\r\n---\r\n\r\n- [x] I've read the [contributing guidelines](https://github.com/conan-io/conan-center-index/blob/master/CONTRIBUTING.md).\r\n- [x] I've used a [recent](https://github.com/conan-io/conan/releases/latest) Conan client version close to the [currently deployed](https://github.com/conan-io/conan-center-index/blob/master/.c3i/config_v1.yml#L6).\r\n- [x] I've tried at least one configuration locally with the [conan-center hook](https://github.com/conan-io/hooks.git) activated.\r\n",
  "created_at": "2023-04-06T13:29:39Z",
  "updated_at": "2023-04-07T03:48:25Z",
  "closed_at": null,
  "merged_at": null,
  "merge_commit_sha": "9ac70a7505de900c055786e2c645f2704890a36a",
  "assignee": null,
  "assignees": [

  ],
  "requested_reviewers": [

  ],
  "requested_teams": [

  ],
  "labels": [
    {
      "id": 2795529524,
      "node_id": "MDU6TGFiZWwyNzk1NTI5NTI0",
      "url": "https://api.github.com/repos/conan-io/conan-center-index/labels/GitHub%20config",
      "name": "GitHub config",
      "color": "0AF35C",
      "default": false,
      "description": ""
    }
  ],
  "milestone": null,
  "draft": false,
  "commits_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16926/commits",
  "review_comments_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16926/comments",
  "review_comment_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/comments{/number}",
  "comments_url": "https://api.github.com/repos/conan-io/conan-center-index/issues/16926/comments",
  "statuses_url": "https://api.github.com/repos/conan-io/conan-center-index/statuses/78324089bb218ee4bff6a49259f485ed1dc1014a",
  "head": {
    "label": "gjasny:extend-gitignore",
    "ref": "extend-gitignore",
    "sha": "78324089bb218ee4bff6a49259f485ed1dc1014a",
    "user": {
      "login": "gjasny",
      "id": 1165598,
      "node_id": "MDQ6VXNlcjExNjU1OTg=",
      "avatar_url": "https://avatars.githubusercontent.com/u/1165598?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/gjasny",
      "html_url": "https://github.com/gjasny",
      "followers_url": "https://api.github.com/users/gjasny/followers",
      "following_url": "https://api.github.com/users/gjasny/following{/other_user}",
      "gists_url": "https://api.github.com/users/gjasny/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/gjasny/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/gjasny/subscriptions",
      "organizations_url": "https://api.github.com/users/gjasny/orgs",
      "repos_url": "https://api.github.com/users/gjasny/repos",
      "events_url": "https://api.github.com/users/gjasny/events{/privacy}",
      "received_events_url": "https://api.github.com/users/gjasny/received_events",
      "type": "User",
      "site_admin": false
    },
    "repo": {
      "id": 429185352,
      "node_id": "R_kgDOGZTZSA",
      "name": "conan-center-index",
      "full_name": "gjasny/conan-center-index",
      "private": false,
      "owner": {
        "login": "gjasny",
        "id": 1165598,
        "node_id": "MDQ6VXNlcjExNjU1OTg=",
        "avatar_url": "https://avatars.githubusercontent.com/u/1165598?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/gjasny",
        "html_url": "https://github.com/gjasny",
        "followers_url": "https://api.github.com/users/gjasny/followers",
        "following_url": "https://api.github.com/users/gjasny/following{/other_user}",
        "gists_url": "https://api.github.com/users/gjasny/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/gjasny/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/gjasny/subscriptions",
        "organizations_url": "https://api.github.com/users/gjasny/orgs",
        "repos_url": "https://api.github.com/users/gjasny/repos",
        "events_url": "https://api.github.com/users/gjasny/events{/privacy}",
        "received_events_url": "https://api.github.com/users/gjasny/received_events",
        "type": "User",
        "site_admin": false
      },
      "html_url": "https://github.com/gjasny/conan-center-index",
      "description": "Recipes for the ConanCenter repository",
      "fork": true,
      "url": "https://api.github.com/repos/gjasny/conan-center-index",
      "forks_url": "https://api.github.com/repos/gjasny/conan-center-index/forks",
      "keys_url": "https://api.github.com/repos/gjasny/conan-center-index/keys{/key_id}",
      "collaborators_url": "https://api.github.com/repos/gjasny/conan-center-index/collaborators{/collaborator}",
      "teams_url": "https://api.github.com/repos/gjasny/conan-center-index/teams",
      "hooks_url": "https://api.github.com/repos/gjasny/conan-center-index/hooks",
      "issue_events_url": "https://api.github.com/repos/gjasny/conan-center-index/issues/events{/number}",
      "events_url": "https://api.github.com/repos/gjasny/conan-center-index/events",
      "assignees_url": "https://api.github.com/repos/gjasny/conan-center-index/assignees{/user}",
      "branches_url": "https://api.github.com/repos/gjasny/conan-center-index/branches{/branch}",
      "tags_url": "https://api.github.com/repos/gjasny/conan-center-index/tags",
      "blobs_url": "https://api.github.com/repos/gjasny/conan-center-index/git/blobs{/sha}",
      "git_tags_url": "https://api.github.com/repos/gjasny/conan-center-index/git/tags{/sha}",
      "git_refs_url": "https://api.github.com/repos/gjasny/conan-center-index/git/refs{/sha}",
      "trees_url": "https://api.github.com/repos/gjasny/conan-center-index/git/trees{/sha}",
      "statuses_url": "https://api.github.com/repos/gjasny/conan-center-index/statuses/{sha}",
      "languages_url": "https://api.github.com/repos/gjasny/conan-center-index/languages",
      "stargazers_url": "https://api.github.com/repos/gjasny/conan-center-index/stargazers",
      "contributors_url": "https://api.github.com/repos/gjasny/conan-center-index/contributors",
      "subscribers_url": "https://api.github.com/repos/gjasny/conan-center-index/subscribers",
      "subscription_url": "https://api.github.com/repos/gjasny/conan-center-index/subscription",
      "commits_url": "https://api.github.com/repos/gjasny/conan-center-index/commits{/sha}",
      "git_commits_url": "https://api.github.com/repos/gjasny/conan-center-index/git/commits{/sha}",
      "comments_url": "https://api.github.com/repos/gjasny/conan-center-index/comments{/number}",
      "issue_comment_url": "https://api.github.com/repos/gjasny/conan-center-index/issues/comments{/number}",
      "contents_url": "https://api.github.com/repos/gjasny/conan-center-index/contents/{+path}",
      "compare_url": "https://api.github.com/repos/gjasny/conan-center-index/compare/{base}...{head}",
      "merges_url": "https://api.github.com/repos/gjasny/conan-center-index/merges",
      "archive_url": "https://api.github.com/repos/gjasny/conan-center-index/{archive_format}{/ref}",
      "downloads_url": "https://api.github.com/repos/gjasny/conan-center-index/downloads",
      "issues_url": "https://api.github.com/repos/gjasny/conan-center-index/issues{/number}",
      "pulls_url": "https://api.github.com/repos/gjasny/conan-center-index/pulls{/number}",
      "milestones_url": "https://api.github.com/repos/gjasny/conan-center-index/milestones{/number}",
      "notifications_url": "https://api.github.com/repos/gjasny/conan-center-index/notifications{?since,all,participating}",
      "labels_url": "https://api.github.com/repos/gjasny/conan-center-index/labels{/name}",
      "releases_url": "https://api.github.com/repos/gjasny/conan-center-index/releases{/id}",
      "deployments_url": "https://api.github.com/repos/gjasny/conan-center-index/deployments",
      "created_at": "2021-11-17T20:06:52Z",
      "updated_at": "2023-01-03T15:24:44Z",
      "pushed_at": "2023-04-06T19:01:26Z",
      "git_url": "git://github.com/gjasny/conan-center-index.git",
      "ssh_url": "[email protected]:gjasny/conan-center-index.git",
      "clone_url": "https://github.com/gjasny/conan-center-index.git",
      "svn_url": "https://github.com/gjasny/conan-center-index",
      "homepage": "https://conan.io/center",
      "size": 45537,
      "stargazers_count": 0,
      "watchers_count": 0,
      "language": "Python",
      "has_issues": false,
      "has_projects": true,
      "has_downloads": true,
      "has_wiki": true,
      "has_pages": false,
      "has_discussions": false,
      "forks_count": 0,
      "mirror_url": null,
      "archived": false,
      "disabled": false,
      "open_issues_count": 0,
      "license": {
        "key": "mit",
        "name": "MIT License",
        "spdx_id": "MIT",
        "url": "https://api.github.com/licenses/mit",
        "node_id": "MDc6TGljZW5zZTEz"
      },
      "allow_forking": true,
      "is_template": false,
      "web_commit_signoff_required": false,
      "topics": [

      ],
      "visibility": "public",
      "forks": 0,
      "open_issues": 0,
      "watchers": 0,
      "default_branch": "master"
    }
  },
  "base": {
    "label": "conan-io:master",
    "ref": "master",
    "sha": "b6207edbf977620839137e5365558cfe6663e16c",
    "user": {
      "login": "conan-io",
      "id": 15212165,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjE1MjEyMTY1",
      "avatar_url": "https://avatars.githubusercontent.com/u/15212165?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/conan-io",
      "html_url": "https://github.com/conan-io",
      "followers_url": "https://api.github.com/users/conan-io/followers",
      "following_url": "https://api.github.com/users/conan-io/following{/other_user}",
      "gists_url": "https://api.github.com/users/conan-io/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/conan-io/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/conan-io/subscriptions",
      "organizations_url": "https://api.github.com/users/conan-io/orgs",
      "repos_url": "https://api.github.com/users/conan-io/repos",
      "events_url": "https://api.github.com/users/conan-io/events{/privacy}",
      "received_events_url": "https://api.github.com/users/conan-io/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "repo": {
      "id": 204671232,
      "node_id": "MDEwOlJlcG9zaXRvcnkyMDQ2NzEyMzI=",
      "name": "conan-center-index",
      "full_name": "conan-io/conan-center-index",
      "private": false,
      "owner": {
        "login": "conan-io",
        "id": 15212165,
        "node_id": "MDEyOk9yZ2FuaXphdGlvbjE1MjEyMTY1",
        "avatar_url": "https://avatars.githubusercontent.com/u/15212165?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/conan-io",
        "html_url": "https://github.com/conan-io",
        "followers_url": "https://api.github.com/users/conan-io/followers",
        "following_url": "https://api.github.com/users/conan-io/following{/other_user}",
        "gists_url": "https://api.github.com/users/conan-io/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/conan-io/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/conan-io/subscriptions",
        "organizations_url": "https://api.github.com/users/conan-io/orgs",
        "repos_url": "https://api.github.com/users/conan-io/repos",
        "events_url": "https://api.github.com/users/conan-io/events{/privacy}",
        "received_events_url": "https://api.github.com/users/conan-io/received_events",
        "type": "Organization",
        "site_admin": false
      },
      "html_url": "https://github.com/conan-io/conan-center-index",
      "description": "Recipes for the ConanCenter repository",
      "fork": false,
      "url": "https://api.github.com/repos/conan-io/conan-center-index",
      "forks_url": "https://api.github.com/repos/conan-io/conan-center-index/forks",
      "keys_url": "https://api.github.com/repos/conan-io/conan-center-index/keys{/key_id}",
      "collaborators_url": "https://api.github.com/repos/conan-io/conan-center-index/collaborators{/collaborator}",
      "teams_url": "https://api.github.com/repos/conan-io/conan-center-index/teams",
      "hooks_url": "https://api.github.com/repos/conan-io/conan-center-index/hooks",
      "issue_events_url": "https://api.github.com/repos/conan-io/conan-center-index/issues/events{/number}",
      "events_url": "https://api.github.com/repos/conan-io/conan-center-index/events",
      "assignees_url": "https://api.github.com/repos/conan-io/conan-center-index/assignees{/user}",
      "branches_url": "https://api.github.com/repos/conan-io/conan-center-index/branches{/branch}",
      "tags_url": "https://api.github.com/repos/conan-io/conan-center-index/tags",
      "blobs_url": "https://api.github.com/repos/conan-io/conan-center-index/git/blobs{/sha}",
      "git_tags_url": "https://api.github.com/repos/conan-io/conan-center-index/git/tags{/sha}",
      "git_refs_url": "https://api.github.com/repos/conan-io/conan-center-index/git/refs{/sha}",
      "trees_url": "https://api.github.com/repos/conan-io/conan-center-index/git/trees{/sha}",
      "statuses_url": "https://api.github.com/repos/conan-io/conan-center-index/statuses/{sha}",
      "languages_url": "https://api.github.com/repos/conan-io/conan-center-index/languages",
      "stargazers_url": "https://api.github.com/repos/conan-io/conan-center-index/stargazers",
      "contributors_url": "https://api.github.com/repos/conan-io/conan-center-index/contributors",
      "subscribers_url": "https://api.github.com/repos/conan-io/conan-center-index/subscribers",
      "subscription_url": "https://api.github.com/repos/conan-io/conan-center-index/subscription",
      "commits_url": "https://api.github.com/repos/conan-io/conan-center-index/commits{/sha}",
      "git_commits_url": "https://api.github.com/repos/conan-io/conan-center-index/git/commits{/sha}",
      "comments_url": "https://api.github.com/repos/conan-io/conan-center-index/comments{/number}",
      "issue_comment_url": "https://api.github.com/repos/conan-io/conan-center-index/issues/comments{/number}",
      "contents_url": "https://api.github.com/repos/conan-io/conan-center-index/contents/{+path}",
      "compare_url": "https://api.github.com/repos/conan-io/conan-center-index/compare/{base}...{head}",
      "merges_url": "https://api.github.com/repos/conan-io/conan-center-index/merges",
      "archive_url": "https://api.github.com/repos/conan-io/conan-center-index/{archive_format}{/ref}",
      "downloads_url": "https://api.github.com/repos/conan-io/conan-center-index/downloads",
      "issues_url": "https://api.github.com/repos/conan-io/conan-center-index/issues{/number}",
      "pulls_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls{/number}",
      "milestones_url": "https://api.github.com/repos/conan-io/conan-center-index/milestones{/number}",
      "notifications_url": "https://api.github.com/repos/conan-io/conan-center-index/notifications{?since,all,participating}",
      "labels_url": "https://api.github.com/repos/conan-io/conan-center-index/labels{/name}",
      "releases_url": "https://api.github.com/repos/conan-io/conan-center-index/releases{/id}",
      "deployments_url": "https://api.github.com/repos/conan-io/conan-center-index/deployments",
      "created_at": "2019-08-27T09:43:58Z",
      "updated_at": "2023-04-04T02:41:04Z",
      "pushed_at": "2023-04-07T03:51:05Z",
      "git_url": "git://github.com/conan-io/conan-center-index.git",
      "ssh_url": "[email protected]:conan-io/conan-center-index.git",
      "clone_url": "https://github.com/conan-io/conan-center-index.git",
      "svn_url": "https://github.com/conan-io/conan-center-index",
      "homepage": "https://conan.io/center",
      "size": 45681,
      "stargazers_count": 722,
      "watchers_count": 722,
      "language": "Python",
      "has_issues": true,
      "has_projects": true,
      "has_downloads": true,
      "has_wiki": true,
      "has_pages": false,
      "has_discussions": true,
      "forks_count": 1271,
      "mirror_url": null,
      "archived": false,
      "disabled": false,
      "open_issues_count": 1557,
      "license": {
        "key": "mit",
        "name": "MIT License",
        "spdx_id": "MIT",
        "url": "https://api.github.com/licenses/mit",
        "node_id": "MDc6TGljZW5zZTEz"
      },
      "allow_forking": true,
      "is_template": false,
      "web_commit_signoff_required": false,
      "topics": [
        "conan",
        "conan-center",
        "conan-index",
        "conan-packages",
        "conan-recipe",
        "cpp",
        "cpp-library",
        "dependencies",
        "hacktoberfest",
        "package-management",
        "package-manager"
      ],
      "visibility": "public",
      "forks": 1271,
      "open_issues": 1557,
      "watchers": 722,
      "default_branch": "master"
    }
  },
  "_links": {
    "self": {
      "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16926"
    },
    "html": {
      "href": "https://github.com/conan-io/conan-center-index/pull/16926"
    },
    "issue": {
      "href": "https://api.github.com/repos/conan-io/conan-center-index/issues/16926"
    },
    "comments": {
      "href": "https://api.github.com/repos/conan-io/conan-center-index/issues/16926/comments"
    },
    "review_comments": {
      "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16926/comments"
    },
    "review_comment": {
      "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/comments{/number}"
    },
    "commits": {
      "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16926/commits"
    },
    "statuses": {
      "href": "https://api.github.com/repos/conan-io/conan-center-index/statuses/78324089bb218ee4bff6a49259f485ed1dc1014a"
    }
  },
  "author_association": "CONTRIBUTOR",
  "auto_merge": null,
  "active_lock_reason": null,
  "merged": false,
  "mergeable": true,
  "rebaseable": true,
  "mergeable_state": "unstable",
  "merged_by": null,
  "comments": 1,
  "review_comments": 0,
  "maintainer_can_modify": true,
  "commits": 1,
  "additions": 1,
  "deletions": 0,
  "changed_files": 1
}

New applet for "interested reviewers" to tag followers of certain recipes

Goal

Alter accounts when a PR is created (to hopefully attract reviewers)

This will circumvent the permissions problem of code owners

Proposal

  • Allow people to open a PR here (maybe CCI) for which recipes they want to be tagged for
  • This will check all recent PRs and tag people on that list for that recipe
  • This bot would also track which PRs it comments on for sanity.

publish to github pages

In addition to putting the information in an issue message, it would be great if the bot put all the markdown content of the issue in index.md file, and then upload it to github page. This way, the information would be available in a more readable way on https://prince-chrismc.github.io/conan-center-index-pending-review.
Once the markdown file is created, it should be as easy as adding this to the workflow: https://github.com/ericLemanissier/conan-center-pr-status/blob/main/.github/workflows/main.yml#L33-L38

Should labels be transparent?

I notice there is a new folder which those PRs are not added to the board https://github.com/conan-io/conan-center-index/commits/master/.c3i. Looking at a few the Conan team is pretty aggressive with reviewing them so it does not seem worth adding.

However labels changing is a fairly common thing, some times the meaning changes... and the only visible impact is the icon thats used to highlight their meaning.

I am not sure it's worth passing them thought or if they need to be processed so the "contextual meaning" can be codified 🤔

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.