resibots/format_code

Clang-format configuration, script and git hook used for our C++ code

format_code's Issues

unrecognized arguments: --need_reformat

Hi all,

I get this when I try to commit to Limbo:

git-clang-format: error: unrecognized arguments: --need_reformat
You need to run 'git clang-format' and stage the files again before commit

On the other hand if I just do git clang-format or clang-format, I get a normal execution:
clang-format did not modify any files.

I recently upgraded to clang 5 and the associated clang-format. Is the --need_reformat option deprecated?

Thanks.

Format of macro classes such as SFERES_FITNESS

I don't like the way the atom clang-format package formats macros such as SFERES_FITNESS.

For example, the following function is formatted in a nicely looking way:

template void eval(const Indiv &ind) {
float v = 0;
std::vector values = {0.2, 0.5, 0.3};

for (size_t i = 0; i < 3; ++i) {
std::cout << "bla ";
}

this->_value = v;
}

..but being inside SFERES_FITNESS the result is the following:

SFERES_FITNESS(SomeFunction, sferes::fit::Fitness){
public : template void eval(const Indiv &ind){float v = 0;
std::vector values = {0.2, 0.5, 0.3};

for (size_t i = 0; i < 3; ++i) {
std::cout << "bla ";
}

this->_value = v;
}
}
;

Do you agree?