Comments (9)
I think the current solution is not ideal for two reason:
- The location of the file is hardcoded, so we need either to use that the manual ( https://icub-tech-iit.github.io/documentation/sw_installation/linux_from_sources_manual/ ) installation used, or the superbuild one ( https://icub-tech-iit.github.io/documentation/sw_installation/linux_from_sources_superbuild/ )
- The file is loaded from the source directory, while typically configuration files are loaded from the installation directory (or the build one if the install is not used)
I think both issues can be avoided if instead of using:
./manageFWrobot.py -n $ROBOT_CODE/robots-configuration/$YARP_ROBOT_NAME/network.$YARP_ROBOT_NAME.xml -f ../info/firmware.info.xml -p all -a info | tee ../logs/log.of.FirmwareUpdater.$YARP_ROBOT_NAME.info.all.txt
we use the yarp resource
utility to find the file, i.e
./manageFWrobot.py -n `yarp resource --from network.$YARP_ROBOT_NAME.xml` -f ../info/firmware.info.xml -p all -a info | tee ../logs/log.of.FirmwareUpdater.$YARP_ROBOT_NAME.info.all.txt
this will work fine both manual and superbuild installation, and will use the installed version of the files instead of the source one (so it will work even if we switch to use binaries in the future).
from icub-firmware-build.
Note that
We usually install
robots-configuration
as part of the superbuild, so our path is$ROBOTOLOGY_SUPERBUILD_DIR/src/robots-configuration
.
Note that since iCubWaterloo01/SN44, the iCubs that come out from the "production" also use the superbuild, so this is a problem that affects also those robots.
from icub-firmware-build.
I just noticed that I should open it in icub-firmware-build.
from icub-firmware-build.
If you tell me what you prefer I can open a PR. Should I close this issue and open a new one in icub-firmware-build?
from icub-firmware-build.
I just noticed that I should open it in icub-firmware-build.
I transferred the issue there.
from icub-firmware-build.
./manageFWrobot.py -n
yarp resource --from network.$YARP_ROBOT_NAME.xml
seems a good solution by me.
from icub-firmware-build.
Given #21, probably we can close this issue @GiulioRomualdi ?
from icub-firmware-build.
Yes!
from icub-firmware-build.
Note that probably yarp resource
now also prints [DEBUG]
messages so it is not suitable anymore to do this, but that is another story.
from icub-firmware-build.
Related Issues (12)
- [iCubParis02] No boards found HOT 2
- Firmware build is missing 2FOC hex file changes HOT 5
- EMS v3.75 FW bugged HOT 3
- Document version of bat corresponding to a given icub-firmware-build release and distro release HOT 4
- Document which variant of bat firmware should be used on ergoCub robot HOT 3
- Branch cleanup december 2023
- Reorganization of EMS folder HOT 4
- proposal for commit log of binary files HOT 3
- New folder for programming of MC4PLUS HOT 5
- Entry point on documentation for updating EMS firmware HOT 6
- devel version of EMS firmware is outated with respect to the master version HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from icub-firmware-build.