ros-gbp/ompl-release

ompl-release's Issues

Make new release of OMPL?

There were recently many improvements to the library (i.e., InformedRRTstar) and it would be great to have these available in ROS.

Would it be possible to do a new release?

Thanks,
Helen

[ROS Buildfarm] "test_random" failed for armhf on ROS Lunar

@mikaelarguedas pointed out ros/rosdistro#14958 (comment)

FYI the newly added test "test_random" hangs on armhf (ran for 7hours before being killed) preventing the job to pass: http://build.ros.org/view/Lbin_uxhf_uXhf/job/Lbin_uxhf_uXhf__ompl__ubuntu_xenial_armhf__binary/3

Looking at the log, I can't find what caused the error, other than where the job timed out without leaving any meaningful message to me.

:
11:49:21  5/18 Test  #5: test_pdf .........................   Passed    2.94 sec
11:49:21       Start  6: test_random
18:57:23 Build timed out (after 600 minutes). Marking the build as failed.
18:57:23 $ ssh-agent -k
18:57:23 unset SSH_AUTH_SOCK;
18:57:23 unset SSH_AGENT_PID;
18:57:23 echo Agent pid 27941 killed;
18:57:23 [ssh-agent] Stopped.
18:57:23 Build was aborted
18:57:23 [description-setter] Could not determine description.
18:57:23 Sending e-mails to: [email protected] [email protected]
18:57:24 Warning: you have no plugins providing access control for builds, so falling back to legacy behavior of permitting any downstream builds to be triggered
18:57:24 Finished: FAILURE

Btw repositories.ros.org shows ompl for all platform seems to be built? Oh just found in uxhf page ompl indeed is failing. I'll look into a log but if someone else can also do so that'd be appreciated.

Release into ROS Melodic

MoveIt! is preparing to be released into the upcoming LTS (long term support) version of ROS M ros-planning/moveit#806, and would like OMPL to be released as MoveIt! depends on it.

If anything regarding ROS release I and others will be happy to provide assistance.

Thank you in advance.

Release OMPL For Eloquent and Foxy

Hi,

Can we get this released for Eloquent and Foxy? It's blocking some releases.

No package.xml in released ros-kinetic-ompl

Apologies if this is not the correct place for this.

When trying to check the dependencies of a custom package I found that this package doesn't appear to be correctly configured for ROS kinetic because it doesn't contain a package.xml in /opt/ros/kinetic/ompl

Although not a show-stopper it causes some weirdness in various ROS tools.

Some useful information:

# This package was originally installed on my system via rosdep
$ rosdep install -s --reinstall moveit_planners_ompl
#[apt] Installation commands:
  sudo -H apt-get install ros-kinetic-dynamic-reconfigure
  sudo -H apt-get install ros-kinetic-moveit-core
  sudo -H apt-get install ros-kinetic-catkin
  sudo -H apt-get install ros-kinetic-roscpp
  sudo -H apt-get install ros-kinetic-moveit-resources
  sudo -H apt-get install ros-kinetic-pluginlib
  sudo -H apt-get install ros-kinetic-eigen-conversions
  sudo -H apt-get install ros-kinetic-moveit-ros-planning
  sudo -H apt-get install ros-kinetic-tf
  sudo -H apt-get install ros-kinetic-ompl

# But rospack can't actually find this package
$ rospack depends moveit_planners_ompl
[rospack] Error: package 'moveit_planners_ompl' depends on non-existent package 'ompl' and rosdep claims that it is not a system dependency. Check the ROS_PACKAGE_PATH or try calling 'rosdep update'

# Rosdep has correctly installed rospack and can resolve its install task
$ rosdep resolve ompl
#apt
ros-kinetic-ompl

# ros-kinetic-ompl is correctly installed on my system
$ dpkg-query --show ros-kinetic-ompl
ros-kinetic-ompl        1.2.1-1xenial-20161119-235543-0800

# But the package.xml is not, meaning it is incorrectly configured.
$ dpkg-query --listfiles ros-kinetic-ompl | grep package.xml
# no output from this command = no package.xml installed

Cheers.

Clarify release steps

Cont'd from https://bitbucket.org/ompl/ompl/issues/318/release-into-ros-lunar, I ran bloom for ompl for ROS Lunar but stuck and now I'm not sure how to proceed. I'm not so familiar with 3rd party release, so don't even know what's required is a standard 3rd party stuff or it's ompl-ros custom setting. If @isucan, @vrabaud or else could shed some lights that'll be great.

$ bloom-release --rosdistro lunar --track lunar ompl
ROS Distro index file associate with commit '6947a525b82bffc8b8d4b52ce26bfbe80b9459df'
New ROS Distro index url: 'https://raw.githubusercontent.com/ros/rosdistro/6947a525b82bffc8b8d4b52ce26bfbe80b9459df/index.yaml'
Specified repository 'ompl' is not in the distribution file located at 'https://raw.githubusercontent.com/ros/rosdistro/6947a525b82bffc8b8d4b52ce26bfbe80b9459df/lunar/distribution.yaml'
Could not determine release repository url for repository 'ompl' of distro 'lunar'
You can continue the release process by manually specifying the location of the RELEASE repository.
To be clear this is the url of the RELEASE repository not the upstream repository.
For release repositories on GitHub, you should provide the `https://` url which should end in `.git`.
Here is the url for a typical release repository on GitHub: https://github.com/ros-gbp/rviz-release.git
==> Looking for a release of this repository in a different distribution...
A previous distribution, 'kinetic', released this repository.
Release repository url [https://github.com/ros-gbp/ompl-release.git]:
==> Fetching 'ompl' repository from 'https://github.com/ros-gbp/ompl-release.git'
Cloning into '/tmp/tmphoCv_5'...
remote: Counting objects: 5180, done.
remote: Total 5180 (delta 0), reused 0 (delta 0), pack-reused 5180
Receiving objects: 100% (5180/5180), 18.27 MiB | 162.00 KiB/s, done.
Resolving deltas: 100% (2486/2486), done.
Checking connectivity... done.
Given track 'lunar' does not exist in release repository.
Available tracks: ['groovy', 'jade', 'indigo', 'kinetic', 'hydro']
Create a new track called 'lunar' now [Y/n]?
Creating track 'lunar'...
Repository Name:
  upstream
    Default value, leave this as upstream if you are unsure
  <name>
    Name of the repository (used in the archive name)
  ['upstream']:
Upstream Repository URI:
  <uri>
    Any valid URI. This variable can be templated, for example an svn url
    can be templated as such: "https://svn.foo.com/foo/tags/foo-:{version}"
    where the :{version} token will be replaced with the version for this release.
  ['https://bitbucket.org/ompl/ompl']:
Upstream VCS Type:
  svn
    Upstream URI is a svn repository
  git
    Upstream URI is a git repository
  hg
    Upstream URI is a hg repository
  tar
    Upstream URI is a tarball
  ['hg']:
Version:
  :{ask}
    This means that the user will be prompted for the version each release.
    This also means that the upstream devel will be ignored.
  :{auto}
    This means the version will be guessed from the devel branch.
    This means that the devel branch must be set, the devel branch must exist,
    and there must be a valid package.xml in the upstream devel branch.
  <version>
    This will be the version used.
    It must be updated for each new upstream version.
  [':{ask}']:
Release Tag:
  :{none}
    For svn and tar only you can set the release tag to :{none}, so that
    it is ignored.  For svn this means no revision number is used.
  :{ask}
    This means the user will be prompted for the release tag on each release.
  :{version}
    This means that the release tag will match the :{version} tag.
    This can be further templated, for example: "foo-:{version}" or "v:{version}"

    This can describe any vcs reference. For git that means {tag, branch, hash},
    for hg that means {tag, branch, hash}, for svn that means a revision number.
    For tar this value doubles as the sub directory (if the repository is
    in foo/ of the tar ball, putting foo here will cause the contents of
    foo/ to be imported to upstream instead of foo itself).
  [':{ask}']:
Upstream Devel Branch:
  <vcs reference>
    Branch in upstream repository on which to search for the version.
    This is used only when version is set to ':{auto}'.
  [None]:
ROS Distro:
  <ROS distro>
    This can be any valid ROS distro, e.g. hydro, indigo, jade
  ['lunar']:
Patches Directory:
  :{none}
    Use this if you want to disable overlaying of files.
  <path in bloom branch>
    This can be any valid relative path in the bloom branch. The contents
    of this folder will be overlaid onto the upstream branch after each
    import-upstream.  Additionally, any package.xml files found in the
    overlay will have the :{version} string replaced with the current
    version being released.
  ['kinetic']: lunar
Release Repository Push URL:
  :{none}
    This indicates that the default release url should be used.
  <url>
    (optional) Used when pushing to remote release repositories. This is only
    needed when the release uri which is in the rosdistro file is not writable.
    This is useful, for example, when a releaser would like to use a ssh url
    to push rather than a https:// url.
  [None]:
Created 'lunar' track.

You are creating a new track, this often means you are releasing for a new distribution.
bloom has detected some patches and/or ignored packages from previous release tracks.
You may wish to migrate patches or duplicate the ignored files from previous releases.
These patches and ignored files are NOT migrated to the new track automatically.

Potential items to address:
- There are patches on the branch 'patches/release/groovy/ompl'.
- There are patches on the branch 'patches/release/hydro/ompl'.
- There are patches on the branch 'patches/release/indigo/ompl'.
- There are patches on the branch 'patches/release/jade/ompl'.
- There are patches on the branch 'patches/release/kinetic/ompl'.

The release repository is located at '/tmp/tmphoCv_5'
You can modify it in a different shell and continue when finished.

OMPLapp

Hi, I wonder what is the reason not to have an OMPLapp ROS release. I guess the reason is that OMPLapp is just for developing and testing but, at least in my particular case, it would save some work if I could just install the package with rosdep.

latest lunar release breaks MoveIt

@mamoll
With the latest release of ompl into lunar, MoveIt doesn't find ompl-config.cmake anymore. This is probably due to the fact that the installation folder for cmake files has changed:

# find /opt/ros -iname "*ompl*"
...
/opt/ros/lunar/lib/x86_64-linux-gnu/libompl.so.1.3.2
/opt/ros/lunar/lib/x86_64-linux-gnu/cmake/ompl/omplConfigVersion.cmake
/opt/ros/lunar/lib/x86_64-linux-gnu/cmake/ompl/omplConfig.cmake
...

while before we had:

# find /opt/ros -iname "*ompl*"
...
/opt/ros/lunar/lib/x86_64-linux-gnu/libompl.so.1.3.1
/opt/ros/lunar/share/ompl/ompl-config.cmake
...

On Melodic, also omplConfig.cmake is installed, but directly in /opt/ros/*/lib/cmake:

# find /opt/ros -iname "*ompl*"
...
/opt/ros/melodic/lib/libompl.so.1.4.0beta
/opt/ros/melodic/lib/cmake/ompl/omplConfigVersion.cmake
/opt/ros/melodic/lib/cmake/ompl/omplConfig.cmake
...

ompl-config.cmake in wrong location?

I have installed ros-kinetic-ompl in Ubuntu 16.04. I am perhaps missing something, but the ompl-config.cmake file is installed under /opt/ros/kinetic/share/ompl/ but catkinConfig.cmake looks for it under the subfolder cmake. Therefore I get the error:

CMake Warning at /opt/ros/indigo/share/catkin/cmake/catkinConfig.cmake:76 (find_package):
  Could not find a package configuration file provided by "ompl" with any of
  the following names:

    omplConfig.cmake
    ompl-config.cmake

  Add the installation prefix of "ompl" to CMAKE_PREFIX_PATH or set
  "ompl_DIR" to a directory containing one of the above files.  If "ompl"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  CMakeLists.txt:10 (find_package)

I wonder why is it this way, and what is a better solution. I didn't find a workaround yet, as doing a symlink shows:

Make Error at /opt/ros/indigo/share/catkin/cmake/catkin_package.cmake:178 (message):
  catkin_package() CATKIN_DEPENDS on 'ompl', which has been found in
  '/opt/ros/indigo/share/ompl/cmake/ompl-config.cmake', but it is not a
  catkin package
Call Stack (most recent call first):
  /opt/ros/indigo/share/catkin/cmake/catkin_package.cmake:100 (_catkin_package)
  CMakeLists.txt:16 (catkin_package)

Thanks!

Saucy i386 keeps timing out

http://jenkins.ros.org/view/IbinS32/job/ros-indigo-ompl_binarydeb_saucy_i386/ keeps timing out after two hours (which is the hard limit for binarydeb jobs).

It seems like test 13 (test_2denvs_geometric) is hanging.

Plan to follow the version conventions?

I have a lot of below warnings raised by catkin_pkg https://github.com/ros-infrastructure/catkin_pkg/blob/master/src/catkin_pkg/package.py#L188.

WARNING: Package "ompl" does not follow the version conventions. It should not contain leading zeros (unless the number is 0).

Do you have plan to follow the version conventions?
I'm glad if there are few warnings.

package doesn't install package.xml

While the release repo adds a package.xml file it doesn't install it at all. It must be installed into <prefix>/share/ompl/ in order for the package to be discoverable by other ROS tools. E.g. see ros/rospack#111.

It seems the same problem has been reported in the past for Kinetic: #9.

@mamoll Please add the necessary install rules and release new deb incs into all active ROS distributions which currently don't have it.