sk1erllc/patcher

A Forge mod full of Vanilla bug fixes, Quality of Life improvements, and performance enhancements.

patcher's Issues

Optimized Font Renderer causes underlines to not render

Essential's TOS screen is the example being used here

Without:

With:

Add Unfocused FPS support when out of a world

as title said, add unfocused fps for all the game, like main menu and server list and select world menu
not quite sure if its already there but when im not in a world and unfocused my gpu usage is just really high

Issues with End Biome

Specifically in skyblock, patcher causes the end biome to not render the sky as black, but rather as white.
Without Patcher:

With Patcher:

How to reproduce the issue:

1. Install Patcher
2. Join Skyblock
3. Use an End Biome Stick to set part of your island to the end
4. Swap worlds so the biome updates
5. Look at the sky

Name History command should have autocompletion for players in the world

HUD Caching causes depth issues in the inventory

Upload to CurseForge.

AZERTY layout is still incomplete

Hi, I've tried the AZERTY layout fix option and I only found one thing that is still not working.
Right now, it only fixes when you try to use your hotbar key when inside an inventory but it doesn't fix the bug that occurs when you are sneaking (SHIFT) and trying to use these keys.

• Indeed when no other keys are pressed, the 9 hotbar keys are
  & é " ' ( - è _ ç
• When pressing SHIFT
  1 2 3 4 5 6 7 8 9

[Suggestion] Auto Copy S.S link to ClipBoard

Have a switch in [/patcher] or another option next to [Upload] when using ScreenShot Manager that will automatically copy the uploaded image link to your clipboard.

Taking a screenshot sometimes gives you a NPE

No real way to reproduce the issue outside of taking a bunch of screenshots until it happens.

[19:02:19] [Essential 13/ERROR]: Failed to capture screenshot.
java.lang.NullPointerException
    at net.minecraft.client.gui.GuiNewChat.func_146242_c(SourceFile:254) ~[avt.class:?]
    at net.minecraft.client.gui.GuiNewChat.func_146237_a(SourceFile:135) ~[avt.class:?]
    at net.minecraft.client.gui.GuiNewChat.func_146234_a(SourceFile:129) ~[avt.class:?]
    at club.sk1er.patcher.util.screenshot.AsyncScreenshots.sendChatMessages(AsyncScreenshots.java:161) ~[AsyncScreenshots.class:?]
    at club.sk1er.patcher.util.screenshot.AsyncScreenshots.run(AsyncScreenshots.java:82) [AsyncScreenshots.class:?]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_333]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_333]
    at java.lang.Thread.run(Thread.java:750) [?:1.8.0_333]
    ```

Allow changing Inventory Scale from GUI

Titles not appearing

I noticed that with the patcher mod active, no titles were showing up from other mods that sent them. I tried to check if the "Disable Titles" option was enabled but it was not. I tried whatever I could and to assure it, I removed the mod from my folder and the titles began to send again

can add version of patcher without essential ?

can add version of patcher without essential ? or uploud old version not use essential

Unable to start with OpenJ9

Unable to start with OpenJ9

Sky does not turn darker when it rains

Patcher causes the sky does not turn darker when the weather is rain or thunderstorm, no matter which world is active (e.g. singleplayer, Skyblock).
This bug may share the same culprit with issue #56, where End biome doesn't turn the sky to black.

Steps to reproduce:

1. Install Patcher
2. Open a world or join Skyblock
3. Make it rain (on Skyblock, use a Weather Stick or Weather Node, alternatively buy rain from Vanessa in Birch Park)
4. Look at the sky

With Patcher

Without Patcher

NPC nametags flicker with HUD Caching enabled

Enabling HUD Caching makes NPC nametags on Hypixel somewhat flicker

Enabling the optimized font renderer changes the effect while enabling "cache font data" stops the issue from occurring.

Example:
https://user-images.githubusercontent.com/29981918/169665573-8bc50dc3-211f-44e4-9ebf-ee6fe03ffbcb.mp4

Hand floats away when item is held on a superflat world while also having haste 7

How to reproduce:

• apply the config below
• go into a superflat world
• give yourself haste 7
• hold an item
• weeeeee

Config file patcher_funny_hand_config.txt

Screencast.from.12.mai.2022.kl.21.31.+0200.trimmed.mp4

Fix spectator mode particle rendering

Particles are rendered incorrectly when you are in spectator mode and spectating another player in the first person view. They're rendered using the position/facing angle of the spot where you enter first person view, rather than where they actually are while spectating, which causes the particles to render incorrectly when the player moves around.

Video showing the issue here

edit: just wanted to clarify that this a suggestion for a vanilla bug to fix, not a bug that is caused by patcher.

Fix forge bug that makes panes connected when they should not be

Presumably caused by
https://github.com/MinecraftForge/MinecraftForge/blob/1.8.9/patches/minecraft/net/minecraft/block/BlockPane.java.patch
MinecraftForge/MinecraftForge@ebd22c3

Forge

Vanilla

[Suggestion] Add feature for "/block" in hypixel

Please add a very simple toggle where when you type "/block " it runs "/ignore add "

White Screens appear when launching with macOS on Big Sur

This issue is not reproducible on earlier versions of MacOS and has been (confirmed) an issue since patcher 1.5.1. The issue happens on both M1 macs and Intel macs.

Some users has reported that the issue is temporarily solved if Essential downloads before the game launches.

Fullbright conflicts with Light Overlays & Minimap mods

Link to the mod: https://github.com/feldim2425/MoreOverlays/tree/master

When More Overlays is loaded standalone, it works flawlessly. As soon as I add Patcher, it does not work anymore.
I don't really have a guess what could cause the incompatibility. More Overlays is e.g. supposed to render a light level overlay (like NEI once did) if F7 had been pressed before (changable via Options; have also tried binding this to a different key without avail).

Only tested this on 1.8.9 with latest Forge, so I don't know about 1.12.2.

Replace ScreenHistory's UIPlayer with Essential's player builder

Essential's player builder can be accessed by EssentialAPI.getEssentialComponentFactory().buildEmulatedPlayer {}

Maximum entity render distance is 64

It'd be nice if max entity render distance was increased from 64 to something like 256.
Or perhaps changed to use a % of the vanilla entity render distance, from 10% to 500% like how sodium does.

This would be useful for extending the vanilla entity render distance past what is normally achievable. I find the render distance of 64 to be quite limiting for various game modes such as bedwars on hypixel where you want to know if an enemy player is coming from a long distance away.

Relevant line(s):
https://github.com/Sk1erLLC/Patcher/blob/master/src/main/java/club/sk1er/patcher/config/PatcherConfig.java#L696-L728

I'll pr this when I get to my pc later, if you haven't already done it by then.

[1.12.2] Fullbright breaks mob spawning

Audio Fix and Hotbar Fix for 1.8.9

1: In version 1.8.9 (i think 1.12.2 as well) there is a bug with the audio where if any noise is playing in your left or right ear, going in f5 wouldnt flip the audio.

Bug 2: In all versions of Minecraft, the hotbar would sometimes be cutoff by one or 2 pixels for some texture packs, raising the hotbar by 1 or 2 pixels would solve this issue somehow. (if you didnt notice it before now you cant unsee it, sorry lol)

End of message, sincerely, mqtrx

Add slider for chatHeightFocused

Add a slider in the ESC -> option -> chat settings menu to change the field chatHeightFocused that otherwise can only be changed by editing manually the option.txt

Chat Timestamp Style "Message Hover" doesn't apply to entire message, only the last empty sibling

Associating inventory keybind with mouse button doesn't let you close inventory with that button

This is a vanilla bug that should be fixed, if possible. Not sure where the issue lies atm

Optimized font renderer w/ OptiFine installed changes bold text width

Patcher Resource Pack Bug

So i use patcher lots and everytime i use it texture packs dont work

Title Improvements

1. Allow changing the opacity of titles
2. Automatically scale-down titles if they're too big for the screen so they'll no longer appear off-screen

Name history broken with essential 1.0

Associating perspective keybind with a mouse button doesn't activate perspective until another key is pressed

This is a vanilla bug that should be fixed, if possible. Not sure where the issue lies atm

Nickhider string width not respected by optimized font renderer

With optimized font renderer

Without

Patcher x macOS: preventing "CTRL + LClick = RClick" accidents, treat both inputs as independent inputs

Self explanatory. In macOS, CTRL + LClick is treated as a single RClick input, which in Minecraft effectively prevents people from sprinting and performing melee attacks simultaneously.

If Patcher sees it's being loaded within macOS, Patcher should treat inputs from both sources as independent inputs with no config option to toggle it off via the /patcher command, much like the CTM fix contributed by Wyvest a while back.

While SimpleToggleSprint exists as an indirect workaround, it would be nice for Patcher to intervene in incredibly rare edge cases of both inputs being active at once (ie: user simply forgot they had togglesprint active, household member misinput, etc).

There's already a mod which does this: https://github.com/MinecraftMachina/McMouser but it is far too obscure for anyone to pay attention to it. Seeing as Patcher intends to aim for fixing MC bugs while also providing QoL (even if it exists in other mods), I figured this would be a feature worth adding even if McMouser exists.

Stop rendering particles too close to you for a clear view

Some minigames spawn a lot of particles and some of those particles may end up spawning really close to you in your field of view thus greatly reducing visibility.

Would it be possible to implement some kind of "culling" that stops those particles from spawning ?
Or would that be too performance hungry since a lot of particles can spawn per second

Crash at end of game launch due to resource pack and font renderer incompatibility.

Hello,

I launched Minecraft just like normal today, and everything loaded up fine. I joined Hypixel and was about to start a game, but I decided to switch resource packs. I tabbed out while it loaded, but realized that my Minecraft had crashed. I initially thought it was because I tabbed out and something broke, but that was not the issue. After multiple attempts to relaunch the game, it continued to crash after the 7/7 loading progress during Forge startup. Basically, it would crash as soon as it attempted to render the main screen.

After reading through the crash log, it seems like there's an issue with the optimized font renderer and the font used by the John Smith Legacy resource pack that I attempted to load. To be sure that it was Patcher, I removed the mod, launched Forge normally with no issues, switched packs, then put Patcher back into my mods folder and relaunched successfully. I am providing all of the potentially relevant information below for debugging. Let me know if anything else is needed, or if I am just wrong and there is another issue.

Information

Version: 1.8.9 (Forge - Version: 1.8.9.11.15.1.2318)
Other Mods (Should Be Irrelevant):

Resource Pack: John Smith Legacy 1.8.9 v1.3.3
John Smith Legacy 1.8.9 v1.3.33.zip
(Looking at it now, the pack seems to handle some things in a bit of an odd way. Not sure if this would make the pack completely incompatible given the way that Patcher handles the fonts, but I don't know.)

Additional details:

• Running Windows 10, NVIDIA graphics card on next-to-latest drivers.
• Launching with fullscreen mode enabled or disabled did not change anything; the crash log below was taken while it was disabled.
• Sk1er mods are fully up-to-date, as well as the Minecraft launcher and Forge.
• The issue only presented itself when this specific resource pack had been selected, as specified in the summary above.

Simplified Crash Log:

WARNING: coremods are present:
  OptifinePatcherTweaker (Sk1er_Old_Animations-1.0_-_beta_7.jar)
  ModTweaker (Patcher-1.7.0 (1.8.9).jar)
  FMLLoadingPlugin (Skypixel-0.0.6.jar)
  FMLLoadingPlugin (Sk1er_Old_Animations-1.0_-_beta_7.jar)
  PatcherTweaker (Patcher-1.7.0 (1.8.9).jar)

Time: 11/23/21 1:26 AM
Description: Rendering screen

java.lang.IllegalArgumentException: Dimensions (width=65536 height=69632) are too large
	at java.awt.image.SampleModel.<init>(SampleModel.java:130)
	at java.awt.image.SinglePixelPackedSampleModel.<init>(SinglePixelPackedSampleModel.java:144)
	at java.awt.image.Raster.createPackedRaster(Raster.java:773)
	at java.awt.image.Raster.createPackedRaster(Raster.java:475)
	at java.awt.image.DirectColorModel.createCompatibleWritableRaster(DirectColorModel.java:1032)
	at java.awt.image.BufferedImage.<init>(BufferedImage.java:340)
	at club.sk1er.patcher.hooks.FontRendererHook.create(FontRendererHook.java:83)
	at club.sk1er.patcher.hooks.FontRendererHook.renderStringAtPos(FontRendererHook.java:132)
	at net.minecraft.client.gui.FontRenderer.handler$patcher$useOptimizedRendering$zjm000(FontRenderer.java:2745)
	at net.minecraft.client.gui.FontRenderer.func_78255_a(FontRenderer.java)
	at net.minecraft.client.gui.FontRenderer.func_180455_b(FontRenderer.java:702)
	at net.minecraft.client.gui.FontRenderer.func_175065_a(FontRenderer.java:427)
	at net.minecraft.client.gui.FontRenderer.func_175063_a(FontRenderer.java:394)
	at net.minecraft.client.gui.Gui.func_73732_a(SourceFile:99)
	at net.minecraft.client.gui.GuiMainMenu.func_73863_a(GuiMainMenu.java:632)
	at net.minecraftforge.client.ForgeHooksClient.drawScreen(ForgeHooksClient.java:311)
	at net.minecraft.client.renderer.EntityRenderer.func_181560_a(EntityRenderer.java:1436)
	at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1051)
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:349)
	at net.minecraft.client.main.Main.main(SourceFile:124)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

-- Screen render details --
Details:
	Screen name: net.minecraft.client.gui.GuiMainMenu
	Mouse location: Scaled: (0, 239). Absolute: (0, 0)
	Screen size: Scaled: (427, 240). Absolute: (854, 480). Scale factor of 2
Stacktrace:
	at net.minecraft.client.renderer.EntityRenderer.func_181560_a(EntityRenderer.java:1436)
	at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1051)
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:349)
	at net.minecraft.client.main.Main.main(SourceFile:124)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

Appreciate the hard work and again let me know if I can be of any more help with this issue. Thank you.

Healthbars not showing.

On Hypixel Skyblock, where usually the health of mobs/minion full text would show through walls, it no longer does after intalling patcher

New option to draw the chat background when the chat is open

It is nice to have transparent chat when playing to be able to better focus on the gameplay without have a black box on the screen whenever there is a chat message. However the chat is easier to read when there is the black box background.

I suggest adding a setting that would be : transparent chat only when chat is closed.

Font breaks with unicode characters when optimized font renderer is enabled

Can recreate the issue on 1.8.9 on hypixel housing.

See the "Give cookies" and "Have fun" message specifically.

optimized font renderer enabled:

optimized font renderer disabled:

Lighting doesn't work properly at y256

Reproduction steps:

1. Join a world
2. Go to y256
3. Run /setblock ~ ~ ~ stone
4. Set time to night using /time set 18000

NameHistory screen doesn't show usernames until window is rescaled

A non-functional server list button is shown in replaymod replay viewer

How to reproduce the issue:

• Set "Open to LAN replacement" to "Server List"
• Open replay from replaymod
• Press ESC and try to press the server list button

Lockups during world switching when Render Regions disabled

This has been an issue I've been experiencing for awhile and it's taken me some time to narrow it down enough to make some sort of tangible report on it.

As a point of reference, I'm using Fedora 35 and run Minecraft using Java 8u312 available in its repos. I have done most of my testing related to this bug while only using Patcher and OptiFine as enabled mods, using the latest possible version of Forge for 1.8.9 and 1.12.2. I've previously tested for this bug using other distributions of Java (Azul Zulu JDK 8, BellSoft Liberica JDK 8) and did not have a different experience. I use a locally built copy of Patcher typically, but I've experienced this bug using the release distributed on sk1er.club.

Without OptiFine's Render Regions option enabled, it is virtually guaranteed that I experience ~10 second lockups when switching between servers after doing so at least once beforehand. This happens when switching between servers on larger network servers such as Hypixel, as well as between separate servers from the server list. I initially tied this to the font rendering optimisations, but I experience the issue with them disabled. I also thought that the optimised cloud rendering may be playing a part but that also does not seem to be the case as it also happens with that setting, or both that setting and the aforementioned font rendering opitmisations, disabled.

I typically try to leave Render Regions disabled as I tend to experience worse performance in a lot of situations using them. Nothing within my game logs points to anything about this unfortunately, but I can upload a log for each 1.8.9 and 1.12.2 if desired, I may be missing something.

This is not an issue I've encountered on 1.8.9 with OptiFine and Forge only. Disabling Patcher's fast world swapping error only results in it happening consistently even from game start, albeit with more even and consistently lower lockup times. I'd hoped to provide more info on this but I'm not quite knowledge enough on what's actually happening with Render Regions enabled and with what Patcher does that would be relevant to this issue, to narrow it down further.

Erratic Mouse Movement with High Hertz

So i've been headlessly looking around but with no luck for a mod that fix the following:

In 17w43a the LWJGL library got updated to version 3.X.X... a long side some other stuff which fixed a bug that made any Gaming mouse that have a setable pulling rate higher than 125hz behave like crazy in minecraft version prior to 1.13.

It so happen AntVenom suffered from it lol : https://www.youtube.com/watch?v=5v4zMOQ-sSU

So i was wondering if there's any chance Patcher could get this fix for 1.8.9

Entity culling removes mob inside spawner

Optimized Font Renderer causes bold text with a custom font to have wider string width than usual

HUD Caching & OptiFine shaders causes the screen to become black when the player has blindness

Should attempt to call GlStateManager.setFog() before & after rendering, see if that remedies the issue

Some resourcepacks doesn't show up in the resoucepack menu

Seems to be isolated to the description in the pack.mcmeta file. Removing the description makes the pack show up.

Link to resoucepack: https://drive.google.com/file/d/15yz15REL-Hv72s53aCMco-8CpwJLCUop/view

Name History Popup names can be too long for the container

Original concept should be followed better aswell, head is way too big (by Cubxity, use default Minecraft font)