team-eternity/eternity

The Eternity Engine

eternity's Issues

Sliding along walls is not portal aware

There are some functions in P_SlideMove that don't consider the existence of portals

Reported bug: Dehacked bug

https://www.doomworld.com/vb/eternity/86586-dehacked-bug/

Line portal teleportation is way off when thing touches two such lines at once

I guess it's my missile clipping fix that broke it, so let's see. Usually the thing gets sent into the void.

Implement attached polyobjects

Add GOG.com install paths to d_findiwads.cpp

For reference, feel free to use my code for ZDoom as it should contain all the paths and key names you might need.

Fix line portal HOM when the sector behind is of the same light level

This is an old bug that had better be fixed, since it's very easy for a new mapper to bump into it, and not know how to get rid of it other than asking.

Fix line portal wrong line rejection

Some lines are misdetected as being parasitic in front of line portals, and that needs to be fixed.

Fix parasitic sky-hack vertical planes

https://www.doomworld.com/vb/eternity/85686-sky-transfer-bug/

Fix the rendering bugs in https://www.doomworld.com/vb/post/1551799

CMake: Eternity won't compile on OS X Yosemite due to CMake bug

The bug is in CMake itself, as referenced in the generated CMakeCXXCompiler.cmake:

set(CMAKE_CXX_SOURCE_FILE_EXTENSIONS C;M;c++;cc;cpp;cxx;m;mm;CPP)

Due to the m file extension. This is an ObjC file extension, not a C++ extension!
This should be

set(CMAKE_CXX_SOURCE_FILE_EXTENSIONS C;M;c++;cc;cpp;cxx;mm;CPP)

And Eternity will compile as normal.

Demo desync: requiem.wad, Revved at http://doomedsda.us/wad765m243.html

It desyncs in the second level (22) when it's supposed to go berserk against arachnotrons but instead it dies. Old versions as back as Phoenix would desync worse. Older ports such as MBF would fare even worse. PrBoom+ 2.5.1.4 works.

Implement angled anchor and linked portals

Node lumps starting with "XNOD" are assumed as ZDBSP lumps despite being vanilla lumps

This means that any first node that starts partitioning at (20056, 17487) will trigger this.

ZDoom solves this problem by first checking for vanilla nodes, and if that fails, try ZDBSP nodes.

The definition at http://zdoom.org/wiki/Node is that SEGS is left empty, and in this case SSECTORS too.

Offending PWAD here (for Doom 2). Be careful launching it; make sure you don't have unsaved data (Eternity may attempt to allocate huge memory): https://dl.dropboxusercontent.com/u/5103936/forum-posts/bspfail.wad

UDMF branch: throw error if required fields are omitted

For now it just assigns some assumed defaults like 0 or -1 to fields such as vertex coordinates or front sidedef index, which is non-compliant. It should exit to the console with an error instead.

trace.attackrange is changed in non-gameplay situations

This is a problem because P_SpawnPuff uses it for deciding whether it spawns, and it's already affected by the player punch. The non-gameplay situations (crosshair and chasecam at least) also change it, resulting in unintended game-changing behaviour that's also demo-breaking.

https://www.doomworld.com/vb/doom-general/85306-the-fist-affects-how-the-revenant-missile-trails-look-like/

Not loading PWADs GFX in GUI

Eternity does not seem to be loading some of GFX when loading a PWAD from the in-game menu. e.g. Hell Revealed 2's green arrow (on menu). the traditional doom2's skull is shown instead.

the green arrow appear when using -file parameter.

[portal branch] Fix rendering glitches near cyclic line portals

The "cyclic" line portals (in maps where link offsets no longer agree because of "infinite" portal design) have visual glitches with non-drawing segs, because it is assumed the portal line is correct. Need to address this, either by making an exception for cyclic line portals, or handling these specially.

Post-teleport stun does not affect vertical looking

Despite the player being expressly forbidden from turning or moving for a brief moment after teleportation, vertical looking does not seem to be hindered. For consistency it might be a good idea to disable it along with everything else.

(zdoom-hexen-specials) Unify the EV_ procedures

There are similar/duplicate actions between EV_DoStuff and EV_DoParamStuff. EV_DoStuff should really flow into EV_DoParamStuff which will be the only one setting up the thinker or other map action. After that, try to remove the redundant kinds and types of input parameters and thinkers. This will make a Doom->UDMF conversion clearer.

This goes without saying: demo regression testing is most important here.

Savegame desync with polyobjects and ACS

https://www.doomworld.com/vb/post/1570149

Light diminishing isn't "flat" enough

It seems like many ports have this problem, even ZDoom did for a while. In Vanilla Doom, smaller screen sizes caused there to be too much contrast introduced in the lighting, and Eternity reflects this "brighter" behavior instead of how the lighting was meant to look.

(zdoom-hexen-specials) Add ZDoom-compatible crusher specials to Eternity

Finish them. Make sure both Hexen and Doom crushers are supported. Confine the quirky Hexen behaviour to vanilla Hexen.

Gib health doesn't change after dehacked alteration

I've noticed a bug where monsters in Eternity, after a Dehacked modification of their hit points, retain their old gib health. For example sergeants with the following modification:

thing 3 (sergeant)
hit points = 240

can still be gibbed with the berserk pack in Eternity (as long as their health is below -30) but not in MBF or vanilla Doom.

(crossposted from Doomworld Eternity forum)

Make sector groups connected only to moving groups move with them

As long as they're not connected to static groups, they'll have to be moved along with the master polyobject-connected group. Necessary for some multi-story polyobject cars.

Interpolation can cause voodoo dolls to flicker/spaz out

Used Mock2 Map30 start room. Activate god mode and mdkbomb a few times. Enjoy the caffeine-riddled voodoo dolls.

These are not before and after, it's me sitting still.

Reported bug: EE crashing at low vertical resolutions

https://www.doomworld.com/vb/eternity/86545-anything-between-200-and-240-lines-crashes/

Bug with slopes and sky hacks

https://www.dropbox.com/s/6ij8jk0nor0m5e3/etrn37.png?dl=0

It seems that if a ceiling sky hack is done on a sector with sloped floor, a black wireframe will appear just below the sky edge.

Fix bugs in https://www.doomworld.com/vb/eternity/85351-bug-showcase-level/

Some of them crash the program.

Horizontal and vertical mouse sensitivity extremely inconsistent

Vertical mouse movement seems to be a lot more sensitive than horizontal mouse movement. It'd be nice if the having the same sensitivity value on both axes caused them to move the same number of degrees (taking aspect ratio correction into account, of course).

As it is right now, I have to have my horizontal sensitivity a lot higher than the vertical setting just to get it to feel roughly consistent.

Bad things can happen if the sector behind a line portal is of lower height than the one before

The player can get stuck irremediably

Simplify UDMF map reading

According to last discussions:

• UDMF maps shouldn't look to Doom as specially UDMF after level setup has finished. Remove all checks of a UDMF format map during the game. Map should just be considered as Doom, Hexen or something else based on namespace.
• Do not do anything more than mapping id/arg0..4 to tag/args[0..4]. No complicated processing if id/tag data. It's up to the parameterized specials to interpret that correctly

Reported issue loading Hellbound MAP29

https://www.doomworld.com/vb/post/1553559

This hasn't been checked if it's really a bug, but has been logged here so it can be tested later.

Demo desync

I've noticed that the following Compet-N demo breaks (player dies in E1M7):

http://www.doom.com.hr/index.php?page=download&cndb=&record_id=2326

It has been happening since the commit in August 2013: 8bfdf54

Player watching cameras not portal aware

Neither the "chasecam" nor the "walkcam" are aware of linked portals, looking bad in maps with such.

Restore pre-SMMU colourmapped deep water or high sky sectors

SMMU changed it to ZDoom-like coloured sector effects, and I suspect it was wrong to do so, so I'll try restoring the old behaviour

Polyobjects may flicker depending on where you look at them from

There seems to be a very serious problem in Eternity with polyobjects, where they start flickering arbitrarily if you look at them from the wrong positions. It doesn't seem to be easily controlled and contained by the map author.

Implement slope collision

This is somewhat complex, because special behaviour needs to be done when descending slopes, to prevent trembling and sliding.

Use SLOPE_TODO wherever we have stuff to implement but don't know / cannot currently...

TO DO

• ACS GetSectorFloorZ and GetSectorCeilingZ
• Automap: display slope edges correctly, not according to horizontal surface heights.
• Automap HUD z coordinate
• P_GetFloorHeight, P_GetCeilingHeight: replace floorheight and ceilingheight with these. Have x/y as parameters.
• P_SetFloorHeight, P_SetCeilingHeight: Move slopes with the sector surfaces (on master they render at the same plane all the time)
• EV_DoCeiling: refer to proper slopes when limiting ceiling movement.
• Vertex slopes (editor support)
• A_ThingSummon, A_PainShootSkull
• D'sparil spawning height checking needs to check against a collision model
• E_HitWater
• Heretic teleport glitter spawning
• ACS SetActorPosition: proper floor Z
• CAM_ portal aware traces partially done, but sector height calculation is incorrect! Needs fixing.
• E_GetThingFloorType: proper floor Z
• E_HitFloor: proper floor Z
• EV_DoCeiling neighbouring sector floor or ceiling
• EV_DoDoor
• EV_DoElevator neighbouring sector floor and ceiling
• EV_DoFloor, EV_DoChange: finding neighbouring sector floor
• EV_DoParamFloor, EV_DoParamCeiling, EV_DoGenLiftByParameters, EV_DoParamStairs, EV_DoParamCrusher, EV_DoPlat, EV_DoParamPlat, EV_DoParamDoor
• EV_PillarBuild
• EV_PillarOpen
• EV_SilentLineTeleport
• FrictionThinker::Think
• G_CheckSpot: telefog proper floor Z
• Game saving (are slopes serialized? They're static on master.)
• Mobj::Think waterstate
• P_AdjustFloorClip
• P_CheckFPortalState, P_CheckCPortalState
• P_CrossSubsector, P_CheckSight (p_sight)
• P_DripEffect
• P_ExplodeMissile
• P_ExtremeSectorAtPoint
• P_Find...Surrounding, P_FindModelFloorSector, P_FindModelCeilingSector (for sector movement)
• P_FloorPortalZ, P_CeilingPortalZ
• P_GetChasecamTarget
• P_GetFriction, P_TeleportMove, P_CheckPosition, P_CheckPosition3D, P_CheckPositionExt, PIT_ApplyTorque, P_TryMove
• P_HereticCurrent
• P_LineOpening, P_getLineHeights, P_blockingLineDifferentLevel, PIT_CheckLine3D
• P_LocateFollowCam camparams.cz
• P_NightmareRespawn
• P_ParticleThinker
• P_PlayerInSpecialSector, P_PlayerOnSpecialFlat
• P_RespawnSpecials
• P_SectorTouchesThingVertically
• P_SetFollowCam, P_FollowCamTicker followcam.z
• P_SpawnMobj
• P_WalkTicker, P_ResetWalkcam walkcamera.z
• P_XYMovement
• P_ZMovement
• PIT_AvoidDropoff
• PIT_GetSectors
• PushThinker::Think
• PTR_AimTraverse
• PTR_chaseTraverse
• PTR_ShootTraverseVanilla, P_Shoot2SLine, PTR_ShootTraverse
• R_1SidedLine 1-sided linedef portal situation
• R_FakeFlat, R_SectorColormap, R_ProjectSprite: sloped transfer_heights
• R_ProjectParticle
• RIT_checkMobjProjection
• ScrollThinker::Think
• sloped anchor portals (see R_DefinePortal too)
• sloped horizon portal rendering
• sloped linked portals
• sloped portal overlays
• VerticalDoorThinker::Think floor height

NEED TO CHECK (uncertain):

• Add_Scroller
• CeilingWaggleThinker::Think, EV_StartCeilingWaggle
• EV_BuildStairs step height setup
• EV_DoFloor absolute floor movement
• EV_DoParamDonut floor height lookup
• FloorMoveThinker::Think delayed stairbuilding
• FloorWaggleThinker::Think, EV_StartFloorWaggle
• P_CreateSectorInterps
• P_MoveAttached
• P_SaveSectorPosition(s)
• R_AddLine, R_Subsector surface height checks
• R_DrawSpriteInDSRange
• R_RenderMaskedSegRange
• R_setSectorInterpolationState
• sloped plane portal rendering?
• T_MoveFloorDown, T_MoveFloorUp, T_MoveCeilingDown, T_MoveCeilingUp

NOTES:

• 3dMidTex y offset and clipping heights can't use the slopes, it will just be relative to the editor sector heights.

PROPOSITIONS

• Collision model: decide how slopes should block actors. There are three ways:

1. Block completely: the thing's bounding box rests completely above slope. This is consistent with behaviour against walls and sectors and results in smooth movement when clipping against linedefs.
2. Block only the Z axis. A thing base's centre will always be at floor level. This is closer to a legged actor's model where some legs are bent higher than others to stand on a slope. But it will look funny with wide monsters and steep slopes, and it will bump against any step linedefs.
3. A compromise between 1 and 2, where only about 50% of width is clipped by slopes

• Friction model: decide when should slopes become slippery (make things fall off them), unclimbable. Should moving against a slope also be tougher than moving on horizontal terrain? Keep in mind that classic steps produce no such hindrances!

It makes sense that monsters should check their "monkeys" compatibility setting to determine if they can walk on slopes or not. Dropoff calculation should be like usual, and it will be highly dependent on the chosen collision model.

Implement wrap-around portal collision detection

FreeDM 0.9 DEMO3 desyncs

Seems to start the level on the wrong player-start(s?), everything goes wrong. This is a vanilla demo that plays back fine in doom2.exe, chocolate, and prboom+

Flat replacement bug

Something to do with PWAD flats and f_end/f_start not being like vanilla

https://www.doomworld.com/vb/eternity/86558-flat-replacement-bug/

Interpolation doesn't work through line portals

It's not trivial to implement proper interpolation when passing through line portals. The bug is most visible with projectiles, but the player may also notice it if the FPS is high enough.

Linguortals support

Per http://www.doomworld.com/vb/doom-editing/74354-stupid-bsp-tricks...

Yes, it's a niche feature only to be used by a couple of test maps so far but we have no idea what the future will bring

Eternity does not load the correct Freedoom IWAD files with -iwad

This is some strange behavior. With -iwad freedoom2.wad, Eternity loads freedm.wad instead. With -iwad freedm.wad, it claims the IWAD cannot be found at all. Only -iwad freedoom1.wad seems to work properly.

Specifying the absolute path to the files works, however, such as -iwad /usr/share/games/doom/freedoom2.wad and -iwad /usr/share/games/doom/freedm.wad.

Running on 64-bit Arch Linux

ACS-called specials delete the linedef special they originate from

This means that using the legacy non-parameterized script calling specials will remove their trigger even if their name says they are repeatable.

Parameterized ones (e.g. ACS_Execute) with the REPEAT extended flag are safe from this.

Switch use is not portal aware

The ray that checks whether a switch is in the way doesn't go past line portals.

"Sparklies" on textures with transparency

I just noticed that the edges of pixels are sometimes filled with index 0, which is particularly noticeable using palettes with white instead of black as the first index.

Bullet puffs are blocked by sector linked portals

They just stop on the "ceiling" portal instead of moving up.

Allow polyobject cars to move by touching walls without visual problems

Prevent HOM from happening if a polyobject car is next to a wall. There are realistic scenarios where moving transporters are sliding along a wall, such as by using wall rails or well-controlled building blocks.

Restore pre-MBF point pushers and pullers

I suspect Lee changed them for the worse for no good reason.

UDMF branch: on TEXTMAP error, also show column, not just line

This is important if the UDMF TEXTMAP has been minified, so the only available coordinate becomes the column, everything being on first line.