ucuapps/modelicagym

Modelica models integration with Open AI Gym

modelicagym's Issues

Modym

Hi!

I'd like to share the work I've been doing highly inspired in modelicagym.

https://github.com/Wuerike/modym

Inconsistent return type in `modelica_base_env`

Hi,
the step() function usually returns a tuple which first argument is the state.
The state type turns out to be set, for the default case, by get_state(result) of the do_simulation() function and it is a tuple (modelica_base_env@241).

However, in case the step functions catches a done(), then the step function returns a np.array(self.state); thus being different from the previous case.

Am I correct?
And: why returning a tuple instead of an array which is much more comfortable to use? Is it because the FMU might return integers instead of all-reals?

Thanks!

Set options["result_handling"] = "memory" as default

Hi,
I would suggest to set options["result_handling"] = "memory" as default in modelica_base_env/do_simulation.
Writing to disk is a rather expensive operation (my code was running 15x slower because of this) and changing the setting would require overriding the do_simulation (I don't see any kwargs that passes such option to the underlying PyFMI model, right?)

While for PyFMI was making sense to leave a different default, I think that ModelicaGym users might not be interested in having a variable dump, especially if this comes at such an high performance cost.

new setup.py corrent with examples?

When running from the example dir I get ModuleNotFoundError: No module named 'gymalgs'
setup_test is working.
when changed back to ..gymalgs.rl I get
from ..gymalgs.rl import QLearner ValueError: attempted relative import beyond top-level package
can load modelicagym.gymalgs.rl but then I get ModuleNotFoundError: No module named 'examples' somewhere down the line

Simulation with multiple FMUs

As I understood by reading the tutorial on how to integrate FMU, it is only possible to use one FMU for control in this framework. My aim is to control a battery model exported as FMU, which is located in a large power network. For this purpose, I need my observation space to include quantities outside of the battery FMU. For example, if my battery is located in a bus with a photovoltaic connected (which is also another FMU) to be able to include its power in the observation space.

Is something like that possible? Would it be possible with some modifications?

Installation

The installation procedure is not working.

Mainly I guess because svn co https://svn.jmodelica.org/trunk JModelica is off.

Could you work it around? Im trying do it here too.

Another question, can this app run on windows?

Differences between linux and windows

I would like to ask if I can use modelicagym for windows and whether there are any disadvantages to using windows compared to linux.