Stratagus crash when gold mine is empty

[wargus]

Stratagus crash when gold mine is empty

[timfel]

(by rheld)

[timfel]

(by pali)
Please check if this problem is in stable 2.2.5.5 version too.

[timfel]

(by rheld)
Yes, I guess it is.. in 2.2.5.5, the same assertion appears.

Just a note: after the assertion, the way how the game exits is sometimes different.. sometimes there is a libc " double free or corruption".. sometimes there is a "X Error of failed request: BadWindow (invalid Window parameter)"

I guess, there is something wrong in the multithreading-code (these kind of error are typical for multithreading-issues)..

[timfel]

(by pali)
Ok. It is problem only with debug version (you wrote that you compiled stratagus with --enable-debug)?

[timfel]

(by rheld)
No.. the release version crashes (seg fault) too.. the only reason for the debug version was the (better) feedback to you.

[timfel]

(by iddqd-mail)
the reason of this bug:
in 7872 revision was deleted this piece of code in actions.cpp:
520 DropResource(unit);
and now when 2 workers enter the mine which have resources only for 1 worker, the game crashes
DropResource(unit) clears any information about resources from unit, also it deassigns it from mine which it was assigned before
so it's need to find a better way to drop worker's resources
maybe the crash happens because of going out of array bounds

[timfel]

(by pali)
Fixed in rev 7962:
http://bazaar.launchpad.net/~stratagus/stratagus/trunk/revision/7962