Giter Site home page Giter Site logo

png-1.5 fixes about stratagus HOT 6 CLOSED

wargus avatar wargus commented on May 24, 2024
png-1.5 fixes

from stratagus.

Comments (6)

timfel avatar timfel commented on May 24, 2024

(by tk-giga)

from stratagus.

timfel avatar timfel commented on May 24, 2024

(by pali)
And why is this patch needed?

from stratagus.

timfel avatar timfel commented on May 24, 2024

(by tk-giga)
As I said, png-1.5 now forbids access to internal struct members.
Compilerwise, without the patch, it looks like this:
src/video/obj/../png.c: In function 'LoadGraphicPNG':
src/video/obj/../png.c:136: error: dereferencing pointer to incomplete type
src/video/obj/../png.c:215: error: dereferencing pointer to incomplete type
src/video/obj/../png.c:219: error: dereferencing pointer to incomplete type
src/video/obj/../png.c:227: error: dereferencing pointer to incomplete type
src/video/obj/../png.c:273: error: dereferencing pointer to incomplete type
src/video/obj/../png.c:274: error: dereferencing pointer to incomplete type
src/video/obj/../png.c:275: error: dereferencing pointer to incomplete type
src/video/obj/../png.c:276: error: dereferencing pointer to incomplete type
src/video/obj/../png.c:277: error: dereferencing pointer to incomplete type
src/video/obj/../png.c:278: error: dereferencing pointer to incomplete type
src/video/obj/../png.c: In function 'SaveScreenshotPNG':
src/video/obj/../png.c:334: error: dereferencing pointer to incomplete type

from stratagus.

timfel avatar timfel commented on May 24, 2024

(by pali)
Is this bug same as this https://bugs.launchpad.net/stratagus/+bug/816575 ?

from stratagus.

timfel avatar timfel commented on May 24, 2024

(by tk-giga)
Yes, this patch will fix the issue reported in https://bugs.launchpad.net/stratagus/+bug/816575
Sorry that I overlooked that bug report.

from stratagus.

timfel avatar timfel commented on May 24, 2024

(by pali)
Your patch file was not possible to apply, because it was for old version of stratagus. It was against file png.c, but in stratagus is now png.cpp (and has other structure). So I modified file png.cpp manually.

Chnages is in this commit: http://bazaar.launchpad.net/~stratagus/stratagus/trunk/revision/7993
Check if all png erros is fixed.

from stratagus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.