wilsonwid/pe

Hello there, nice to meet you! I'm Wilson! 👋

I'm currently a penultimate student taking a double degree in Data Science and Analytics (DSA) and Computer Science (CS) at the National University of Singapore (NUS).

Please feel free to reach out through the clickable links below! I'm currently interested in quantitative research/trading, machine learning, or data analytics/science opportunities located in Singapore.

📖 Currently reading:

🏫 Academic reading(s):

• Mathematics of Machine Learning (by Deisenroth, Faisal, and Ong)
• Natural Language Processing with Transformers (by Tunstall, Werra, and Wolf)

🧩 Casual reading(s):

• Range: How Generalists Triumph in a Specialized World (by David Epstein)
• The Daily Stoic (by Ryan Holiday and Stephen Hanselman)

💻 Languages/Technologies:

📱 Contacts/Profiles

Reach out to me via the platforms below! My resume is available on request or on my personal website.

👨‍💻 GitHub/Coding Statistics

📊 Contribution Timeline

✍️ Acknowledgement(s)

• Profile picture by @piermanuele_sberni on Unsplash.
• Inspiration for this README from Lee Pak Shuang and Russell Saerang. Do check out their GitHub profiles for more awesome and cool stuff!
• GitHub README stats from anuraghazra and ashutosh00710

pe's Issues

Remote server is not defined

There is no definition of "remote server" found in the glossary, even though the term is used inside the Non-Functional Requirements section.

Addresses cannot have periods in them

Even though there are oftentimes periods inside addresses to indicate abbreviations or shorthands (e.g., Rd.), adding contacts that have addresses with a . is not allowed.

The expected functionality is that periods should be allowed.

Documentation is not consistent for find command

The documentation example for the delete command is not consistent with the format of the find command.

CLI is not defined

The term "CLI" is not defined inside the glossary.

Different contacts determined by phone number

The uniqueness of contacts is determined via phone numbers. However, this can be problematic as there can be individuals with the same phone number contact (especially if the phone number we know is a landline phone number).

The expected behaviour is that the uniqueness of contacts is determined via their email addresses instead.

No limit on the length of remarks

There is no limit on the length of remarks. As a result, the field for the remark might fill the entire screen. The expected functionality is that there should be a length limit for the remark field.

Inconsistency in command result

The command result box sometimes displays command results with or without full stops at the end of the text.

Wrong capitalisation in diagram

Optional.Empty() should be Optional.empty().

Reschedule command does not work for multiple meetings with the same person

The schedule and reschedule command only works if we only have a single meeting with a particular person. This is often not the case, as people might want to set two meeting times in advance.

Remark command automatically lists all the contacts again

After running the remark command, the interface is brought back to list all contacts even though the list command has not been run yet. This happens after using find n/Alex and then remark 1 r/hi.

The expected functionality is that the remark command should not bring list all the contacts until the user enters in the list command.

Inconsistent error message for deletion

There are inconsistent error messages for deletion, as even though 0 and 3 are both invalid indices, delete 0 and delete 3 yield two different error messages.

Invalid emails can be entered

There can be invalid emails entered into contacts using the edit command, those without the .com or related suffixes. The expected behaviour is that emails must be valid email, but abc@abc is accepted as a valid email.

Person diagram is missing remark

The diagram does not show that remark is a possible attribute for the Person class, even though it is in the code. There should be a Remark box in the diagram.

test

test

Inconsistent use of spaces

The text "use case ends" in 2a has a different spacing than for 3a and 4a.

No limit on the length of names

There is no limit placed on the length of names. As a result, this can lead to situations like the above, where the name fills the entire screen.

The expected functionality is that there should be a limit to the length of names.

Inconsistent error message for reschedule

There is inconsistency in the error message for reschedule. When reschedule 0 is entered, the error message is shown as being an invalid command format. However, when reschedule 7 is entered, the error message is "At least one field to edit must be provided." The expected functionality is that entering reschedule 7 should yield the same error message as entering reschedule 0.

Inconsistent use of "x" in the diagram

r:CommandResult is no longer present but does not have an "x" associated with its lifeline, even though other objects do.

Help page does not have command format and examples

The help page, when accessed with the help command, does not have command format and examples. This means that individuals who wish to use the application still need to access the user guide, which defeats the purpose of having all the commands listed in one place.

Name cannot accept symbols

Names are unable to accept the / symbol. This can cause issues with names that have s/o as part of a legal name.

The expected functionality is that the / symbol should be accepted.

JAR should be capitalised

The term "JAR" should be capitalised as it is shorthand for Java Archive.

Application does not notify if there are clashes in schedules

There can be two meetings scheduled in the same time without the application signalling to the user that there has been a clash. This can lead to bad consequences, as clients might not want to meet each other at the same time, or the financial advisor might forget that they have another meeting at the time.

The expected functionality is that the application should indicate there is a clash if there are two meetings at the same time.

Grammatical issue for deletetag command

The expected message is "The specified person must have all the specified TAGs." as it is plural.

Clear command does not prompt for confirmation

The clear command does not prompt for confirmation from the user. This can cause very disastrous effects, as a financial advisor might inadvertently type in the command, causing them to lose all data related to clients, which might be very valuable to the financial advisor and can cause serious consequences for them.

The expected functionality is that there should be a prompt confirming that the user wishes to run the clear command.