woefe/shoppinglist

A simple shopping list for Android

shoppinglist's Issues

Add filechooser to select storage directory

Currently, the user has to write the path into a free-text text field. The app should use some kind of filchooser for this.

Markdown syntax

Instead

---[ Shopping ]
+++# Shopping
---bread # 1
+++- [ ] bread `1`
---// bananas # 6
+++- [x] bananas `6`

compatibility to .lst

• add a converter

So markdown rendered

---

Shopping

• bread 1
• bananas 6

settings: font size

This app is really useful, not only for shopping lists, but for all kind of TODO lists. My entries have a bit more text than a typical "milk, eggs, beer" - shopping list, so it would be great to be able to change the size of the font that is used to render the lists.
One setting for all lists would fit most usecases. I see no need for a per-list setting.

Also, this way all types of devices would be better supported, as the wall-mounted tablet in the kitchen and a small sized smartphone have quite different requirements on displayed font size, even if they have the same screen-resolution.

Click delete on an empty list crashes app

Expected behavior

Using delete list option on an empty list should show toast notification of no list to delete, or should be greyed out.

Actual behavior

Delete option on an empty list makes the app to crash.

How to reproduce

• Download app here.
• Delete the default list to get an empty list.
• Use the delete option on the empty list.
• App crashes

---

• App: Shopping list version 0.9.0
• Operating system: Android Nougat 7.0

Recording Of The Bug

---

Posted on Utopian.io - Rewarding Open Source Contributors

---

Automatic sorting

To be able to sort the lists is a nice feature but it would be even nicer if the sorting could be applied automatically (When the list changes)

Fix crash when WRITE_EXTERNAL_STORAGE is revoked

Fix crash when WRITE_EXTERNAL_STORAGE is revoked while app is running (in background)

add possibility to move items between lists

it should be possible to move items from one list to another

Add categories

Hi,
I'd appreciate the implementation of categories, in order to sort items in a functional way (vegetables, beverage, etc.).

A category might be a field, completed with free text:

[ Supermarket ]

Beer #6; Beverage
Apples #1; Fruit
Prosecco #2; Beverage

or something similar.

Best regards,
Carlo

Logo Proposal For Shopping List

Hallo I Ahyar , I would like to propose the latest logo for your application. I created a logo that will give the latest impression to your application, and the logo I created will greatly describe the functionality of your application :)

If you like it, I can give you a file (GOOGLE DRIVE) :). Simply by replying to this offer :)

Thank you

Add HowTo Sync to the GitHub home page

The description of this app on F-Droid says there are ways to sync with Syncthing and Nextcloud. But there is no How to. Even if we click on the link item on F-Droid
Please, add an How to on the github homepage, next to the file format.

Simplify adding frequently used items

Currently, there is no autocompletion or repository to choose frequently used items from. To add new items to a list, one has to type every single item again and again. This should be improved to be faster and require less typing.

Ideas:

• Record statistics of which items are added most frequently. Statistics are recorded in the default SQLite database of the app, not the shoppinglist text files.
• Add setting to configure the maximum number of items in this list
• Either:
  • Provide option to add a batch of new items from a list sorted by frequency
  • or implement autocompletion for existing EditBar using . Autcompletion could also based on "most popular" items.

New Logo for ShoppingList

Hello @woefe , I want contribute to ShoppingList, so i designed a new logo for ShoppingList and it's free.

I hope you like it. If you like it, I will send you pull request, editable files/original source and .png format files. If there's something you want to change, I'll do it.

if you want i will send you my designed

add view that shows all lists

add a view that shows all lists concatenated.
a separator including the list name may be prepended to help browsing.
optionally there should be a config option that selects the lists in the combined view.
deselected items may be ignored and not displayed. it should be possible to deselect items in that view, though.

Open last opened list

Hi,
thanks for the app. However, it'd be cool if the app opened the list that was opened when it was closed. Or, which would be even better, allow reordering of the lists.

[feature request] add product by EAN barcode

please make it possible to scan the barcode of a product to add it to the list.
for the beginning it would be ok, to maintain a local database and learn/associate EAN barcodes with a product on the list. later, this may be connected to an online EAN database.

currently my workflow is that whenever i use the last item of a product to put it on my list in order to buy it. so i already have it in my hand and a quick scan would be more efficient.

nextcloud integration (how to?)

I really like the idea and the plain layout of the App.

Nonetheless I can't get the App to run and sync with a nextcloud account.
I read all the related posts but unfortunately couldn't get any useful hints there.
The directory is not on a SD-card. How can I get the app working with nextcloud-sync?

If all lists are deleted, an attempt to share or delete a list crashes the app

Expected behaviour

If there is no list, the user should be warned that there is none to share or delete.

Actual behaviour

If the user deletes all lists so he can see "No lists are available", the attempt of sharing or deleting a list causes the app crash.

Steps to reproduce

1. Delete all lists (including the default one)
2. Click the three dots menu
3. Share or delete a list

Logcat

05-03 11:46:40.253 31893 31893 E AndroidRuntime: FATAL EXCEPTION: main
05-03 11:46:40.253 31893 31893 E AndroidRuntime: Process: com.woefe.shoppinglist, PID: 31893
05-03 11:46:40.253 31893 31893 E AndroidRuntime: java.lang.NullPointerException: Attempt to read from field 'java.lang.String com.woefe.shoppinglist.shoppinglist.ShoppingListsManager$ShoppingListMetadata.filename' on a null object reference
05-03 11:46:40.253 31893 31893 E AndroidRuntime:        at com.woefe.shoppinglist.shoppinglist.ShoppingListsManager$ShoppingListMetadata.access$1000(ShoppingListsManager.java:239)
05-03 11:46:40.253 31893 31893 E AndroidRuntime:        at com.woefe.shoppinglist.shoppinglist.ShoppingListsManager$MetadataContainer.removeByName(ShoppingListsManager.java:271)
05-03 11:46:40.253 31893 31893 E AndroidRuntime:        at com.woefe.shoppinglist.shoppinglist.ShoppingListsManager$MetadataContainer.access$1400(ShoppingListsManager.java:252)
05-03 11:46:40.253 31893 31893 E AndroidRuntime:        at com.woefe.shoppinglist.shoppinglist.ShoppingListsManager.removeList(ShoppingListsManager.java:211)
05-03 11:46:40.253 31893 31893 E AndroidRuntime:        at com.woefe.shoppinglist.shoppinglist.ShoppingListService$ShoppingListBinder.removeList(ShoppingListService.java:92)
05-03 11:46:40.253 31893 31893 E AndroidRuntime:        at com.woefe.shoppinglist.activity.MainActivity.onPositiveButtonClicked(MainActivity.java:281)
05-03 11:46:40.253 31893 31893 E AndroidRuntime:        at com.woefe.shoppinglist.dialog.ConfirmationDialog$2.onClick(ConfirmationDialog.java:78)
05-03 11:46:40.253 31893 31893 E AndroidRuntime:        at com.android.internal.app.AlertController$ButtonHandler.handleMessage(AlertController.java:171)
05-03 11:46:40.253 31893 31893 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:110)
05-03 11:46:40.253 31893 31893 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:203)
05-03 11:46:40.253 31893 31893 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:6297)
05-03 11:46:40.253 31893 31893 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
05-03 11:46:40.253 31893 31893 E AndroidRuntime:        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1084)
05-03 11:46:40.253 31893 31893 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:945)

• OS: Android 7.1.1
• app version 0.9.0

Check WRITE_EXTERNAL_STORAGE permission on startup

Currently, the app silently ignores file permission errors and falls back to the default data directory. This should be handled more transparently:

• Ask for WRITE_EXTERNAL_STORAGE if it is not granted
• Show a Toast/Snackbar if permission to the data directory is denied (and asking for a permission did not fix it

Add feature to rename a list

Publish to Play Store

Hi,

Please publish this application to Google Play Store.

FR: toggle to hide checked items

Title says it all, in the top bar like the sort :)

For me would me much more useful to hide checked items rather than deleting them, as more often than not items are consumables that will be purchased more often.

Also, i think it is less dangerous to have a hiding toggle in the status bar than a delete all button.

Add undo button for last deleted item

After deleting an item by swiping, there should be an undo button in place of the delted item. Similar to Android's default E-Mail app. Alternatively, the undo mechanism could be provided by a Snackbar

The application is broken after selecting the folder in (file location)

expected behavior

After selecting the folder in the feature (file location) then back to the main page of the application, this application should not be damaged.

Real behavior

After the user selects the folder in the feature (file location) and the user returns to the application main page suddenly the application is broken.

How to reproduce

• Download app in f-droid.
• Run the app.
• Create a new list and click ok.
• Next go to settings.
• select location feature.
• select a folder and click ok.
• then back to the app's main page.
• suddenly the application is broken.
• Browser: Shopping List v0.10.0
• Operating system: xiomi redmi 4A, Android v6.0.1

Recording Of The Bug

https://youtu.be/EzshbwNw7nY

Categorization and sort by category

Also integrate with completion.
With custom sort order by category
Remember mapping between list and category, but allow changing sort.
still allow manual sorting

Shopping list crashes after changing the file location of a created list.

Expected behavior

The application should let us change the file location of the created list without any issues.

Actual behaviour

I created a new shopping list .
I just happened to change the location of the shopping list and the operation was executed successfully.
However when I tried to go back to the homepage,the app crashed .
After reopening the shopping list ,the created list disappeared.

License

Why is license for the application missing from the repository?

Synchronising ShoppingList using Nextcloud (and maybe others) is too hard

Hi,
I tried to get my ShoppingList to synchronise using Nextcloud but haven't been able too.

I created a directory in Nextcloud to store my Shopping List, entered the full path in ShoppingList's settings (in my case: /storage/sdcard1/Android/media/com.nextcloud.client/nextcloud/[email protected]%2Fnextcloud_path/Shared/ShoppingList BTW, copy pasting a path is not a very fun experience in Android) and… nothing.

I can't tell if ShoppingList has picked the change up, if the path is valid (or not). The '@' is escaped because I copy/pasted from my terminal app, but I have no idea if that's necessary or not.
Also, there is bug #1 that makes me think it's not goinq to work anyway, because Nextcloud saves to my SD card.
Creating new test lists doesn't make them (or the original one) in the Nextcloud directory.

If one of ShoppingList's listed features is synchronising a shopping list, I believe some effort should be made to make that better documentend (bug #9) and easier to use.

Thanks!

Add an option to move shopping lists into their own folder

This would allow synchronizing some of the shopping lists with my flatmate, while keeping others private.

I am not sure whether this would be better on a per-list setting, or as a global one.

The per-list setting probably makes more sense? If there is a folder "Mylist" and "Mylist/Mylist.lst" exists then display it as a list.

---

Next would be to add a few tags for multi-user shopping, I guess? (Added by/checked by/etc). But that's kind of out of the scope. (Maybe I'll do a git-based fork later? :P)

Reload lists when directory settings change

When navigating from settings fragment back to the main activity, the lists should be (re)loaded from the new directory, if the path was changed.

Adaptive icon

Support adaptive icons so that the app icon looks nicer on Android 8 + 9.

Add product images and recurring items

This is a great app, but when I add products only by description, I would need to include the brand name for a specific price.
What would make things easier, is to have a list of items (say things you need every week, like bread, milk, etc) saved. So i can select those items instead of having to re-add them everytime. For these items, it would help to have an image associated with it. I would imagine the listview to have a bit taller colums, and a little image view to the left of the product name and quantity.
In this case, if you add an item(enter name and quantity), there could be a button with "add image". Once an image is added, that specific item could be saved inside the app to re-select later.
Thanks again for making this :)

App doesn't prevent adding the same item twice

Hi and thanks for this app!

Bug

I've realised it's possible to add the same item twice. This is contradictory to the goal of a shopping list: put stuff on the list so you don't have to try and remember what you need to buy.
If I have to remember (or look) at the list when I add something to avoid adding it twice, then it defeats the purpose to some extent.

Suggested behaviour

When adding an item that already exists, either:

• filter the list while typing to show items that correspond, eventually showing that the item already exists
• ask the user "$item is already exists on the list, would you like to increment the number of $item you want to buy?"

Translation to Brazilian portuguese

Hello! I would like to help you translate your app to Brazilian portuguese, because I like the app, It's useful and I use it. But I don't know much about programming and GitHub. How I can help you?

Cannot choose folder location

When I click settings/file location it blinks and takes me back to application main page. I am not able to change folder save path from default /data/data/.. folder.
I am running Android 5.1.1, with 0.9 ver of shopping list

Set filepath to Nextcloud offline folder

Hi!
I have set up the filepath for the shopping lists to my nextcloud folder.
However the lists are not stored there. They are stored under /data/data/com.woefe.shoppinglist/

Sorting

A sorting and an auto sorting function would be nice. :-)

• Manual A-Z sort or opposite from the menu.
• Automatic (at runtime) A-Z sorting, so the list is always in order
• Manual sorting for checked and unchecked items and opposite
• Automatic sorting for checked and unchecked and opposite, so the list is always ready for shopping

Thanks in advance.

Add copying of lists

I would like to have a copy-and-edit workflow for lists. For example, I'd prefer to use a "master" list for my grocery shipping that has all the stuff I usually buy. Then I'd make a copy of it. I'd use the copy as a new shopping list. In the new list, I could just delete everything that I don't want and add stuff that I don't buy regularly.

"Native" Nextcloud integration

Nextcloud for Android cannot watch a folder for changes. To improve syncing with Nextcloud, there should be better integration e.g. via WebDav or maybe even a Nextcloud app.

lists containing special characters vanish

list names containing special characters like "/" or "&" can be created and filled with items.
when the app is reloaded, the list and its items have vanished.

Check/uncheck all items

The title says it all, just an option to check or uncheck everything in the list :) especially useful for recurring lists

Add contributor section to AboutActivity

The app has an "About" screen. List translators and contributors there (in particular @Rudloff for his translation to French).

A pull request is already pending (#24)

Manual sorting of items results in items overlaping

Workaround is to switch to a different list and back.

In the example below, Item 2 was moved up and now covers Item 1.

Edit: Only an issue on Kitkat, not Nougat, so probably not a priority.

Add snackbar to undo swipe-to-delete actions

Among most other apps that employ swipe-to-delete, it's common to have a snackbar to allow users to undo unintended, accidental deletes. That would be great to have in ShoppingList, too! :)

Example (from Minimal):

[Feature request] Add option, to rename a shopping list

An option to rename a shopping list would be good.

Is this app still being maintained? Would a pullrequest implementing this feature be merged?

Dark theme

Nice app!

A dark theme would be really cool.

App crashes while clicking on delete list

Actual behaviour

When i open the shopping list app and add shopping list by clicking on plus sign at the bottom of left side.then I click on option botton and select delete list option and delete all lists . I again go to options blog and click on delete list option.After clicking on delete option app crashes.

How to reproduce

• Open the shopping list app.
• Add shopping list by clicking on plus sign.
• Click on options botton at the top.
• select delete list option and delete shopping lists.
• Again click on options botton.
• Click on delete list option.
• After clicking on delete list option app crashes.
• Browser: shopping list.
• Version:0.9.0
• Operating system:7.1.2

Recording of the bug:

https://youtu.be/0VRs6d1EmDU

[Feature] Move checked items down

It would be nice to have an option to automatically move checked items down in the list so you only see what you need as you go.
Currently I move items manually using the arrows on the right, which isn't very practical.

Implement scoped directory access

Please implement scoped directory access so that READ_EXTERNAL_STORAGE & WRITE_EXTERNAL_STORAGE are no longer needed.

Scoped directory access is new in Android 10.

Ability to attach URL to any item

A lot of shopping is done online these days. Why not add the ability to add a link to a list item?

Fix crash when list name changes externally

The app crashes, when trying to reload list from disk and the name of the currently displayed list changed