still keep "Updating..." when I click the "update now" button

[yahniselsts]

still keep "Updating..." when I click the "update now" button

[YahnisElsts]

Are you using the master branch of the update checker or a release version? There's a GitHub-specific bug that has already been fixed in master but I haven't tagged a new release yet.

Try opening the "update now" link in a new tab (middle-click or right-click and select "Open In a New Tab"). This way you'll get more details about the update installation process. Are there any error messages? On that note, are there any recent entries in your PHP error log?

[loremuelgadrinab]

I have move my plugin code into my server directory. now I am using the "Self-hosted Plugins".

this is inside my json-api.json file in my server:

{
"name" : "My Plugin",
"version" : "1.3.1.3",
"author" : "My Name",
"download_url" : "http://mysite.com/plugin-directory/myplugin.zip",
"sections" : {
"description" : "some text here"
}
}

in my myplugin-function.php I have this code:

require 'plugin-update-checker/plugin-update-checker.php';
$myUpdateChecker = PucFactory::buildUpdateChecker(
'http://mysite.com/plugin-directory/myplugin.zip/json-api.json',
FILE
);

now when I click the update now button to open in new tab it says:

Downloading update from http://example.com/plugins/my-cool-plugin.zip…
Download failed. Not Found

I have no idea why it goes like this, I have checked all the files and code; even in my local codes works and update successfully. but in my live code didn't work.

I am alsp wondering why it link into "http://example.com/plugins/my-cool-plugin.zip" where I have set the code in json-api.json into "http://mysite.com/plugin-directory/myplugin.zip" ??

please help, I am almost done with it

[YahnisElsts]

Maybe you used that URL (http://example.com/plugins/my-cool-plugin.zip) in json-api.json before, and the update checker still has that old version of the file cached? By default, it only checks for changes every 12 hours or so. Go to the "Plugins" page and click the "check for updates" link under your plugin entry. That will force it to refresh the cache.

I would also recommend installing the Debug Bar plugin. You can find a lot of useful debugging information in the "PUC (your-plugin-slug)" section of Debug Bar.

[YahnisElsts]

Any news on this?

[alessandrobellesia]

I had a similar problem. In my case the website and the repository had the same domain.
You can try to disable the wordpress http-get external domain security feature adding this line to your plugin:

add_filter( 'http_request_host_is_external', '__return_true' );

[YahnisElsts]

Yes, that's a known issue with hosting updates on the same domain. Maybe I should add a similar workaround to the library itself...

[YahnisElsts]

Update: Should be fixed in 7a29fda.

[alessandrobellesia]

Great! Thank you!

[YahnisElsts]

Well, I guess it's fixed, sort of? @loremuelgadrinab , if it still doesn't work for you, feel free to comment/reopen the issue.