issue if separate plugins use PUC 2.0 and 2.2 on the same WordPress site

[yahniselsts]

issue if separate plugins use PUC 2.0 and 2.2 on the same WordPress site

[seyfro]

I did some more tests and found that if I outcomment the "non-versioned variants of the update checker classes" at the end of the class, both plugins work fine:

/**
 * Create non-versioned variants of the update checker classes. This allows for backwards
 * compatibility with versions that did not use a factory, and it simplifies doc-comments.
 */
/*
if ( !class_exists('PluginUpdateChecker', false) ) {
    class PluginUpdateChecker extends PluginUpdateChecker_2_2 { }
}
if ( !class_exists('PluginUpdate', false) ) {
    class PluginUpdate extends PluginUpdate_2_2 {}
}
if ( !class_exists('PluginInfo', false) ) {
    class PluginInfo extends PluginInfo_2_2 {}
}
*/

As my plugin is named "Maps Marker Pro", my PUC class is first loaded I guess and so when PUC for "UpDraftPlus" is loaded afterwards, the code above has already loaded PUC2.2 which breaks the PUC for UpdraftPlus - at least this is what I think happens.

what would be your advice here, taking into account that multiple PUC instances with different versions might be active on a WordPress site?

[YahnisElsts]

Are both plugins instantiating a specific version of PUC by using e.g. new PluginUpdateChecker_2_0(...), or are they using PucFactory::buildUpdateChecker which always gives you the newest loaded version? Or some combination of both?

If both plugins explicitly ask for a specific version, there shouldn't be any conflicts (and if there are, then that's a bug in PUC). On the other hand, if a plugin uses the "give me the newest version" approach, then it must be prepared to actually support the newest version of PUC, and things may break if it does not.

I did some more tests and found that if I outcomment the "non-versioned variants of the update checker classes" at the end of the class, both plugins work fine [...]

Ah, it sounds like UpDraftPlus is using the old way to instantiate the update checker that didn't really allow for running multiple different versions at the same time. I should probably deprecate or remove those classes.

In this case, removing that code from your copy of plugin-update-checker.php would probably be the easiest solution.

[seyfro]

Thanks for the prompt reply!

You seem to be right - UpDraftPlus is using the following code to load PUC:
$plug_updatechecker = new PluginUpdateChecker($this->url."/plugin-info/", WP_PLUGIN_DIR.'/'.$this->slug.'/'.$this->slug.'.php', $this->slug, 24);

while I am using

$run_PluginUpdateChecker = new PluginUpdateChecker_2_2( 
    $lmm_plugin_updater_url,
    plugin_dir_path( __FILE__ ) . 'leaflet-maps-marker.php',
    'leaflet-maps-marker-pro',
    '12',
    'leafletmapsmarkerpro_pluginupdatechecker'
);

I will remove the "non-versioned variants of the update checker classes" from my PUC class as I do not use them within my plugin and those might only conflict with other plugins.