emperorcow/chaosbrewclub

CHAOS Brew Club website

chaosbrewclub's Issues

Add per-role checking to reservation system

Validate birthdate for users joining by gift membership

I'm not really familiar with the gift membership workflow, so I need to start by getting that figured out. From what I remember, the gift recipient logs into the website at some point to confirm/state/whatever the membership. At that point, we should require their birthdate, to confirm they're over 21. Right now, gift recipients can start a membership without a birthday.

Mobile menu doesn't match regular menu

I assume that there's some kind of preprocessing happening on the menu, because the visible menu doesn't match what's shown in the admin (https://www.chaosbrewclub.net/admin/structure/menu/manage/main-menu).

The admin shows Door Code and Calendar. The public sites shows Calendar and Reserve Brew Time. The mobile site (even for anon users) shows the Door Code and Calendar.

Update code in repo

Based on this comment about enabling the Honeypot module, I'm guessing the code here in the repo might be out of date. Could you add anything that's missing?

Access to backups?

Another backup-related question that occurred to me the other day: you have a solid backup schedule in place, but does anyone else have access to them? If you were incapacitated or ragequit CHAOS tomorrow, would someone else on the board be able to get at those?

Gift Membership Issue

From Jeff W:

A friend of mine bought a gift membership yesterday. He said there was a picture blocking the payment button. He eventually figured out that if he held his mouse over the correct spot, he was able to make the payment. Not sure if anything can be done to make the process easier, but I'm wondering if other people are experiencing the same issue.

Organize the modules directory

Contrib modules should go in a contrib subdirectory, so that we can also add custom and features directories alongside it, and keep track of where modules come from.

I need to confirm that Drupal won't go down in flames if it doesn't find those files where it expects to find them. I think we just need to clear the cache and rebuild the class registry, but that needs to be tested.

Weekly news email doesn't correctly organize events

This might only be for Sunday events. From the email sent out today:

*Sunday*
 * Board Meeting [1] - 4:30pm
 * CHAOS Meeting 38 [2] - 6:00pm
 * AHA Rally at Revolution Brewing  [3] - 1:00pm

The first two items were today; the third is next week Sunday.

Export config to code

Te Features module ain't great, but it's the best we've got, so it's become the de facto standard.

Export config into modules so that it can be version controlled.

Event check-in: increase fetch limit on query

The event user search is limited to 10 results right now, and the app doesn't allow spaces. While looking for someone named Mike Kim, he wasn't in the first 10 results for Mike or Kim, so he didn't appear in the app until I searched by his username or email address.

The lowest-effort fix for this would be to just bump the limit to 20 in chaos_eventattendance_search_users(). It is a paged query, so we could tweak it to accept a page number in the request, but that would also require a change in the app to request more results as needed.

Join and Donate buttons in left sidebar

Original thread: http://www.chaosbrewclub.net/forum/search-bar-membership-buttons

From Jim's email:

…checking to see if there's any progress on the "Join" and "Give" buttons to replace the search box. The more I think about it, with our unique philosophy and brew space, we could really entice some crowdfunding from literally anywhere around the world if we had a very obvious and explicit way for people to just throw money at the club.

To reiterate:
web-only members would see "Become a Member" and "Donate to CHAOS";
Trial and Apprentice would see "Upgrade Membership" and "Donate to CHAOS"
Intro Brewer and (Full) Brewer would see: "Gift a Membership" and "Donate to CHAOS".

Reservation availability seems to be conflicting with itself

I reserved bay 3 from 10:30 to 3:30, with no reservations after mine. I tried to edit that reservation to extend it later and when saving the node, get the error "Bay 3 is not available at that time." I had to cancel and re-create the reservation to extend it. I'm guessing that the schedule conflict checking code is not excluding the reservation that it's checking for.

Add Alterable Field to chaos_groupbuy for delivery charge

The chaos_groupbuy module currently uses a mandatory delivery charge based on the original use case. Now that smaller buys are occurring where people pickup stuff on their own, we need to update the database and module to allow that to be changed or made optional.

Remove Empty Page Callbacks

I'm pretty sure we can just get rid of this module: https://www.chaosbrewclub.net/admin/structure/empty-page

Near as I can tell, it just defines the paths for the brewhouse and event calendars, so that the blocks from those two views can be placed on those empty pages. In both cases, only the Desktop version of the view is positioned as a block; if the Mobile versions are being used somewhere, I don't see where that's happening.

If the Desktop version is indeed being used in all cases, we could just make those Desktop displays actual Page displays (instead of Block) and assign to them the paths that are currently being handled by the Empty Page module.

Create issues for open threads in the Website Committe forum

http://www.chaosbrewclub.net/forums/website-committee

I opened a few issues, but there are a bunch of threads going back a couple months with ideas and bug reports. Go through these and open issues for things that still need to be addressed.

Add a note field to the reservation node type

This one should be simple. It seems like it would be a good idea to include an note field on reservations so people can include things like "I reserved three bays because I'm supervising two new brewers" or "My schedule is flexible so let me know if you really need to brew this day and I can reschedule."

Nuke Mandrill queue during site rebuild

This is just for my local dev setup. I want to make sure that Mandrill never sends email from my local dev site.

Update brewhouse reservation map

I posted on the forum about this: http://www.chaosbrewclub.net/forum/website-committee/update-brewhouse-reservation-map

@emperorcow did you create those map images? Do you have the original Photoshop/Illustrator/whatever file(s)? I think I can manage updating them if I have the originals.

Javascript failing on mobile devices

I've heard from several people (and seen myself) that the login form and menu won't come up on iOS and Android. I thought it was a cookie issue, because switching to private mode fixed it the first time I saw it. Today it seems to be working for me, though, so I'm not sure what's going on.

Reservations being made with the wrong timezone

Not sure how this happened.

http://www.chaosbrewclub.net/reservation/17093

Fix the time included in brewhouse reservation reminders

Note that the time is missing on this reservation reminder email. I checked my older mail, and it was missing on another one too.

Make the site a checkout of this repo

Is the production site already a checkout of this repo?

This way, we can just do a git pull on the server when it's time to deploy changes. This has to be followed by a drush updb, drush cc all, and later, a drush fra --force -y, but we can wrap that in a bash script later on.

DB dump

Step one: I need a recent DB dump to get a local dev site up and running. Ideally, this will have any sensitive information stripped out. Failing that, encrypt it before sending, and I'll keep it safe. Here's my public key: https://gist.github.com/brockboland/274e3c1f0bc5c7ce4e32

Title on user edit pages is wrong

This one's really minor, but the user edit page always shows the current user's name at the top.

Beef up spam prevention on user registration form

Mollom isn't cutting it. We're not getting spam comments (that I've seen), but have a ton of junk user registrations:

https://www.chaosbrewclub.net/admin/people

Add JSON access to users

Conrad is currently working on an iPhone app that will allow us to better check in people during events. We've tried a couple modules, but services was a pain to get working and the others actually caused the site to crash due to the way they integrated with other modules. As such, its probably going to be easier to just write one from scratch that lists users, gives us the info for them, and then creates a database table to allow us to track who attended our events. Thoughts?

Superfish 404s in the log

Not found: sites/all/libraries/superfish/sfsmallscreen.js

Review notes, create issues

I took a bunch of notes when we sat down to talk about the site, including some things we talked about adding or improving, and then never revisited said notes.

Review those notes, and create/update issues as appropriate.

Cleanup after figuring out email problems

Thread: http://www.chaosbrewclub.net/forum/email-not-sending-site

• Disable Database Logging

Strip out text files

Lose the CHANGELOG, INSTALL, etc. The only txt files we need to keep are the README and robots.

Allow multiple locations on partners

Some partners have multiple locations.

Improve display of Brewing Reservation nodes

These display the relevant info in a not-very-readable way. Some minor touchups could really make this easier to read.

Fix logic for "Member since" date

With memberships failing due to credit card problems, we have to cancel ongoing memberships and have people re-create them. This results in incorrect dates in the forum sidebar. Here's an example showing that Jim has only been around for four days:

The logic for this is a bit hacky as it is, and I'm sure I can further hack it to show their actual start date.

Check on accuracy of brewhouse reservation reminders

I had a reservation yesterday. It was originally scheduled for today, but then I moved it up a day. While I was at the brewhouse, I received this reminder email about my reservation "tomorrow" (meaning, today).

Check that the scheduling for reminder emails is updated if a reservation is changed.

Fix reservation blocking

From http://www.chaosbrewclub.net/forum/website-committee/disabling-reservations-issue

It looks like the disable reservation option is not working correctly. Jim had blocked out 3:00 pm through 11:00 pm next Thursday for the Gino's East thing. However, my friend was able to reserve a bottling station within that time frame.

From what I can tell, reservations are only blocked if one attempts to make one that starts at 3:00 pm or ends at 11:00 pm. Reservations between those two times are still possible.

queue_ui not in repo

There's a queue_ui module in use on the production site that I don't see in the repo.

Issue tracking

I was talking to Jim about the website the other day, and he mentioned that there had been a way to report website issues right on the website. Sure enough, I see an Issue content type on the node/add list, but it doesn't work, nor does it appear in the list of content types under Structure, so I'm guessing this was provided by a module that ain't quite right.

This is less important than other things right now, but we should get that fixed. The issues here in GitHub will serve the need for the time being, but only the two of us have access to them (for now, anyway), and I think it's a good idea to make it easy for anyone to report issues they find. As long as we have a way to track the status and responsible party for an issue, it doesn't matter what system it's in.

Remove commented-out code?

Here's an apology followed by a bunch of commented-out code:

https://github.com/emperorcow/chaosbrewclub/blob/master/sites/all/themes/chaostheme/template.php#L31-L133

Can all that code be removed? Obviously, it's not in use right now, but is there a reason it might be in the future? (and is that reason good enough to keep this around, now that it's also in the git history?)

Fix starting time on reservation form

This drives me nuts: the dropdowns on the time fields start at the current time. So, if it's 8:05pm and I got to create a reservation for Saturday morning, the first time available in the list is 8:15pm, and I have to scroll down to find morning hours.

Yes, I know that you can just type in the time, but the fact that the dropdown doesn't just start at midnight (or better yet, maybe 8am) irritates me.

View count on forum pages

From Jim on Oct 4:

I'll totally admit I wonder how many people actually read/view my post and intentionally don't reply and how many just flat-out don't see them. But, less personally, I think it's a valid question of any post considering that some people don't get notified when someone starts a discussion, some people don't "follow" a discussion, and discussions scroll off the main page so quickly (and I doubt people actually click on the "Forum" link on the menu bar)!

I know on the last web-site (ning.com) it showed how many views any given post had. Is there any way to do that with the current site? I think it would give us some interesting data (esp. for posts soliciting volunteers for events, &c. - maybe it's not that members aren't willing to volunteer for events, maybe they just didn't see the post!).

Just a totally random (and admittedly buzzed) thought on a gloomy drinking Saturday.

My response:

This should certainly be do-able one way or another. I always go to the new and updated topic page (http://www.chaosbrewclub.net/forum/new), and items drop off there once you've viewed them, so it's certainly keeping track of what threads have been seen by what user: surely, we can tap into that to get a count.

There's a couple ways to go about a view count:

1. Total number of views, by logged-in users or non-members who are just browsing
2. Total number of views, by logged-in users only
3. Total number of people who have seen it, which would only count one "view" for you if you come back to the page over and over to follow the conversation. For people who aren't logged in, I'm not sure how accurate this will really be.
4. Total number of registered members who have viewed the page, counting only one "view" regardless of how many times they come look at it.

I think a combination of 2 and 4 is the sweet spot, if we can do it, so it would say something like "This thread has been viewed 42 times by 31 members" or something like that. Sound good? Keep in mind, I haven't dug into this yet so I'm not making any promises: to get an accurate count, we may need to enable more activity logging, which would put a greater load on the server, which might not be feasible at this time.

Waiting to hear back before moving forward with this.

Force everyone to use HTTPS

I keep accidentally logging myself out when I click a link to whichever scheme I'm not currently on (HTTP or HTTPS). I know there's Drupal modules that can do the redirect (with varying levels of success), but it might be safer, easier, and faster (from a page load perspective) to do so in .htaccess. That's do-able, right?

Brewing reservation conflicts are iffy

Found another case where a brewing conflict wasn't caught.

Existing reservation on Bay 4 from 4 to 10:

When I try to reserve 5 to 7, Bay 4 should be unavailable, but this one isn't blocked:

Add Tower of Power to reservation system

Change membership report to include dates of membership expiration, etc.

Add Partner Map page

• Install the GMap module: https://drupal.org/project/gmap
• Create a new view display to show all published Partner nodes on a map

This can probably be done as a new display on the existing Sponsors view here: https://www.chaosbrewclub.net/admin/structure/views/view/sponsors/edit

We have two options for implementation:

• New page
• Put it at the top or bottom of the existing Partners list (as an Attachment view display)

Tweak left sidebar to promote membership

http://www.chaosbrewclub.net/forum/search-bar-membership-buttons

I need to re-read that thread and confirm what's supposed to happen here.

Dragging reservations in the brewhouse calendar doesn't check conflicts

On the calendar view for brewhouse reservations, you can drag a reservation from one day to another (or to a different timeslot, if you look at the week or day view). When you do this, the node is update immediately, and the new timeslot is not checked for conflicts.

The easiest fix here would be to disable dragging and resizing on that view, so that people have to actually edit the node to make the change.

This is an easy change in the view:

Don't allow anonymous access to the brewhouse calendar

I think the Brewhouse Calendar should be members-only.

Multiple User Views

We currently have two user search views: https://www.chaosbrewclub.net/board/user/operations and https://www.chaosbrewclub.net/admin/user-search. We should combine the functionality if necessary.

Duplicate galleries

I haven't tested this, but we seem to be getting two Gallery nodes for every one created.

They aren't being created at the same time, though. I looked at the authoring info for the Randy Mosher and Harvest Fest galleries. In both cases, the same person created the two galleries, but at different times. It's possible that they created the gallery without posting any photos, forgot about it, and created another gallery later on when they were ready to post. That seems a bit unlikely, though.

The Harvest Fest galleries:

• 2014-10-21 19:24:42 -0500
• 2014-10-19 21:16:31 -0500

Randy Mosher:

• 2014-10-27 11:58:51 -0500
• 2014-10-26 20:35:33 -0500

Brew-BQ (both of these have images, so maybe he forgot he'd created the first one and added the second later on)

• 2014-08-11 15:16:44 -0500
• 2014-08-11 14:54:21 -0500

I sent Matt Omura a message to ask if he might have created two Randy Mosher galleries by mistake.