fauxfaux/puttytray

Previously a continuation of Barry Haanstra (haanstra.eu)'s PuTTYTray

PuTTYTray

This branch contains an attempt to re-ignite PuTTYTray on PuTTY 0.68 or higher.

Project status

The project has fallen behind PuTTY upstream, and shouldn't be used for now. Please use upstream PuTTY.

There is discussion of the project status on github issues.

The previously released binaries are built from the latest PuTTYTray tag.

Branches:

• upstream: the actual upstream branch we're tracking (master)
• upclean: an automatically cleaned-up variant of the branch
• scripts: orphan branch carrying the scripts to generate upclean
• master: third attempt to reignite the project
• t67-failed-merge: a failed attempt to merge 0.68 and p0.67-t029
• t67-failed-patches: a failed attempt to make patches from p0.67-t029

I will rebase all branches. Please work from tags.

All branches are a mess. Do not use them. Do not look at them. Do not raise issues or pull requests about them.

Projects:

• proj: miscellaneous changes necessary to run a project (e.g. README)
• cmake: build system extensions to use cmake, could be merged
• url: support for clickable urls, url menu, etc.
• backport: pulling changes back from the next release
• zoom: increase font size with the mousewheel
• fatty: bundle agent and gen into putty.exe
• icon: tray icon and extra menu / actions
• import: transparent support for openssh key formats

cmake

mkdir -p doc && \
perl licence.pl && \
(cd charset && perl sbcsgen.pl) && \
./mkcmake.py > CMakeLists.txt

puttytray's Issues

Crash on behaviour page / custom icons not working

Opening the behaviour page will sometimes crash-to-desktop, and custom icons don't work. This appears to be much more prevalent on x64.

Duplicated code between uxstore.c and winstore.c's file_

It feels like much of the code in winstore.c's file_ functions is a duplicate of the code in uxstore.c, which is built in so has zero maintenance cost.

If so, it should be eliminated.

URL detection doesn't like closing brackets

URLs like:

http://en.wikipedia.org/wiki/Horse_(disambiguation)

open as:

http://en.wikipedia.org/wiki/Horse_(disambiguation

...which is obviously not the intention. Should put in a hack to work around this.

"Remote command" not sent for ADB connections

When using connection type=adb the "Remote command" set in Connection > SSH is not executed.

command line

If you start the original puttyTray version (from Barry Haanstra) from the command line it were directly sent to the tray.

With your version of puttyTray you need to set this in the options menu. It should be minimized per default as it were in the original version as I use it with command line params only.

From the command line view there is currently no difference between your PuttyTray and the normal PuTTy :)

Zoom allows selection of fonts that break link underlining

Ctrl+mousewheel zooming bumps the font size by one point in either direction. This allows selection of font sizes that some fonts aren't designed for, for example, Courier New at 15pt.

When this happens, the underlines for links appear at effectively random places on the screen, and don't redraw properly. Clicking links still works, however.

Need to either

• fix the underlining code to work even when the fonts are crazy, or
• fix the mousewheel zoom code to not select invalid font sizes

Documentation should describe how to use Sessions in File

Since the upstream documentation only describes sessions in the registry, it's not clear how Sessions in File works. The web site and wiki only currently list features. I was unable to find any documentation on how to use PuTTYTray-specific features.

Some things the documentation could cover:

• how to use sessions in file (used by default if no sessions, including Default, are defined in registry)
• where are sessions files stored
• how one can customize where session files are stored (if possible)
• how to migrate from registry-based sessions to file-based sessions

If someone would answer these questions here, I'll edit the wiki.

URL regex doesn't recognise important TLDs like .cat

Hovering URLs like http://nyan.cat/ and clicking take you to http://nyan.ca/ , as the .cat TLD isn't recognised.

TLD specific code should probably be removed anyway, due to the introduction of arbitrary TLDs.

Jump list doesn't work for me

anytime I clicked on an recent session in the jump list, a popup shows 'Unspecified error' appears

I'm using the "sessions from file" feature, is this the reason?

Auto select "Sessions from file"

I was just thinking about a nice usabaility improvement for people who use "Sessions from file". If there aren't any saved "Sessions from registry" but there are "Sessions from file". You can safely assume the user doesn't use the registry and therefore uses files so you could auto select the "Sessions from file" radio button. And save me a click ;)

.cat domain breaks link detection

The link detection doesn't work with .cat domains. For example, in the case of http://lol.cat/, it incorrectly detects it as http://lol.ca.

This also applies to some other sponsored top-level domains.

Crashes when clicking on a link

Open irssi and write "http://google.com" to the input line. Add spaces to the begin of the line as long as there is no space after URL.

PuttyTray will crash with message box saying:
PuTTY Fatal Error:
line==NULL in terminal.c
lineno=5919 y=39 w=128 h=39
count(scrollback=0000000001CDF5F0)=0
count(screen=0000000001CDFD10)=39
count(alt=0000000001CDFD50)=39 alt_sblines=14
whichtree=0000000001CDFD10 treeindex=39

FuTTY Develpoment snapshot 2011-04-22:r45 is also affected to this bug.

Tested with

• 64 bit release & Win7
• Putty Tray Release p0.62-t010j

Custom Plink that uses file storage

Let me start by saying I'm more than happy w/ PuttyTray. I'm trying to streamline the use of SSH in Windows to just to the putty family of tools. Unfortunately for Git I'm using Plink so that Paegent can handle the keys for me. This works fine if I store sessions in the registry and pass the session name as host. My file stored session names it knows nothing about. I was wondering if anyone dealt with this before or how much work it would be to get this added to PuttyTray. Thanks again.

intorptr and x64

While debugging gh-29, we found the wonderful:

union { void *p; int i; } intorptr;

I don't even want to think what that's doing to the heap.

Unicode breaks link detection

I hope this comes through the internet fine...

If you type something like this:
(　 ﾟ,_ゝﾟ) http://google.fi

It will get the start of the link incorrectly and clicking it will go to http://google.f
And the Problem will be for all links after the unicode string as long as it's on screen.
And adding multiple problematic characters will shift it further, so next it will try to go to: ) http://google.

blinking icon on bell becomes transparents after opening puttytray

I have set puttytray to be only shown as minimized in the tray area.
When a bell is sent (screen + irssi) to putty tray, the icon blinks in the tray area, but if i click to open during a non-icon period (blinking is icon/non-icon), then on minimize the icon is transparent, thus no icon is shown but an empty area.

Unicodes in URLs apparently get mangled

A link like http://en.wikipedia.org/wiki/Human–animal_marriage (with an en/emdash) opens as http://en.wikipedia.org/wiki/Human%13animal_marriage, instead of the expected http://en.wikipedia.org/wiki/Human%E2%80%93animal_marriage

Proper feedback for hostname not being specified

Currently trying to "run" a session without a hostname specified will just beep and refuse to continue.

Some kind of proper feedback (MessageBox / focus flashing / ...) would be less confusing.

Don't honour resizing during win+left, as old PuTTY

Legacy versions of PuTTY used to not resize when moved around the screen / between screens with hotkeys like win+left, like cmd does on Seven. This behaviour has been fixed.

Sebastian Salman would like to be able to turn off this fix, such that the window doesn't resize and just moves around.

"Window -> Behaviour" config page causes crash

PuTTYTray crashes when trying to view the Window -> Behaviour config page. This apparently only happens if the putty.hlp file (from the original putty installation) is present in the same directory.

Auto reconnect Delay

My machine takes 5 or so seconds to bring the NIC up when coming out of sleep. As a result, the Auto reconnect function gives me a host not found error and aborts the connection, closing the window.

Two suggestions:

1. Include a delay (or a retry for 5 seconds?)
2. Leave the window open if the reconnect fails

Default Settings from file

Hi all.

Using Windows 8 (latest preview) and the latest version of PuTTY tray.

The only way I seem to be able to get PuTTY tray to default to using files instead of registry settings, is to delete all sessions from the registry.

Once this is done, it defaults to using files and works fine for saved sessions, but the "Default Settings" entry doesn't work - in other words it defaults to the hard coded defaults instead.

In order to use the default settings saved as a file, I have to manually load it each time.

If I save the file default settings to the registry, it works again of course, but then PuTTY tray defaults to using the registry again, and I have to click "use files" each time I want to load something which isn't in the jumplist.

I think the fact that "Default Settings" doesn't work from a file counts as a bug - if not a feature request. Although I guess it could be a Windows 8 thing.

Does anyone know of a work around for this issue?

Cheers.

Enabling tray icon mid-session creates a transparent icon

If a session is configured to never show tray icons, and this is changed to normal, an entirely transparent icon will be added to the system tray.

The icon should not be transparent.

Doesn't save SSH Host Keys into SshHostKeys

Previous version of PuTTYTray saved ssh host keys into SshHostKeys next to Sessions folder. This was a great feature for syncing across multiple computers using Dropbox. Instead, SSH host key is placed into the registry which breaks the "don't leave a footprint" ideal that some people may desire.

Minimize to tray setting gone.

Hello,

I'm sure it was there in a previous version, but now I can't find the setting anymore where you can configure the send to tray behavior (never, always, with ctrl+click).

Version 0.62-t009 on Win7 64bit.

Best regards.

Default settings don't get read on startup

If you modify the default settings, they don't get read when opening PuTTYTray. Selecting "Default Settings" and clicking Load works more or less as expected it seems.

adb-terminal

What's the chance of getting the adb-terminal functionality added from https://github.com/sztupy/adbputty/ ?

Hideous rendering of Consolas Underlined Bold

Related to issue #9, similar problem also is happening on underlined bold font. I'm not sure how to fix it though (also happens in original PuTTY).

Move all the settings onto the same config page

Having "show tray icon on" "Connection" is lunacy.

update codebase to 0.62

0.62 is a security update
http://lists.tartarus.org/pipermail/putty-announce/2011/000017.html

Serial connections result in "Invalid Port Number"

PuTTY Portable 0.62 (2012-01-05 update)
PuTTY Tray p0.62 - t006
Windows 7 Professional 64-bit (Japanese)

The PUTTY.EXE file included with PuTTY Portable was overwritten to use PUTTY.EXE from PuTTY Tray.
Saved configurations (SSH and Telnet) work except for serial-type connections.

These serial-type configurations work with the PUTTY.EXE that originally came with PuTTY Portable but it does not work with the PUTTY.EXE from PuTTY Tray. Verified that the serial ports being used are available.

Old regex code

The shipped regex library is a fork of a fork of a horrendously old version of TCL.

Need to re-steal the code from TCL into a new regex library. (This would probably actually be universally useful.)

Pageant & Icon

I realize this request is largely insignificant, but it should also be very easy... Would it be possible to compile/make distributable a version of pageant with the custom icon that was designed to match Puttytray (original)?

v011 broke ADB

The recent v011 update actually broke ADB support, I guess due to #38
What happens when I connect to any adb device is that it just echos "OKAY" and then just sits there. Only when I enter "0006shell:" manually I get a shell.
v010 used to open a shell straight away and that also makes a lot more sense.

Redraw issues with aerosnap

When using aerosnap keys like win+shift+left to move windows between screens of different proportions, PuTTY will occasionally fail to redraw properly:

Probably an upstream issue, also probably easy to fix.

documentation

please document the extra features and place a documentation menu to header on the puttytray's site.

and i 'd like to ask you what is this "Minimizing to the system tray (on CTRL + minimize" because my windows always get minimized to the tray without pressing any ctrl key.

thank you.

Middle-click new-session on taskbar button only works while pinned

When PuTTYTray is pinned, middle-clicking its icon brings up the new session dialog.

When not pinned, middle-clicking apparently does nothing. cmd.exe acts the same whether pinned or not.

Puttycyg

Any chance you could integrate puttycyg for local cygwin installations?

http://code.google.com/p/puttycyg/

PuTTYTray as Replacement for Windows CMD?

Got a feature request:

What about using PuTTYTray as a Replacement for the Windows Commandline.

I know that there are serveral Applications that replace the Windows CMD but would be good if that is included in PuTTYTray.

Adb putty enhancement - support for multi-devices

The original adb putty doesn't support for multi-devices, because any string after ':' are recognized as port number by putty, so that even if "transport:" is specified, only "transport" is forwarded to adb_init().

So I changed adb.c a little to make it work.

here is the code snip used to replace original part in adb_init()

    /* send initial data to adb server */
#define ADB_SHELL_DEFAULT_STR "0012" "host:transport-usb"
#define ADB_SHELL_DEFAULT_STR_LEN (sizeof(ADB_SHELL_DEFAULT_STR)-1)
#define ADB_SHELL_SERIAL_PREFIX "host:transport:"
#define ADB_SHELL_SERIAL_PREFIX_LEN (sizeof(ADB_SHELL_SERIAL_PREFIX)-1)
    do {
        size_t len = strlen(host);
        if (len == 0) {
            sk_write(adb->s, ADB_SHELL_DEFAULT_STR, ADB_SHELL_DEFAULT_STR_LEN);
        } else {
#define ADB_SHELL_HOST_MAX_LEN (sizeof(sendbuf)-4-ADB_SHELL_SERIAL_PREFIX_LEN-1)
            if (len > ADB_SHELL_HOST_MAX_LEN)
                len = ADB_SHELL_HOST_MAX_LEN;
            sprintf(sendbuf,"%04x" ADB_SHELL_SERIAL_PREFIX, len+ADB_SHELL_SERIAL_PREFIX_LEN);
            /* memcpy used here because I don't want to use snprintf */
            memcpy(sendbuf+4+ADB_SHELL_SERIAL_PREFIX_LEN, host, len);
            sk_write(adb->s,sendbuf,len+4+ADB_SHELL_SERIAL_PREFIX_LEN);
        }
    } while (0);

_After applying with this patch, one can open adb shell over a specific device by inputing the device ID listed out by "adb devices" into the "Host Name" (Where you may want to change it to "Device ID" when adb is selected)._

_To open the default device (when only 1 device connected), just input a ':' into "Host Name"_

TODO List:

1. Change "Host Name" to "Device ID" when adb mode is selected.
2. Allow for blank "Host Name" field when adb mode is selected. (So that ':' is not needed any more)
3. Add a button to list all devices when adb mode is selected. Adb can be moved to last one, and the button can be placed right after it.
4. An adb Settings Page in 'Connection', to allow for connecting using other commands rather than "adb shell".

BTW,
I'm willing to accomplish those in TODO list by myself, so could you give me write access to this or simple instructions for how to commit here? I'm quite unfamiliar with github.

No-longer builds on non-Windows

Some of the changes break compilation on at least Linux (Debian x64).

PuTTyTray/unix% git describe
p0.61-t003-2-gfca5cbc

/PuTTyTray/unix% make
gcc  -g -O2 -Wall -Werror  -DHAVE_CONFIG_H -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I.././ -I../charset/ -I../windows/ -I../windows/re_lib/ -I../unix/ -I../macosx/  -c ../be_all_s.c
In file included from ../be_all_s.c:7:
../putty.h:719: error: âMAX_PATHâ undeclared here (not in a function)
make: *** [be_all_s.o] Error 1

Even if the functionality isn't going to be enabled on non-Windows, the source tree should still compile on all the original platforms.

Optional? warning for overwriting configs

A user was complaining that they'd forgotten to load their config before saving it.

The new config has just the setting they were trying to save, not any of the previous settings they had (including hostname: #53).

Perhaps we should prompt the user to warn them that they're about to lose stuff they didn't explicitly unset by doing this save? Or that the config they're saving over isn't the one they loaded from (presuming they loaded from Default by default)?

Probably easier once Default Settings is actually well defined across both registry and files.

Investigate the options for tab support

People like tabs. I even use tabs on non-PuTTY OSes.

Various non-in-tree solutions exist for this, e.g. https://sites.google.com/site/macdsite/utilidades/puttytabmanager

Work out what's necessary to fix it properly.

Apparently ctrl+tab and ctrl+shift+tab don't send anything

http://scnr.net/blog/index.php/archives/61

diff -u -r putty-src.orig\WINDOWS\WINDOW.C putty\WINDOWS\WINDOW.C
--- putty-src.orig\WINDOWS\WINDOW.C Sun Feb 25 00:50:24 2007
+++ putty\WINDOWS\WINDOW.C  Fri Apr 10 15:24:54 2009
@@ -3979,6 +3979,14 @@
        *p++ = 0;
        return -2;
    }
+   if (wParam == VK_TAB && shift_state == 2) { /* Ctrl-Tab */
+       p += sprintf((char *) p, "\x1B[27;5;9~");
+       return p - output;
+   }
+   if (wParam == VK_TAB && shift_state == 3) { /* Ctrl-Shift-Tab */
+       p += sprintf((char *) p, "\x1B[27;6;9~");
+       return p - output;
+   }
    if (wParam == VK_TAB && shift_state == 1) { /* Shift tab */
        *p++ = 0x1B;
        *p++ = '[';

bindkey "^[[27;5;9~" next               # Ctrl-Tab
bindkey "^[[27;6;9~" prev               # Ctrl-Shift-Tab

crash on load session

Crashes when I load session, enter new ip adress, and then try to swich to "behaviour" tab

Sometimes it crashes, sometimes not. 70/30
Cant actually give you more info

Имя события проблемы: APPCRASH
Имя приложения: PUTTYP.EXE
Версия приложения: 0.62.9.0
Отметка времени приложения: 4f624499
Имя модуля с ошибкой: PUTTYP.EXE
Версия модуля с ошибкой: 0.62.9.0
Отметка времени модуля с ошибкой: 4f624499
Код исключения: c0000005
Смещение исключения: 0004e3b0
Версия ОС: 6.1.7601.2.1.0.256.1
Код языка: 1049
Дополнительные сведения 1: 0a9e
Дополнительные сведения 2: 0a9e372d3b4ad19135b953a78882e789
Дополнительные сведения 3: 0a9e
Дополнительные сведения 4: 0a9e372d3b4ad19135b953a78882e789

Pageant support for key confirmation

Like OpenSSH's ssh-add -c option:

"Indicates that added identities should be subject to confirmation before being used for authentication. Confirmation is performed by the SSH_ASKPASS program mentioned below. Successful confirmation is signaled by a zero exit status from the SSH_ASKPASS program, rather than text entered into the requester."

Basically, whenever a process requests authentication from pageant for an identity marked as "confirm", it should prompt the user to allow / deny the authentication before proceeding. This is mostly relevant in a setting where agent forwarding is being used, since anyone on the remote machine with access to the agent socket can potentially access unlocked identities. Enabling confirmation prompts mitigates this risk significantly, since the user can deny any unexpected requests (and will be alerted to suspicious activity at the same time).

Note that the user does not have to enter his passphrase if the identity is still unlocked, he simply has to confirm that the authentication is allowed to take place.

This is, in my opinion, an important feature to have in an agent program, the absence of which is limiting my use of pageant significantly (i.e. I'm removing keys from pageant all the time, only adding them right before I need them and removing them immediately after).

ADB USB

Is ADB over USB featured?

Will it be featured?

Version numbers / about dialog

The about dialog needs to be changed to show:

• The git tag version
• This PuTTyTray's homepage
• The PuTTy homepage, and a description of what's happening

History dropdown for host field request

The field for the host or IP to connect to is currently a dumb text box. I propose that it should maintain a drop-down history of previous hosts, filtered on the typed input.

My common workflow with PuTTY is to load a profile with the generic settings I want to be in effect, and then connect to one out of a few dozen machines by typing in user@fqdn in the host field. In most of the cases, the host to connect to would be uniquely identified by just the user, or the user and a short prefix of the host.

The proposed drop-down would make this a much nicer experience.

Raise on activity

Trond Erik Kvam would like a feature named "activate window on activity" that will cause PuTTYTray to activate / raise / come to front when data is received and somethings happens on the server-side.