failure: MSB4223: A node of the required type InProc could not be created.

[jeffkl]

failure: MSB4223: A node of the required type InProc could not be created.

[japj]

@jeffkl I will have a look at upgrading the package tomorrow and report the status to confirm.

[japj]

The stacktrace of the failure is:

       Test method xxx threw exception: 
       Microsoft.Build.Exceptions.BuildAbortedException: Build was canceled. A node of the required type InProc could not be created.

      Stack Trace: 
        BuildManager.PerformSchedulingActions(IEnumerable`1 responses)
        BuildManager.HandleNewRequest(Int32 node, BuildRequestBlocker blocker)
        BuildManager.ProcessPacket(Int32 node, INodePacket packet)
        INodePacketHandler.PacketReceived>b__0()
        BuildManager.ProcessWorkQueue(Action action)
        --- End of stack trace from previous location where exception was thrown ---
        BuildManager.EndBuild()
        BuildManagerHost.Build(BuildRequestData buildRequestData, IEnumerable`1 loggers)
        BuildManagerHost.Build(ProjectInstance projectInstance, String[] targets, IDictionary`2 globalProperties, IEnumerable`1 loggers, BuildRequestDataFlags buildRequestDataFlags)
        ProjectCreator.Build(Boolean restore, String[] targets, IDictionary`2 globalProperties, BuildOutput buildOutput, Boolean& result, IDictionary`2& targetOutputs)
        ProjectCreator.TryBuild(Boolean restore, String target, IDictionary`2 globalProperties, Boolean& result, BuildOutput& buildOutput)
        ProjectCreator.TryBuild(String target, IDictionary`2 globalProperties, Boolean& result, BuildOutput& buildOutput)
        ProjectCreator.TryBuild(String target, Boolean& result, BuildOutput& buildOutput)
        .....

[jeffkl]

I'm seeing similar errors myself:

https://dev.azure.com/dnceng/public/_build/results?buildId=1340250&view=ms.vss-test-web.build-test-results-tab&runId=39263738&resultId=100008&paneView=debug

But am unable to repro in this project to figure out what's going on. Are you able to test a workaround easily? In my testing, setting an environment variable fixes the issue. But I want to be sure before I update the code. Can you try setting:

MSBUILDNOINPROCNODE=1

So your unit test you can add this to see if it works:

Environment.SetEnvironmentVariable("MSBUILDNOINPROCNODE", "1");

That seems to work for me in the MSBuildSdks repo.

[japj]

I’ll be able to try the workaround after the weekend, will update you once I know more

[japj]

Now I get an error SolutionOne.sln(2,1): error MSB4025: The project file could not be loaded. Data at the root level is invalid. Line 2, position 1. [SolutionOne.sln]

This solution is a hardcoded sln file in the testcase:

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 16
VisualStudioVersion = 16.0.29102.190
MinimumVisualStudioVersion = 10.0.40219.1
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ProjectOne", "ProjectOne\ProjectOne.csproj", "{9B189FD2-59BE-4327-97D8-3170AF70C02F}"
EndProject
Global
	GlobalSection(SolutionConfigurationPlatforms) = preSolution
		Debug|Win32 = Debug|Win32
		Release|Win32 = Release|Win32
	EndGlobalSection
	GlobalSection(ProjectConfigurationPlatforms) = postSolution
		{9B189FD2-59BE-4327-97D8-3170AF70C02F}.Debug|Win32.ActiveCfg = Debug|x86
		{9B189FD2-59BE-4327-97D8-3170AF70C02F}.Debug|Win32.Build.0 = Debug|x86
		{9B189FD2-59BE-4327-97D8-3170AF70C02F}.Release|Win32.ActiveCfg = Release|x86
		{9B189FD2-59BE-4327-97D8-3170AF70C02F}.Release|Win32.Build.0 = Release|x86
	EndGlobalSection
	GlobalSection(SolutionProperties) = preSolution
		HideSolutionNode = FALSE
	EndGlobalSection
	GlobalSection(ExtensibilityGlobals) = postSolution
		SolutionGuid = {471DDE0F-A01E-4350-B423-6599E9FF7639}
	EndGlobalSection
EndGlobal

This worked fine previously (but please note that I am also upgrading from Visual Studio 2019 16.9 to 16.11).

Opening the solution from VisualStudio 2019 itself is ok, and running through MSBuild (commandline) also seems to work ok

[jeffkl]

@japj Looks like there's a bug in MSBuild somewhere, its been reported here: dotnet/msbuild#6818

Seems like only building a solution is affected.

[japj]

Ok, good to know thanks!

[jeffkl]

@japj That was closed as a duplicate of dotnet/msbuild#3517, can you try the workaround from it?

SET MSBUILD_PROJECTINSTANCE_TRANSLATION_MODE=Full

[japj]

I get a full "hangup" during the test run.

Manually running msbuild on the solution with both MSBUILDNOINPROCNODE and MSBUILD_PROJECTINSTANCE_TRANSLATION_MODE works ok

However it fails during the tests. Could it be that /nodemode:1 is causing an interaction issue (I saw the tests seem to spawn msbuild with this argument next to /nodeReuse:false /low:false)

[japj]

@jeffkl an addition to my previous comment: the tests seem to hang from VisualStudio on my laptop, but seem to work fine running through vstest on the buildserver, so I don't know what might be causing that

This is with the following added in the test code:

Environment.SetEnvironmentVariable("MSBUILDNOINPROCNODE", "1");
Environment.SetEnvironmentVariable("MSBUILD_PROJECTINSTANCE_TRANSLATION_MODE", "Full");

[jeffkl]

Okay I think I'll release a new version with these env vars set and I'll set MaxNodeCount to processor count. Maybe that will fix the hang you're seeing locally.

[japj]

That sounds like a good plan!

[KirillOsenkov]

I'm not convinced setting those two variables will fix things:
dotnet/msbuild#3517 (comment)

It just crashes for me. Something weird is going on.

[jeffkl]

Yeah I'm not able to get it working locally yet. I'm still playing around with coming up with a combination of tricks to make it work.

I need to build out-of-proc because my API depends on NuGet and MSBuild is going to load its own copy. Out-of-proc builds completely solves that (if I can get it to work)