TryBuild restore: true and using projectCollection causes Build to be not isolated from "Restore"?

[jeffkl]

TryBuild restore: true and using projectCollection causes Build to be not isolated from "Restore"?

[japj]

I am also noting some other weird errors that might indicate that using projectCollection global properties does not seem to work.

[japj]

I tested 6.3.1, 6.3.0 and 6.2.4 and it seems the global properties issue was introduced in 6.3.0 (6.2.4 works fine).

Perhaps 881f1f6 broke this behavior in some weird way?

[jeffkl]

Interesting, I'm surprised no unit test caught this. Let me see if I can add one that shows the broken behavior...

[jeffkl]

Alright the problem was caused by removing this:

47cb8d3#diff-e9c40f69d5dc156538cdc2b04b41e1d10d80faede62691b69838d3e46fb9b821L561

It used to pass null to Restore which would make a new global property collection. The new code takes the global property collection and modifies it so that the properties are now the same for restore and build which causes MSBuild to not re-evaluate the project.

I think it was a bug that Restore didn't use specified global properties for Restore so I'm going to just make a copy of the global properties for restore so they aren't modifying the set used for Build.

Thanks for reporting this!