binlog corrupt when build failed?

[jeffkl]

binlog corrupt when build failed?

[jeffkl]

Loggers aren't shutdown properly unless you dispose of the ProjectCollection. The code below creates a valid .binglog.

string binLogPath = Path.Combine(TestRootPath, "test.binlog");

bool result;
BuildOutput buildOutput;

using (ProjectCollection projectCollection = new ProjectCollection())
{
    projectCollection.RegisterLogger(new BinaryLogger
    {
        Parameters = $"LogFile={binLogPath}",
    });

    ProjectCreator.Create(
            projectCollection: projectCollection)
        .TaskError("Failed")
        .Save(GetTempFileName(".proj"))
        .TryBuild(out result, out buildOutput);
}

[japj]

It might be that the "corrupt" binlog is due to the error:

Microsoft.Build.Exceptions.InvalidProjectFileException: The SDK 'Sdk.props' specified could not be found

Perhaps MSBuild is throwing this error early/at a place where the binlog cannot be properly written.

And while writing this reply I just realized I mixed the ImportSdk name and project around, so that solves part of my problem.

It still means there is a "path" where the .binlog file cannot be written correctly/contains incomplete data.

[japj]

It might be that my "corrupt binlog" was actually a case of #48 , I will keep an eye out for this during new testcase development.

[jeffkl]

Assuming this is no longer a problem, please reopen if you see it again.