Comments (7)
Sorry I didn't realize how poorly documented that part of the API is. MSBuildProjectCreator cannot ship with MSBuild assemblies and neither can your application. You will need to have the MSBuild assemblies loaded at runtime.
You can do one of the following:
- If your class is a unit test, have it inherit from MSBuildTestBase to have things wired up correctly.
- Manually attach the assembly resolve event handler in MSBuildAssemblyResolver.
public static class MyApp
{
public static MyApp()
{
AppDomain.CurrentDomain.AssemblyResolve += MSBuildAssemblyResolver.AssemblyResolve;
}
}
- Use MSBuildLocator: https://github.com/Microsoft/MSBuildLocator
from msbuildprojectcreator.
Alright! I got it working now.
Both approaches solved the issue. But inheriting from MSBuildTestBase also removes some environment variables. That's not done in solution 2. Is it not strictly necessary? Or does it become more of an issue when setting it up in CI/CD or something?
from msbuildprojectcreator.
Great! Those environment variables are necessary if your projects end up using the .NET Core SDK and are set by MSBuildLocator as well.
from msbuildprojectcreator.
So, the reason the environment variables are removed in MSBuildTestBase is because the project might also be using MSBuildLocator, or the .NET Core SDK, which would interfere with MSBuildAssemblyResolver?
from msbuildprojectcreator.
There's some magic that will sort of automatically find these paths, and that magic is disabled if the environment variables are set.
The options are:
- Don't set them and rely on the entry point (dotnet.exe) to set them (this doesn't always work)
- Unset them and let the magic happen later (this seems to work much more reliably and is potentially future-proof)
- Set them explicitly after you've determined what their values should be (this means if the magic ever changes, you have to as well)
from msbuildprojectcreator.
I guess I'll go with 2 then :)
Thank you so much for the help! Much appreciated.
from msbuildprojectcreator.
Thanks for reporting this, I've opened #96 to track getting the documentation updated.
from msbuildprojectcreator.
Related Issues (18)
- Let devs add their own library dll and/or arbitrary file to a package
- failure: MSB4223: A node of the required type InProc could not be created. HOT 14
- TryBuild restore: true and using projectCollection causes Build to be not isolated from "Restore"? HOT 4
- Tests timing out with the MSBUILDNOINPROCNODE change HOT 6
- 'Build' target (and .nuget.g.props) not included in binlog?
- System.IO.FileLoadException: Could not load file or assembly NuGet.Frameworks, Version=6.2.0.146 HOT 8
- Could not load file or assembly 'NuGet.Frameworks, Version=6.2.1.7... HOT 6
- Referencing a local `.nupkg` HOT 2
- TryBuild fails on plain sdk project build HOT 5
- How to save a binlog for a build? HOT 6
- Collecting build output breaks user specified loggers
- binlog corrupt when build failed? HOT 4
- Question: generate solutions? HOT 1
- Tests requiring NuGetSdkResolver not working? HOT 5
- Restore project information is not present in the binlog HOT 3
- Question: How to use this for integration tests of a roslyn analyzer? HOT 7
- Document how to handle resolving MSBuild assemblies
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from msbuildprojectcreator.