Comments (6)
Looks like some others are hot on the trail as well: dotnet/roslyn#61454. The last suggestion to copy in the dll from the .NET SDK appears to be working so far. A bit hacky, but that's where are.
from msbuildprojectcreator.
Yeah it really is annoying that some other package is depending on NuGet.Frameworks and then since its considered a runtime dependency, the wrong version ends up next to your assembly. It sounds like the discussion on dotnet/roslyn#61454 is leaning towards removing that dependency which will help a lot.
Copying the assembly from the SDK is a pretty good workaround, I wonder if I should just build that into MSBuildProjectCreator?
from msbuildprojectcreator.
I'm not sure how I feel about that. Perhaps a simple "Known issues and workarounds" section in your docs might be good?
from msbuildprojectcreator.
@craigktreasure yeah that's probably a good idea at the very least. I wonder if I should add the workaround for all "unit test" projects which are probably pulling in the package that ends up referencing NuGet.Frameworks
. I know that I hit this every time there's a new release...
from msbuildprojectcreator.
Yea. I just don't know what other implications it might have with other dependencies. It's probably fairly safe, but in the case that it did cause a problem, it could be painful to figure out what has swapped out that dll.
from msbuildprojectcreator.
I believe this can be resolved as fixed now. Between the Roslyn change linked above and microsoft/vstest#4693, I think the usual references to NuGet.Frameworks have all been removed.
from msbuildprojectcreator.
Related Issues (20)
- Let devs add their own library dll and/or arbitrary file to a package
- failure: MSB4223: A node of the required type InProc could not be created. HOT 14
- TryBuild restore: true and using projectCollection causes Build to be not isolated from "Restore"? HOT 4
- Tests timing out with the MSBUILDNOINPROCNODE change HOT 6
- 'Build' target (and .nuget.g.props) not included in binlog?
- System.IO.FileLoadException: Could not load file or assembly NuGet.Frameworks, Version=6.2.0.146 HOT 8
- Referencing a local `.nupkg` HOT 2
- Rebuilding project fails with duplicate generated AssemblyInfo HOT 1
- Best practices for preferring local .nupkg HOT 8
- TryBuild fails on plain sdk project build HOT 5
- How to save a binlog for a build? HOT 6
- Collecting build output breaks user specified loggers
- binlog corrupt when build failed? HOT 4
- Question: generate solutions? HOT 1
- Tests requiring NuGetSdkResolver not working? HOT 5
- Restore project information is not present in the binlog HOT 3
- Question: How to use this for integration tests of a roslyn analyzer? HOT 7
- Creating new ProjectCreator throws FileNotFoundException HOT 7
- Document how to handle resolving MSBuild assemblies
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from msbuildprojectcreator.