Giter Site home page Giter Site logo

Comments (3)

maharjun avatar maharjun commented on May 24, 2024 1

I think a similar issue might be present in some of the other scoring functions that are coded manually in c (i.e. not via cython) e.g. sd.c. Please take a look at these cases.

AFAI can tell that behavior by numpy is extremely undocumented. I literally had to look at the source code to find out what was happenning. In-fact this API itself seems rather undocumented. All the documented APIs seem to require an integer type to be specified rather than a descriptor object.

from lightdock.

brianjimenez avatar brianjimenez commented on May 24, 2024

Thanks @maharjun for reporting this and for providing a solution! Indeed, this is something it was hidden during the tests execution and probably gone undetected for some time (I don't recall reading PyArray_AsCArray behavior on stealing descr reference, might be something added at some Numpy update?).

from lightdock.

brianjimenez avatar brianjimenez commented on May 24, 2024

Hi @maharjun , thanks again for your feedback. I've added your suggested patch to branch 0.9.2, including fixes for vdw and sd scoring functions. Please, let me know if it's working fine on your side.

from lightdock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.