Giter Site home page Giter Site logo

Comments (3)

res2k avatar res2k commented on July 28, 2024

I narrowed down the culprit to f6d2202.
It looks like actions were always forwarded/processed, just that they didn't have a (visible) effect.
I addressed by explicitly not producing a command when skipping a cinematic: #338

from q2rtx.

res2k avatar res2k commented on July 28, 2024

@apanteleev, there are two flavors of a fix:

  • 6cf8c04 - What I came up with, before being made aware of ...
  • 8afce9e, the fix for that in upstream.

Both do essentially the job, but it appears to me as if the "upstream" change is somewhat sensitive ("lightly tapping" skips the cinematic, but holding a key beyond that seems to trigger the action after all)... Maybe, if you have time, give both a try and let me know which behavior you prefer.

from q2rtx.

apanteleev avatar apanteleev commented on July 28, 2024

Thanks! I think the upstream solution is fine. I just cherry-picked it into master.

from q2rtx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.