Comments (10)
I believe it is a PSR standard from the beginning. But I believe we should follow every Symfony best practice for public bundles.
👍
from httplugbundle.
No, it is NOT PSR. Everyone believes that it is, but it isn't. It is an INTERNAL bylaw for the FIG, but thank god, it hasn't been standardized.
Symfony supports this Interface suffix practice in fact, but so far, I haven't been convinced that it is good, quite the opposite acually.
My most linked blog post by @mathiasverraes: http://verraes.net/2013/09/sensible-interfaces/
from httplugbundle.
No, it is NOT PSR. Everyone believes that it is, but it isn't. It is an INTERNAL bylaw for the FIG, but thank god, it hasn't been standardized.
Sorry, I miss-spoke. It is not a coding standard but as you say, PHP-fig apply Interface
and Trait
suffix and Abstract prefix.
Thank you for the link.
from httplugbundle.
not sure why fig is doing the suffixes. its indeed common throughout symfony, but in php-http we don't do it and i see the reasons not to do the suffixes. i don't mind much either way. we can change it if people think that is better.
from httplugbundle.
I don't insist on this one. If we decide to follow symfony standards, let's keep the suffix. If not, drop it.
from httplugbundle.
from httplugbundle.
I think it's more a matter of: should we be consistent for the dependencies, or on the organisation itself ?
For me i would like to keep the same rules across php-http packages, but i don't mind having Interface or not in the name, only detail to my eyes.
from httplugbundle.
@joelwurtz makes a great point. Lets be coherent with php-http.
from httplugbundle.
okay. who does the pull request?
from httplugbundle.
I will in the evening.
from httplugbundle.
Related Issues (20)
- Support for multiple mock clients HOT 4
- Client configuration is ignored for async client HOT 1
- Async request not visible in the profiler HOT 1
- Synfony 5 Support HOT 1
- Conflict with twig 3.0 / symfony 4.4 HOT 2
- Auto discovery broken in Symfony 4.4 ? HOT 4
- The httplug.collector.twig.http_message service is deprecated since version 1.17 HOT 5
- Collector not compatible with Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface HOT 9
- Xdebug nested issue HOT 1
- The data collector does not have reset tag HOT 1
- Can't test throwing an exception. Help needed
- 1.22 crash on cache clear in symfony 4.4 HOT 1
- Not allow null value for cache default_ttl HOT 6
- ErrorPlugin cannot be configured HOT 1
- The collector formatter needs to implement Http\Message\Formatter::formatResponseForRequest HOT 1
- [Profiler] No captured body (Symfony Client) HOT 4
- Switch from Http\Client\HttpClient to Psr\Http\Client\ClientInterface HOT 4
- Package php-http/message-factory is abandoned, you should avoid using it. Use psr/http-factory instead HOT 3
- Header authentication service configuration HOT 2
- Support Symfony 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from httplugbundle.