Giter Site home page Giter Site logo

carnd-advanced-lane-lines's People

Contributors

baumanab avatar brok-bucholtz avatar citlaligm avatar harveenchadha avatar mreichelt avatar mvirgo avatar ryan-keenan avatar sudkul avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

carnd-advanced-lane-lines's Issues

jupyter notebook (skeleton) needed.

Regarding the 1st project and how well structured it was, I think it will be more reasonable to add some kind of empty skeleton.
The skeleton shall only include some sort of steps as illustrated in the project videos, and each student shall start implementing those parts.

If this suggestion is not an option, then I think a little bit of info could be added to describe what are the best practice here.
The project could be implemented in one of the following:
-> multiple *.py files -->> which will not be easy for the reviewer
-> single jupyter file -->> which will make the review more easier

Operation speed problem

I don't know why. When I ran this project, I found it was very slow.

The video will take 24 minutes and 34 seconds. I don't know how fast you are.

Add spaces for GitHub Markdown

Currently the writeup_markdown.md breaks Markdown on GitHub. For example, all headers show the '###' signs instead of applying the format, and some newlines are missing:

broken layout

Jupyter notebook kernel is failing with `QWidget: Must construct a QApplication before a QPaintDevice`

When I try to run the first section of examples/example.ipynb on carnd-term1 conda environment, it fails with following error.

[I 14:01:03.123 NotebookApp] Serving notebooks from local directory: /Users/gaker/Workspace/Others/CarND-Advanced-Lane-Lines
[I 14:01:03.123 NotebookApp] The Jupyter Notebook is running at:
[I 14:01:03.124 NotebookApp] http://localhost:8888/?token=8da66d2f185b5337af86059e4efe532fa94b46fd88aff5d2
[I 14:01:03.124 NotebookApp] Use Control-C to stop this server and shut down all kernels (twice to skip confirmation).
[C 14:01:03.126 NotebookApp]

    Copy/paste this URL into your browser when you connect for the first time,
    to login with a token:
        http://localhost:8888/?token=8da66d2f185b5337af86059e4efe532fa94b46fd88aff5d2
[I 14:01:03.270 NotebookApp] Accepting one-time-token-authenticated connection from ::1
[I 14:01:09.374 NotebookApp] Kernel started: d2db0b04-0d06-4bf1-a96c-5fe6afe719a7
[I 14:01:09.895 NotebookApp] Adapting to protocol v5.1 for kernel d2db0b04-0d06-4bf1-a96c-5fe6afe719a7
objc[22985]: Class QCocoaColorPanelDelegate is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c180c0) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faede0). One of the two will be used. Which one is undefined.
objc[22985]: Class QMacSoundDelegate is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c18110) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faee30). One of the two will be used. Which one is undefined.
objc[22985]: Class QCocoaPanel is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c18160) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faeea8). One of the two will be used. Which one is undefined.
objc[22985]: Class QCocoaView is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c181b0) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faeed0). One of the two will be used. Which one is undefined.
objc[22985]: Class QCocoaWindow is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c18200) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faef48). One of the two will be used. Which one is undefined.
objc[22985]: Class QCocoaWindowDelegate is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c18250) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faef98). One of the two will be used. Which one is undefined.
objc[22985]: Class QCocoaMenuLoader is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c182a0) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faefe8). One of the two will be used. Which one is undefined.
objc[22985]: Class QNSApplication is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c182f0) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faf010). One of the two will be used. Which one is undefined.
objc[22985]: Class QCocoaApplicationDelegate is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c18340) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faf088). One of the two will be used. Which one is undefined.
objc[22985]: Class QCocoaWindowCustomThemeFrame is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c18390) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faf0d8). One of the two will be used. Which one is undefined.
objc[22985]: Class QCocoaToolBarDelegate is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c183e0) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faf128). One of the two will be used. Which one is undefined.
objc[22985]: Class QCocoaMenu is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c18430) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faf150). One of the two will be used. Which one is undefined.
objc[22985]: Class QNSOpenSavePanelDelegate is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c18480) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faf1a0). One of the two will be used. Which one is undefined.
objc[22985]: Class QCocoaFontPanelDelegate is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c184d0) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faf1f0). One of the two will be used. Which one is undefined.
objc[22985]: Class QNSWindowProxy is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c18598) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faf240). One of the two will be used. Which one is undefined.
objc[22985]: Class QNSPanelProxy is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c18548) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faf290). One of the two will be used. Which one is undefined.
objc[22985]: Class QCocoaPageLayoutDelegate is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c185c0) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faf2e0). One of the two will be used. Which one is undefined.
objc[22985]: Class QCocoaPrintPanelDelegate is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c18638) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faf330). One of the two will be used. Which one is undefined.
objc[22985]: Class QNSMenu is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c186d8) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faf420). One of the two will be used. Which one is undefined.
objc[22985]: Class QNSStatusItem is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c186b0) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faf3d0). One of the two will be used. Which one is undefined.
objc[22985]: Class QNSImageView is implemented in both /Users/gaker/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/cv2/.dylibs/QtGui (0x115c18660) and /Users/gaker/miniconda3/envs/carnd-term1/lib/libQtGui.4.8.7.dylib (0x128faf380). One of the two will be used. Which one is undefined.
QWidget: Must construct a QApplication before a QPaintDevice

The project doesn't have a license

Hi @ryan-keenan,
Notice that our project doesn't have license, that's a little unprofessional for a open source project, especially there has much extends adoption and development in an online education project. "No license terms" means users don't know it can be used freely. Another reference is Can I call my program "Open Source" even if I don't use an approved license?.

So here I suggest the project add license, recommend we choose one of the below license, firstly because they're all Permissive Licenses, but they have different redistribution disclaimer:

Regards,
Brandon

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.