Comments (8)
I snuck a small readme update in on my PR:
Lines 5 to 8 in 4663559
Is there more you want to say about it?
from freesurfer.
yeah I just want to be clear what will happen it people do
docker run -ti --rm bids/freesurfer
or
docker run -ti --rm bids/freesurfer:latest
from freesurfer.
OK that's I thought / feared:
we now have 2 repos on dockerhub with ugly names:
https://hub.docker.com/r/bids/freesurfer_fs7
https://hub.docker.com/r/bids/freesurfer_fs6
even worse the tags for fs6 mention version 7.4:
https://hub.docker.com/r/bids/freesurfer_fs6/tags
this is going to be super confusing
should we say that all images get pushed to https://hub.docker.com/r/bids/freesurfer
docker pull bids/freesurfer
and docker pull bids/freesurfer:latest
should be the same as
docker pull bids/freesurfer:v7.4.1
@Shotgunosine WDYT?
from freesurfer.
This seems fixable with some conditional logic in the deploy job. Where does ${CIRCLE_TAG}
come from?
docker pull bids/freesurfer and docker pull bids/freesurfer:latest should be the same as
docker pull bids/freesurfer:v7.4.1
I agree, docker pull bids/freesurfer:v6.0.1
and/or docker pull bids/freesufer:v6
should be required to get freesurfer 6. Though I suppose that could be suprising for people who currently docker pull bids/freesurfer
and expect to get freesurfer 6. Was the freesurfer bids app available that way? Should we have a deprecation warning period or something?
from freesurfer.
Are you able to see usage stats here: https://hub.docker.com/r/bids/freesurfer/tags? Is docker pull bids/freesurfer
still being run frequently? If so, I would keep freesurfer 6 as the default for now and leave 7 at the freesurfer:v7.4.1
tag. We could modify the run.py to add a message about freesurfer 7 availability?
from freesurfer.
don't have access to the frequency of the pulls. only the total number:
from freesurfer.
Where does
${CIRCLE_TAG}
come from?
this is the tag value you give to the tagged release :
https://github.com/bids-apps/freesurfer/releases/tag/v7.4.1
Should we have a deprecation warning period or something?
yes but for not more than 6 months - 1 year
We could modify the run.py to add a message about freesurfer 7 availability?
yes and also warning about the fact that "latest" will move to be freesurfer 7 "soon"
from freesurfer.
closed by #77
from freesurfer.
Related Issues (20)
- Docker build currently failing HOT 2
- Option to allow lower resolution T2s HOT 1
- Use Neurodocker HOT 3
- Freesurfer 7 version? HOT 14
- Parellelization HOT 10
- Introduce automated image builds HOT 14
- community standards HOT 26
- deploy failure HOT 1
- how template to fsaverage5?
- Minimal freesurfer image HOT 1
- Question about .annot file
- Possible to skip participants without aparc.stats files?
- Updating to current version of freesurfer HOT 4
- python dependency conflicts when trying to build the latest image HOT 2
- fix deploy dependencies HOT 1
- Seems that some tests for FS7 are failing because they hit the wall time? HOT 14
- [BUG] - docker tags are wrong in the README.md and run.py HOT 3
- Add a flag to ignore specific runs for some subjects HOT 1
- Adding the -notal-check flag HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from freesurfer.