Comments (14)
Persisting the image is taking too long it looks like. Might need to see if we can streamline the docker file.
from freesurfer.
Looks like the image
builds
but the workspace
for the tests
runs out. CI
suggests to use parallelism
for tests
. I have never done that, anyone has an idea how to implement this?
from freesurfer.
other option: we do not persist anything to the workspace and just only ever get stuff from the cache in the follow up steps?
from freesurfer.
Sorry, it's building the image that's taking 42 minutes. I'll try a large or x-large machine to see if that speeds things up. If that doesn't work. We could download freesurfer in a previous step and persist it, then copy it into the container instead of downloading it. That might speed up the bulid, but it'd require some editing of the dockerfiles.
from freesurfer.
we may want to check if switching to github action should be considered.
from freesurfer.
It's not clear to me why the Freesurfer 7 build is now taking half an hour. It was taking ~16 minutes on previous commits and I don't see any changes in the dockerfile in the mean time. @Remi-Gau switching over to github actions would be one option, but I don't have time to do an overhaul like that right now.
@PeerHerholz, I don't think the length of time it's taking to build is something that parallelism is likely to solve.
It looks like the large machine might just barely sneak through. If that fails I'll try an x-large machine and see if it goes any faster, but I think we might need to cache the freesurfer tar if we want to get a more reliable build time.
from freesurfer.
Something is indeed strange.
2 circle CI runs on the same commit:
- one fails: https://app.circleci.com/pipelines/github/bids-apps/freesurfer/111
- one passes: https://app.circleci.com/pipelines/github/bids-apps/freesurfer/106
from freesurfer.
from freesurfer.
I've fixed the build timeouts for now by skipping the cacheing step in #77.
The test timeouts are going to be a bit trickier and should be saved for a separate PR.
from freesurfer.
@Shotgunosine
If you are not going to work on it right now, I may PR something to make a push to main triggers a push of "unstable" tag version to docker hub.
See an example of another app here:
https://hub.docker.com/r/bids/antscorticalthickness/tags
This allows users to try the "bleeding" edge of the app.
from freesurfer.
Does this not already do that?
freesurfer/.circleci/config.yml
Lines 205 to 207 in 62eb276
from freesurfer.
ah yes sorry I missed that
But it seems that there is no deploy planned on this push to master
from freesurfer.
I suspect it is because we are ignoring deploys on all branches:
freesurfer/.circleci/config.yml
Line 274 in 62eb276
and we only do it on tags
from freesurfer.
from freesurfer.
Related Issues (20)
- Docker build currently failing HOT 2
- Option to allow lower resolution T2s HOT 1
- Use Neurodocker HOT 3
- Freesurfer 7 version? HOT 14
- Parellelization HOT 10
- Introduce automated image builds HOT 14
- community standards HOT 26
- deploy failure HOT 1
- how template to fsaverage5?
- Minimal freesurfer image HOT 1
- Question about .annot file
- Possible to skip participants without aparc.stats files?
- Updating to current version of freesurfer HOT 4
- python dependency conflicts when trying to build the latest image HOT 2
- update readme to reflect the availibility of both freesurder 6 and 7 HOT 8
- fix deploy dependencies HOT 1
- [BUG] - docker tags are wrong in the README.md and run.py HOT 3
- Add a flag to ignore specific runs for some subjects HOT 1
- Adding the -notal-check flag HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from freesurfer.