Giter Site home page Giter Site logo

Comments (3)

dalexeev avatar dalexeev commented on June 28, 2024 1

I'm not sure if any other kinds of errors can be out of bounds though.

In some cases, an error is possible on the line zero (if we did not provide a correct data) or on the EOF token, but the latter is probably fixed, since after #85488 the error is produced on the previous token. It is also possible that there is a bug in the tokenizer/parser.

So I think we could add a CLAMP on the Script Editor side. Note that we should not change the number in the error message (to fix the bug in GDScript), only for the red line marker. Say, if GDScript reports an error on line zero, then Script Editor displays the error message as is, but highlights the first line. What do you think about it?

from godot.

kitbdev avatar kitbdev commented on June 28, 2024

The error in the example now happens on a different line in bounds.
I'm not sure if any other kinds of errors can be out of bounds though.

from godot.

Calinou avatar Calinou commented on June 28, 2024

Say, if GDScript reports an error on line zero, then Script Editor displays the error message as is, but highlights the first line. What do you think about it?

Sounds good to me 🙂

Does the LSP specification allow reporting errors on line 0 though?

from godot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.