Giter Site home page Giter Site logo

webmastak / gnome-shell-extensions-mediaplayer Goto Github PK

View Code? Open in Web Editor NEW
376.0 25.0 106.0 6.4 MB

A mediaplayer indicator for GNOME Shell 3.18+.

Home Page: https://extensions.gnome.org/extension/55/media-player-indicator/

License: GNU General Public License v2.0

Shell 0.70% JavaScript 97.60% CSS 0.90% Meson 0.51% Python 0.29%
mpris gnome gnome-shell-extension javascript gjs linux

gnome-shell-extensions-mediaplayer's People

Contributors

aegypius avatar atomfrede avatar badcel avatar cybolic avatar dffischer avatar elder avatar eonpatapon avatar ficoos avatar frandieguez avatar frnogueira avatar gitter-badger avatar grawity avatar ibboard avatar jasonlg1979 avatar jdoe9910 avatar jiri-janousek avatar kingyes avatar lexruee avatar p91paul avatar ralgo avatar recursive-rat4 avatar ryuanlu avatar serdarsaglam avatar shlinux avatar shoden avatar smcv avatar tingvarsson avatar tiramiseb avatar to-ba avatar tommie-lie avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

gnome-shell-extensions-mediaplayer's Issues

Load covers from url

I use your plugin with spotify. Unfortunately it does not display the album covers, i suppose It's because the covers need to be loaded from a url. It would be cool if you would add support for this.

Huge Icons

I was messing around with gnome-shell themes earlier, and after going back to the defaults, the media player applet has huge icons for some reason. I'm not sure if switching themes is what caused it, but can you help me get it back to normal? I don't know what settings to look at, for starters.

Here's a (bad) screenshot. I can't get gnome-screenshot to take a proper screen, so I had to make do. http://imgur.com/blo6k

Improvement: Extend cover art

Clicking on cover art in extension would extend it, to give better view of image. Like, for example, quodlibet does.

Why?
Because in most cases it's nearly impossible to see, what's in image, because it's too small.

support gmusicbrowser

gmusicbrowser has support for mpdris and mpdris2

Names on session bus:
org.mpris.MediaPlayer2.gmusicbrowser
org.mpris.gmusicbrowser

please include! :)

Problems changing the location into Volume Menu

Hello Everyone,

Like a lot of people I love this extensions and I wish it was official on Gnome-shell and not just an extension but it is not my problem right now...

I have installed this extensions using the http://extensions.gnome.org website... the problem is, when I tried to change the icon (that is separate from the volume one) into the Volume Menu I fallow the wiki and do this :

gsettings set org.gnome.shell.extensions.mediaplayer volume true

But my terminal returns that there is no "org.gnome.shell.extensions.mediaplayer" scheme...

How can I solve this problem ?

Thanks in Advance,
Luis Da Costa

Support for gmusicbrowser

Would it be possible to add support for gmusicbrowser? It seems to have MPRIS plugins included.

Thanks. It's a fantastic extension.

Fix slider style

Sliders probably has hard-coded width, which is bad practice, especially in such place like gnome-shell, where probably anything could happen.

In this image it still does look OK, and you could dismiss that small amount of white space:

image

However, when you expand cover art (or some wide content appears in widget, which would cause it to expand) it looks way worse:

image2 :D (Oh, I'm so bad at giving titles to images)

Bug with timer

When you press pause the timer does not stop
The error appears on quodlibet and banshee

Foreground of labels: by and from

The foreground of the labels 'by' and 'from' are set in extension.js and not changeable by css:

    this.trackArtist = new Widget.TrackTitle('<span foreground="#ccc">' + _("by") +'</span> %s', 'track-artist');
    this.trackAlbum = new Widget.TrackTitle('<span foreground="#ccc">' + _("from") + '</span> %s', 'track-album');

with some lighter themes, these labels are hard to read - see marked area in screenshot (used theme is Zukitwo Cupertino).
http://imageshack.us/photo/my-images/823/mediaplayerq.jpg/

kind regards
manuel

Can't set the volume to 0 or 1 with the slider

When trying to set the volume to 0 or 1, JS send an int value even the value is cast to float with : parseFloat(value)
Since the dbus interface only accept double type (http://www.mpris.org/2.1/spec/Player_Node.html#Property:Volume) it doesn't work.

method call sender=:1.78 -> dest=org.mpris.MediaPlayer2.banshee serial=628 path=/org/mpris/MediaPlayer2; interface=org.freedesktop.DBus.Properties; member=Set
string "org.mpris.MediaPlayer2.Player"
string "Volume"
variant int32 0

With a value beetween 0 and 1, all is ok :

method call sender=:1.78 -> dest=org.mpris.MediaPlayer2.banshee serial=666 path=/org/mpris/MediaPlayer2; interface=org.freedesktop.DBus.Properties; member=Set
string "org.mpris.MediaPlayer2.Player"
string "Volume"
variant double 0.387754

Pithos support

Pithos is a native Pandora client for Linux ( http://kevinmehall.net/p/pithos/ ).

Because it's Pandora I don't think it would support seeking. However, when you add 'pithos' to the metadata.json in the non-seeking category, it works fine. This is good. This should probably be put in by default as it controls it nicely.

It can't do Pandora-specific features (obviously) like rating songs and changing stations. It would be fantastic if this extension somehow supported that, too, but it's not something I would really expect. Also, it doesn't pull cover art, but I don't know what that entails either.

In summary: This extension works with Pithos, and should have it enabled by default! Great work.

Add support for spotify-client-qt

Spotify Native client for Linux uses MPRIS2 and with unity is working well but with this extension the extension icon is not displayed.

Suspending and resuming duplicates entries

Suspending and resuming the system when a media player is running can result in two entries for it appearing on the sound menu. Each entry works fine, and controls the same instance of the media player. Even after the media player closes and re-opens, two entries appear again for it. Only a shell restart fixes the problem.

I have not been able to duplicate this problem every time I try it, but it does happen on occasion.

Apply a Fixed Width

When skipping songs using this extension, the button placement changes depending on the length of the artist name, album name, or song name. This makes it difficult to quickly skip multiple songs because one has to move the mouse to hover over the correct button each time. By applying a fixed width, this issue would not exist because the buttons would always be in the same place.

Exaile

Can you add exaile, please ?

Change label from "Volume" to "Media Volume"

I found the button writing confusing at first glance and suggest to change the label of the volume widget from "Volume" to "Media Volume".

Also, it would be nice to have the media name and icon open the application (like it does in Ubuntu).

One more thing, I think a "Mute" button is nice addition.

totem makes gnome-shell crash

I had to remove totem from metadata.jsou to be able to use totem. This is the error from xsession-errors:

(gnome-shell:28338): Clutter-WARNING **: Attempting to add actor of type 'StBoxLayout' to a container of type 'StBoxLayout', but the actor has already a parent of type 'StBoxLayout'.
Window manager warning: Buggy client sent a _NET_ACTIVE_WINDOW message with a timestamp of 0 for 0x1e0000b (Movie Play)
Window manager warning: meta_window_activate called by a pager with a 0 timestamp; the pager needs to be fixed.
JS ERROR: !!! Exception in callback for signal: destroy
JS ERROR: !!! message = '"No signal connection 4 found"'
JS ERROR: !!! lineNumber = '74'
JS ERROR: !!! fileName = '"/usr/share/gjs-1.0/signals.js"'
JS ERROR: !!! stack = '"_disconnect(4)@/usr/share/gjs-1.0/signals.js:74
([object Object])@/usr/share/gnome-shell/js/ui/popupMenu.js:1023
_emit("destroy")@/usr/share/gjs-1.0/signals.js:124
()@/usr/share/gnome-shell/js/ui/popupMenu.js:1133
("org.mpris.MediaPlayer2.totem",":1.71")@/usr/share/gnome-shell/extensions/[email protected]/extension.js:800
"'

St-ERROR *: st_widget_get_theme_node called on the widget [0x7fbdb4260620 StBoxLayout.track-box] which is not in the stage.
*
Message: applet now removed from the notification area
gnome-shell-calendar-server[28423]: Got HUP on stdin - exiting
gnome-session[28283]: WARNING: Application 'gnome-shell.desktop' killed by signal

Forked Extension

Hi, I'd just like you to know that I've made a fork of your extension. :)

I worked on it months before in my spare time, just because I wanted to learn more about Gnome Shell. I ported it to the new 3.2 framework a few days ago, and now I decided to try and release the source.

You can get it here: https://github.com/brianrobles204/Music-Integration
Major diffs:

  • each player has its own icon in the panel, instead of sharing one. Each player has more controls, including shuffle and repeat.
  • It has standard notifications, for all players. Good for those music players that don't take full advantage of GS's notification system.
  • Some more polish on the theme. Also, the track time only appears when you hover over the cover art.
  • Some bug fixes, notably the one where after enabling then disabling the extension, opening a new player will still make it appear in the extension.
    Sidenote: It can run alongside your extension, but there are stylesheet conflicts, so it won't look good.

I think some of these could be really useful; Hopefully we can merge some of the better features into one extension :)

Russian language

Contents ru.ro

msgid ""
msgstr ""
"Project-Id-Version: gnome-shell-extension-mediaplayer\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2011-08-28 20:02+0200\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: Aries-Soft Roman [email protected]\n"
"Language-Team: Aries-Soft Roman [email protected]\n"
"Language: Russian\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=utf-8\n"
"Content-Transfer-Encoding: 8bit\n"

. dummy vars for translation

: ../src/extension.js:87

msgid "Playing"
msgstr "Проигрывается"

: ../src/extension.js:88

msgid "Paused"
msgstr "Пауза"

: ../src/extension.js:89

msgid "Stopped"
msgstr "Остановлено"

: ../src/extension.js:342

msgid "Volume"
msgstr "Громкость"

: ../src/extension.js:386

msgid "Unknown Artist"
msgstr "Неизвестный артист"

: ../src/extension.js:390

msgid "Unknown Album"
msgstr "Неизвестный альбом"

: ../src/extension.js:394

msgid "Unknown Title"
msgstr "Неизвестный заголовок"

Can't build this

Hello,

I receive an error when I run make:

Making all in src
make[1]: Map '/home/jente/gnome-shell-extensions-mediaplayer/src' wordt binnengegaan
Makefile:423: *** ontbrekend scheidingsteken. Gestopt.
make[1]: Map '/home/jente/gnome-shell-extensions-mediaplayer/src' wordt verlaten
make: *** [all-recursive] Fout 1

It says it misses a "separation mark". Can you help me fix this? Thanks in advance!

Add support for Tomahawk

Would it be possible to add support for Tomahawk?

org.mpris.MediaPlayer2.tomahawk

Please let me know if you need any other information, I would be glad to help!

Support starting music player via D-Bus activation

MPRIS2 supports starting the music player via D-Bus activation. I'd love to have the music menu show up by default at the start of the session, and load my preferred music player on first use (when I first click on the menu).

Removes the volume icon

In some cases, the extension completely removes the volume icon when the last player is closed.

To reproduce:

  1. Start a player
  2. Enable the "Show in volume menu" option
  3. Disable the option
  4. Exit all players
  5. The extension removes its own icon and the volume icon.

Queue management

I use this extension with Quod Libet. I'd love to manage Quod Libet's queue directly from the music menu: display the contents of the queue, allow deleting or reordering items in it, allow switching to a song in it, allow toggling the "random" queue order, and (based on issue 55) allow adding new songs to it.

VLC is displayed twice

I'm not sure what else to say about this issue. When I play a file in VLC, VLC is listed twice in the indicator.

I am up-to-date with the released extension (as of May 2nd, 2012) and I'm running VLC 2.1.0-git:

VLC media player 2.1.0-git Rincewind (revision 1.3.0-git-1763-g38a4fd7)
VLC version 2.1.0-git Rincewind (1.3.0-git-1763-g38a4fd7)

No metadata displayed on start if player paused

If the extension is loaded while a player is already in the "Paused" state, the player is shown in the popup without any metadata. (For example: if I pause the player, then restart the shell via Alt-F2.)

The metadata appears only after clicking "Play", and remains displayed correctly when clicking "Pause" again.

Crash gnome-shell with spotify

When playing spotify and try to change the time/progress of the music, gnome-shell got crash.

Could you please disable this feature if spotify is playing?

dissapears on shell restart in 3.2

I'm not sure if it's a limitation of 3.2 or not but when you restart the shell it dissapears from the volume menu. Also I sent you an email regarding another issue.

Freezes in GNOME Shell

After every 3-5 minutes of work, I always get gnome-shell freezes with this extension activated. I can't do anything, even Alt+F2 doesn't work. That was happening in GNOME 3.0 too, and happens even with different graphics cards (Intel and NV).
My player is Banshee 2.2, Arch Linux kernel 3.0.4

extension help :-)

I have been using your extension fro a while now, and with great success, with the new shell updates and with the new standards that they are implementing, the extension will not load now with the error missing 'init' function

so i was looking around and added this to your code just to see if it will load. which it does!
unfortunatly i am not so up to speed with Java-scripts.

is it possible to to patch your extension using the new system?
big thanks for a great extension :-)
BB

function init() {
// do nothing here
}

function enable() {
// do nothing here
}

function disable() {
// do nothing here
}

No progress bar with mpdris2

Hi,

nice extension, thanks!

Not sure if I should raise this with mpdris2 or it is just not supported - I get no seek/progress bar with mpdris2, works fine with e.g. rhythmbox. Both mpdris2 and mediaplayer extensions latest git master.

Edit:
mpristester reports

Warning at property Position: Position (2208.00s) is 2.00s ahead of what was predicted from Rate (2206.00s)
Error at property MinimumRate: Property MinimumRate is missing
Error at property MaximumRate: Property MaximumRate is missing
Error at property Rate: Property Rate is missing

uncommenting the rate properties in /usr/bin/mpDris2 (using rate = 1) makes the progress bar in mediaplayer extension show up, but mpristester now shows outrageous offsets from the predicted position.
I guess you had your reasons for commenting it..

Closing as it is really a bug with mpDris2.

Extension doesn't work for Exaile

Sorry to sound like a n00b, but I warn you that I've been having weird things happen with my Fedora install (Dbus org.freedesktop.Notifications.service file wasn't even there). Fedora is functioning, but it's taking a lot of work just to get certain things working.

Anyways, on to the problem. When I click the Off -> On icon on the Gnome Extensions website for your extension, it pops up the usual Gnome3 dialog asking, "Do you want to download and install the extension?" I click "Install", and the dialog disappears as normal, but the icon never shows up in the notification bar, the extension doesn't show in the Volume icon (as per the Github readme), and the extension doesn't show up in the extension list on Advanced Settings (gnome-tweak-tool, not sure if the extension is supposed to show there). The extension shows as installed on the Gnome Extensions website however.

I am using Exaile. I have also tried running Banshee, and still nothing.

Is there logs somewhere? Or a way for me to manually install? Wait....ting! I forgot about simply compiling your extension. xD I'll try that, and keep you posted.

Oh, I'm on Fedora 16, just some extra info. :)

Edit: Figured out that Banshee didn't have the MPRIS framework extension loaded. Your extension works now.

I had MPRIS loaded on Exaile, but I found out it still doesn't have MPRIS2 support. :\

Either you're going to add MPRIS 1 support, or Exaile needs to update...this sucks.... oh well. lol.

Closed.

BAG

with a white window theme, the buttons are not visible, because of the confluence of colors

Little important improvements

I'm sorry if this is not an issue, but a feature request... :)

It would be great if:

  • there was a seeking bar to search in the song, or at least the total/passed/left time
  • it was possible to open the player window by a button or link in the extension

Thanks

Add support for xt7-player

if possible, he asked me to add xt7-player.

xt7-player has support for dbus

qdbus org.gambas.xt7.player /xt7

method QString org.freedesktop.Introspectable.Introspect()
method QDBusVariant org.freedesktop.DBus.Properties.Get(QString interface_name, QString property_name)
method QVariantMap org.freedesktop.DBus.Properties.GetAll(QString interface_name)
method void org.freedesktop.DBus.Properties.Set(QString interface_name, QString property_name, QDBusVariant value)
property readwrite QString org.gambas.xt7.player.dbusproperties.Album
property readwrite QString org.gambas.xt7.player.dbusproperties.Artist
property readwrite QString org.gambas.xt7.player.dbusproperties.AudioBitrate
property readwrite QString org.gambas.xt7.player.dbusproperties.AudioCodec
property readwrite QString org.gambas.xt7.player.dbusproperties.AudioRate
property readwrite QString org.gambas.xt7.player.dbusproperties.Author
property readwrite QString org.gambas.xt7.player.dbusproperties.Channels
property readwrite QString org.gambas.xt7.player.dbusproperties.Comment
property readwrite QString org.gambas.xt7.player.dbusproperties.Comments
property readwrite QString org.gambas.xt7.player.dbusproperties.CreationDate
property readwrite QString org.gambas.xt7.player.dbusproperties.FullPath
property readwrite QString org.gambas.xt7.player.dbusproperties.FullPathPlaying
property readwrite QString org.gambas.xt7.player.dbusproperties.Genre
property readwrite QString org.gambas.xt7.player.dbusproperties.Height
property readwrite QString org.gambas.xt7.player.dbusproperties.Length
property readwrite QString org.gambas.xt7.player.dbusproperties.MyYear
property readwrite QString org.gambas.xt7.player.dbusproperties.Name
property readwrite QString org.gambas.xt7.player.dbusproperties.Size
property readwrite QString org.gambas.xt7.player.dbusproperties.Title
property readwrite QString org.gambas.xt7.player.dbusproperties.TrackNo
property readwrite QString org.gambas.xt7.player.dbusproperties.Type
property readwrite QString org.gambas.xt7.player.dbusproperties.VideoBitrate
property readwrite QString org.gambas.xt7.player.dbusproperties.VideoCodec
property readwrite QString org.gambas.xt7.player.dbusproperties.VideoFps
property readwrite QString org.gambas.xt7.player.dbusproperties.VideoOutHeight
property readwrite QString org.gambas.xt7.player.dbusproperties.VideoOutWidth
property readwrite QString org.gambas.xt7.player.dbusproperties.Width
method void org.gambas.xt7.player.dbusproperties.Clear()
method void org.gambas.xt7.player.dbusproperties.doHideMain()
method void org.gambas.xt7.player.dbusproperties.doNext()
method void org.gambas.xt7.player.dbusproperties.doPrevious()
method void org.gambas.xt7.player.dbusproperties.doShowMain()
method void org.gambas.xt7.player.dbusproperties.doStop()
method void org.gambas.xt7.player.dbusproperties.doTogglePause()

ppa: https://launchpad.net/~eloaders/+archive/xt7-player
homepage: http://xt7-player.sourceforge.net/xt7forum/index.php

Feature to rate playing song

This is a great extension, very neat. The only thing it lacks of is ability to rate playing song. I use banshee but there is such feature in other media players too. Could you please add support for it?

Search bar to change song

I'd love to have a search bar I could use to switch songs: open the music menu, type (part of) a song name, get a short list of matches, select with up/down, press enter to switch to that song.

Need audacious support..

I can to add this, but its really other syntax (mpris [org.mpris.audacious]).

So, Anyone have a good idea for add this? Or need to re-write the plugin for special audacious?

Shell 3.3.90 - buttons too large

Using gnome-shell 3.3.90 and the latest extension from extensions.gnome.org, the playback control buttons are almost twice as large as they were in the stable version:

Screenshot

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.