loco-3d/whole_body_state_rviz_plugin

Rviz plugins to display whole-body states and trajectories

whole_body_state_rviz_plugin's Issues

Build error with console_bridge

I'm having an issue building the package. The error message is

Target "whole_body_state_rviz_plugin" links to target
"console_bridge::console_bridge" but the target was not found. Perhaps a
find_package() call is missing for an IMPORTED target, or an ALIAS target
is missing?

I have installed the console_bridge as if I tried sudo apt install libconsole-bridge-dev, it shows that libconsole-bridge-dev is already the newest version (0.4.4+dfsg-1build1).

Catkin make error

Hello!
I'm trying to build your project but have an errors during catkin_make.
My system is Ubuntu 20.04, ROS Noetic with installed Pinocchio using robotpkg.

The error:
/usr/include/OGRE/OgreAxisAlignedBox.h:722:21: error: implicitly-declared ‘constexpr Ogre::Vector3::Vector3(const Ogre::Vector3&)’ is deprecated [-Werror=deprecated-copy]
722 | return Vector3::ZERO;
| ^~~~
In file included from /usr/include/OGRE/OgreMatrix3.h:33,
from /usr/include/OGRE/OgreNode.h:34,
from /usr/include/OGRE/OgreSceneNode.h:33,
from /usr/include/OGRE/OgreSceneManager.h:37,
from /home/yoggi/ros_ws/src/whole_body_state_rviz_plugin/src/PolygonVisual.cpp:9:
/usr/include/OGRE/OgreVector3.h:134:25: note: because ‘Ogre::Vector3’ has user-provided ‘Ogre::Vector3& Ogre::Vector3::operator=(const Ogre::Vector3&)’
134 | inline Vector3& operator = ( const Vector3& rkVector )
| ^~~~~~~~
In file included from /usr/include/OGRE/OgreMesh.h:35,
from /usr/include/OGRE/OgreNode.h:40,
from /usr/include/OGRE/OgreSceneNode.h:33,
from /usr/include/OGRE/OgreSceneManager.h:37,
from /home/yoggi/ros_ws/src/whole_body_state_rviz_plugin/src/PolygonVisual.cpp:9:

Reemc wrong model

Hi WBS rviz-plugin developers,

First, I want to thank for your plugin. I would like to make an example documentation for Reemc; but unfortunately, when I add the plugin in rviz, it shows a wrong piece of the model instead of the right model of Reemc.

Is there a way how to fix this?

Any answer will be helpful.

Thanks in advance!

Improvement suggestions

• README.md recommend using catkin_tools (catkin build command) instead of the deprecated catkin_make.
• package.xml unspecified version. Verion 2 or 3 is now supported on all platforms.
• package.xml doesn't list pinocchio as a dependency. Check if the ROS binaries are working with the plugin.
• Use #pragma once instead of the #ifdef guard. All modern compilers support it now (GCC3.4+).
• Include a gif with example trajectory/state visualisation in the readme, it will attract more users.
• Consider writing some documentation with examples or linking them here if they are in another package.
• Since the code is compiled into a plugin, catkin_package() can be left empty in the cmakelist. The headers also don't need to be installed. This will prevent users accidentally linking against the plugin, which may cause problems.
• /** ... **/ type doxygen comments annotate the following line. The header files use these to describe a group of variables but only the first variable will contain the description. Either use the member groups feature or just switch them to regular comments.

The code is well structured and documented. Well done.