ros-visualization / rqt_reconfigure Goto Github PK

View Code? Open in Web Editor NEW

22.0 24.0 47.0 476 KB

Home Page: http://wiki.ros.org/rqt_reconfigure

License: Other

CMake 0.48% Python 99.52%

rqt_reconfigure's People

Contributors

Stargazers

Watchers

Forkers

kukanani nxdefiant cottsay progtologist prarobo snrkiwi uavteambyu yamokosk furushchev kinddragon tusimple eibow1012 130s loulansuiye easthuang1 haraisao henryymliu flova plusone-robotics softwareape ahcorde mikaelarguedas rolaechea sloretz augustinmanecy joaquinballesteros xbroquer shrijitsingh99 eidea-inc hliberacki nian47 tsungchent vutuandatam unibwtas continuum-uwr devarsirawal samerkhshiboun huemerj nlamprian mosfet80 christophebedard jonselling srmainwaring

rqt_reconfigure's Issues

Crash when value not in enum list

Example:

The pid package https://bitbucket.org/AndyZe/pid has an enum

...
K_scale_enum = gen.enum([ gen.const("scale_tenth", double_t, 0.1, "Scale by 0.1"),
                           gen.const("scale_unity",   double_t, 1.0, "No scaling"),
                           gen.const("scale_ten",  double_t, 10.0, "Scale by 10"),
                           gen.const("scale_hundred", double_t, 100.0, "Scale by 100")],
                           "Scale factor for K setting")

gen.add("Kp_scale", double_t, 0, "Kp scale", 10, 0.1, 100, edit_method = K_scale_enum)
...

If I ignore the fact it is an enum and set it to some other value the rqt plugin crashes:

roslaunch pid servo_sim.launch
rosrun dynamic_reconfigure dynparam set /left_wheel_pid Kp_scale 2.7

Then click on /left_wheel_pid in rqt_reconfigure:

  File "/opt/ros/kinetic/lib/python2.7/dist-packages/dynamic_reconfigure/client.py", line 271, in set_config_callback
    self._config_callback(self.config)
  File "/home/lucasw/tmp_catkin_ws/src/rqt_reconfigure/src/rqt_reconfigure/dynreconf_client_widget.py", line 113, in config_callback
    widget.update_value(config[widget.param_name])
  File "/home/lucasw/tmp_catkin_ws/src/rqt_reconfigure/src/rqt_reconfigure/param_editors.py", line 439, in update_value
    self._update_signal.emit(self.values.index(value))
ValueError: 2.7 is not in list

The obvious fix is to check self.values.index before doing this:

self._update_signal.emit(self.values.index(value))

It could find the nearest legitimate value and set it to that instead, or just reject it with a warning.
(and I can pr a fix later)

And perhaps dynamic reconfigure itself shouldn't have let me set that value in the first place.

Clearly see if the parameter value is different from the default value

It is very useful to be able to see if a parameter value has changed from it's default value.

This could be presented in the form of a filter; for example "display only parameters whose value currently matches the default" and/or "display only parameters whose value is different from the default value".

Or this could be simply be done by changing the background color of the parameter value or the font color.

New release containing python3 fixes

Since release 0.4.10, some changes regarding python3 compatibility have been made. It would be nice to have a python3 compatible release.

[ROS2] Listen for parameter events

When a parameter is changed externally (for example by using ros2 param set), the rqt_reconfigure does not update the values, unless the node is reselected. Similarly, the plugin does not react when a node declare a new parameter or undeclares one.

This can be easily improved by subscribing to the global /parameter_events topic, filtering the messages for only the selected nodes and updating the UI according to the events.

[ROS2] Tool does not list any nodes and params

After build and run the latest Dashing branch the GUI does not list any information at all. Is it a known issue?

What is the pending work to be done in order to have it working?
I'm open to contribute if you can give some directions how I could help...

Qt platform plugin "xcb"

Dear team,
I am getting the following error:

$ rosrun rqt_gui rqt_gui
This application failed to start because it could not find or load the Qt platform plugin "xcb".

Reinstalling the application may fix this problem.

Details:
Ubuntu 18.04 LTS x64
ROS Melodic

Issues with PyQt5

I'm on an Ubuntu 20.04 system with galactic binary of this package version 1.0.8-1focal.20220430.131618

Running ros2 run rqt_reconfigure rqt_reconfigure throws the following exception

Traceback (most recent call last):
  File "/opt/ros/galactic/lib/rqt_reconfigure/rqt_reconfigure", line 11, in <module>
    load_entry_point('rqt-reconfigure==1.0.8', 'console_scripts', 'rqt_reconfigure')()
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 490, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2854, in load_entry_point
    return ep.load()
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2445, in load
    return self.resolve()
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2451, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/opt/ros/galactic/lib/python3.8/site-packages/rqt_reconfigure/__main__.py", line 36, in <module>
    from rqt_reconfigure.param_plugin import ParamPlugin
  File "/opt/ros/galactic/lib/python3.8/site-packages/rqt_reconfigure/param_plugin.py", line 35, in <module>
    from rqt_gui_py.plugin import Plugin
  File "/opt/ros/galactic/lib/python3.8/site-packages/rqt_gui_py/plugin.py", line 33, in <module>
    from qt_gui.plugin import Plugin as Base
  File "/opt/ros/galactic/lib/python3.8/site-packages/qt_gui/plugin.py", line 31, in <module>
    from python_qt_binding.QtCore import QObject
  File "/opt/ros/galactic/lib/python3.8/site-packages/python_qt_binding/__init__.py", line 56, in <module>
    from python_qt_binding.binding_helper import loadUi  # noqa: F401
  File "/opt/ros/galactic/lib/python3.8/site-packages/python_qt_binding/binding_helper.py", line 277, in <module>
    _select_qt_binding(
  File "/opt/ros/galactic/lib/python3.8/site-packages/python_qt_binding/binding_helper.py", line 108, in _select_qt_binding
    QT_BINDING_VERSION = binding_loader(required_modules, optional_modules)
  File "/opt/ros/galactic/lib/python3.8/site-packages/python_qt_binding/binding_helper.py", line 155, in _load_pyqt
    _named_optional_import('PyQt5.%s' % module_name)
  File "/opt/ros/galactic/lib/python3.8/site-packages/python_qt_binding/binding_helper.py", line 142, in _named_optional_import
    _named_import(name)
  File "/opt/ros/galactic/lib/python3.8/site-packages/python_qt_binding/binding_helper.py", line 133, in _named_import
    module = builtins.__import__(name)
ValueError: PyCapsule_GetPointer called with incorrect name

From what I understand this is due to having a mismatch in the PyQt5 version on my system.
So I manually installed PyQt5-5.10.1 with python3 -m pip install PyQt5==5.10.1.

Then upon launching, I get this error below

Could not import "pyqt" bindings of qt_gui_cpp library - so C++ plugins will not be available:
Traceback (most recent call last):
  File "/opt/ros/galactic/lib/python3.8/site-packages/qt_gui_cpp/cpp_binding_helper.py", line 43, in <module>
    from . import libqt_gui_cpp_sip
ImportError: /home/yadu/.local/lib/python3.8/site-packages/PyQt5/Qt/lib/libQt5Core.so.5: version `Qt_5.12' not found (required by /opt/ros/galactic/lib/python3.8/site-packages/qt_gui_cpp/libqt_gui_cpp_sip.so)

Then I installed python3 -m pip install PyQt5==5.12 following the hint from the ImportError. But now I'm experiencing

RosPluginProvider.load(qt_gui_cpp/CppPluginProvider) exception raised in __builtin__.__import__(qt_gui_cpp.cpp_plugin_provider, [CppPluginProvider]):
Traceback (most recent call last):
  File "/opt/ros/galactic/lib/python3.8/site-packages/rqt_gui/ros_plugin_provider.py", line 80, in load
    module = __builtin__.__import__(
  File "/opt/ros/galactic/lib/python3.8/site-packages/qt_gui_cpp/cpp_plugin_provider.py", line 33, in <module>
    from .cpp_binding_helper import qt_gui_cpp
  File "/opt/ros/galactic/lib/python3.8/site-packages/qt_gui_cpp/cpp_binding_helper.py", line 43, in <module>
    from . import libqt_gui_cpp_sip
ValueError: PyCapsule_GetPointer called with incorrect name

RecursivePluginProvider.discover() loading plugin "qt_gui_cpp/CppPluginProvider" failed:
Traceback (most recent call last):
  File "/opt/ros/galactic/lib/python3.8/site-packages/qt_gui/recursive_plugin_provider.py", line 60, in discover
    instance = self._plugin_provider.load(plugin_descriptor.plugin_id(), None)
  File "/opt/ros/galactic/lib/python3.8/site-packages/rqt_gui/ros_plugin_provider.py", line 91, in load
    raise e
  File "/opt/ros/galactic/lib/python3.8/site-packages/rqt_gui/ros_plugin_provider.py", line 80, in load
    module = __builtin__.__import__(
  File "/opt/ros/galactic/lib/python3.8/site-packages/qt_gui_cpp/cpp_plugin_provider.py", line 33, in <module>
    from .cpp_binding_helper import qt_gui_cpp
  File "/opt/ros/galactic/lib/python3.8/site-packages/qt_gui_cpp/cpp_binding_helper.py", line 43, in <module>
    from . import libqt_gui_cpp_sip
ValueError: PyCapsule_GetPointer called with incorrect name

What am I missing?

rqt hangs when node previoulsy shown is stopped and clicked

See https://answers.ros.org/question/339142/rqt-freezes-when-opening-dynamic-reconfigure/

Release rqt_reconfigure to ROS Noetic?

Would you mind releasing rqt_reconfigure to ROS Noetic? It looks like all of its dependencies have been released, and recursively 21 repos need it.

I'm not sure how much work it will need. The Noetic Migration Guide or the guide about transitioning ROS packages to Python 3 may be useful.

Feature request: make the vector/list easier?

Hi,

I wonder if it's possible to support the type of cpp vector or python list? Currently, I'm using the string and parser to input those types, but it would be really helpful if rqt_reconfigure can support this type of input!

Thanks a lot!

Mouse wheel button unintuitively moves slide bar

Current behavior

As per title. The slide bar that has a focus moves, when a mouse's wheel rolls.

Expected behavior

I think it's more intuitive if the vertical scroll bar moves.

(I've seen my coworkers keep complaining, without filing a ticket.)

Version

$ apt-cache policy ros-indigo-rqt-reconfigure
ros-indigo-rqt-reconfigure:
  Installed: 0.4.10-0trusty-20181006-073800-0800
  Candidate: 0.4.10-0trusty-20181006-073800-0800
  Version table:
 *** 0.4.10-0trusty-20181006-073800-0800 0
        500 http://packages.ros.org/ros-shadow-fixed/ubuntu/ trusty/main amd64 Packages
        100 /var/lib/dpkg/status

rqt_reconfigure: the layout is pretty broken

From @dirk-thomas on August 16, 2013 22:10

left column takes all the space, right column has only minimum width, should be the other way around
the configuration block per node and vertically spread, should have spacing at the bottom
each edit row is horizontally spread, should make use of the full width instead
the row label is overlapping with the controls when the window is small

Copied from original issue: ros-visualization/rqt_common_plugins#150

New flake8 failure CNL100 Class definition does not have a new line

https://ci.ros2.org/job/nightly_linux_debug/1829

./src/rqt_reconfigure/param_api.py:46:1: CNL100 Class definition does not have a new line.
    def __init__(self, message='asynchronous service call failed', hint=''):
^

1     CNL100 Class definition does not have a new line.

Cannot get or set parameters with the type of PARAMETER_INTEGER_ARRAY

I have several parameters whose type are PARAMETER_INTEGER_ARRAY. It seems that rqt_reconfigure hasn't support this type yet, since I was trying to launch rqt_reconfigure, it failed with the following error messages:

Traceback (most recent call last):
File "/home/intel/workspace/ros2_other_ws/build/rqt_reconfigure/src/rqt_reconfigure/node_selector_widget.py", line 277, in _selection_changed_slot
self._selection_selected(index_current, rosnode_name_selected)
File "/home/intel/workspace/ros2_other_ws/build/rqt_reconfigure/src/rqt_reconfigure/node_selector_widget.py", line 228, in _selection_selected
raise e
File "/home/intel/workspace/ros2_other_ws/build/rqt_reconfigure/src/rqt_reconfigure/node_selector_widget.py", line 226, in _selection_selected
item_widget = item_child.get_param_client_widget()
File "/home/intel/workspace/ros2_other_ws/build/rqt_reconfigure/src/rqt_reconfigure/treenode_qstditem.py", line 94, in get_param_client_widget
self._context, self.raw_param_name
File "/home/intel/workspace/ros2_other_ws/build/rqt_reconfigure/src/rqt_reconfigure/param_client_widget.py", line 116, in init
self.param_client.get_parameters(param_names),
File "/home/intel/workspace/ros2_other_ws/build/rqt_reconfigure/src/rqt_reconfigure/param_api.py", line 89, in get_parameters
for name, value in zip(names, get_params_response.values)
File "/home/intel/workspace/ros2_other_ws/build/rqt_reconfigure/src/rqt_reconfigure/param_api.py", line 89, in
for name, value in zip(names, get_params_response.values)
File "/home/intel/workspace/ros2_ws/install/rclpy/lib/python3.6/site-packages/rclpy/parameter.py", line 121, in from_parameter_msg
return cls(param_msg.name, type, value)
File "/home/intel/workspace/ros2_ws/install/rclpy/lib/python3.6/site-packages/rclpy/parameter.py", line 132, in init
raise ValueError("Type '{}' and value '{}' do not agree".format(type, value))
ValueError: Type 'Type.INTEGER_ARRAY' and value 'array('q', [640, 480])' do not agree
[INFO] [PluginContainerWidget]: Connection to node=/realsense failed:
Type 'Type.INTEGER_ARRAY' and value 'array('q', [640, 480])' do not agree
[ERROR] [rqt_reconfigure]: Connection to node=/realsense failed:
Type 'Type.INTEGER_ARRAY' and value 'array('q', [640, 480])' do not agree

On the other hand, I was trying to get/set parameters by ros2 param. Everything works well.

$ros2 param set my_node my_param [640,480]
Set parameter successful
$ros2 param get my_node my_param
Integer values are: array('q', [640, 480])

rqt_reconfigure GUI not brought to the foreground

System information
OS: Ubuntu 18.04
ROS version: Melodic
RQT_gui version: 0.5.0
Dynamic_Reconfigure version: 1.6.0

Problem
When opening the dynamic_reconfigure GUI, some strange behaviour occurs (See image below). First of all, it opens not only the GUI window but also a smaller req_reconfigure__Param - rqt window. Second, this second window is set as the active window. As a result, when clicking the rqt_reconfigure icon in the taskbar, this small window is brought to the foreground instead of the actual dynamic_reconfigure window. To get the dynamic_reconfigure window, I have to minimise all my other windows.

What I tried

Using different launch commands
- <node pkg="rqt_gui" type="rqt_gui" name="dyn_reconf_gui" args="-s reconfigure" output="log"/>
- <node pkg="rqt_reconfigure" type="rqt_reconfigure" name="dyn_reconf_gui" output="log"/>
- rosrun rqt_gui rqt_gui -s reconfigure
- rosrun rqt_reconfigure rqt_reconfigure.

Pictures

ApplyGroup with subgroups: uncaught exception on any update

With a configuration where an apply group has a subgroup, cfg example:

mygroup = gen.add_group("MyGroup", type="apply")
mygroup.add("my_double_param", double_t, 0, "Some double param", 100,  0, 200)

subgroup = mygroup.add_group("MySubGroup")
subgroup.add("zzz_in_subgroup", int_t, 0, "some zzz key", 100,  0, 200)

Then with rqt_reconfigure gui launched:
When editing any parameter in the group or subgroup, the updater fails with an exception:

Traceback (most recent call last):
  File "xxx/rqt_reconfigure/src/rqt_reconfigure/param_editors.py", line 354, in _text_changed
    self._update_paramserver(float(self._paramval_lineEdit.text()))
  File "xxx/rqt_reconfigure/src/rqt_reconfigure/param_editors.py", line 99, in _update_paramserver
    self.update_configuration(value)
  File "xxx/rqt_reconfigure/src/rqt_reconfigure/param_editors.py", line 115, in update_configuration
    self._updater.update({self.param_name: value})
  File "xxx/rqt_reconfigure/src/rqt_reconfigure/param_groups.py", line 331, in update
    self.loopback(config)
  File "xxx/rqt_reconfigure/src/rqt_reconfigure/param_groups.py", line 244, in update_group
    widget.update_group(cfg)
  File "xxx/rqt_reconfigure/src/rqt_reconfigure/param_groups.py", line 228, in update_group
    if 'state' in config:
TypeError: argument of type 'NoneType' is not iterable

rqt_reconfigure does not display any parameters

When I execute "rosrun rqt_reconfigure rqt_reconfigure", the gui window pops up, but I see no parameters to change. Am I missing some installation or configuration to do this? This is what appears when I execute the command:

Cannot select any node if many nodes are running

Hi, I'm a user of PR2 and have a problem to set params with rqt_reconfigure.
When clicking any node in the tree view, the GUI often (really often!) hangs and goes black, and the only thing I can do is to reboot rqt_reconfigure node.

I can also see a lot of errors when this node is started like as follows:

Exception in thread Thread-114:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/home/furushchev/ros/kinetic/src/ros-visualization/rqt_reconfigure/src/rqt_reconfigure/treenode_qstditem.py", line 67, in run
    self._param_name_raw))
ROSException: timeout exceeded while waiting for service /kinect_head_external/rgb_rectify_mono/set_parametersTreenodeQstdItem. Couldn't connect to /kinect_head_external/rgb_rectify_mono

rqt_reconfigure) to be capable of showing only certain parameters

From @130s on March 19, 2013 7:29

In the cases where the users know that the parameters they need to interact with, loading the parameters of all available nodes might just drop the usability. Either or all of the following is useful:

Save the nodes selected in the previous run.
Allow the developers who make rqt plugin that depends on rqt_reconfigure to pre-select certain nodes

Particularly, I now start having an impression that the majority of the reconfigure users might already know which nodes & parameters they need.

Copied from original issue: ros-visualization/rqt_common_plugins#49

Clicking refresh freezes rqt

Opening rqt and then opening parameter reconfigure and hitting Refresh freezes whole rqt and it needs to be force shutdown.
Info: Ros2 Foxy, built by source. rqt_reconfigure dashing branch. Ubuntu 20.04.

Undefined variables in debug statement

In https://github.com/ros-visualization/rqt_reconfigure/blob/master/src/rqt_reconfigure/dynreconf_client_widget.py#L106, the variables name and v are used, even though they do not exist. This results in a NameError.

float parameter ranges not working in humble

I switched from galactic to humble and now get the error:

[WARN] [1653783508.027148631] [rqt_reconfigure]: Failed to retrieve parameters from node: setSingleStep(self, int): argument 1 has unexpected type 'float'

I can reproduce this with a float parameter:

rcl_interfaces::msg::ParameterDescriptor param_descr;
rcl_interfaces::msg::FloatingPointRange range_float;
range_float.from_value = 10;
range_float.to_value = 20;
param_descr.floating_point_range = {range_float};
declare_parameter("test", 15.0, param_descr);

Release into Melodic

It looks like all of the dependencies for this package are available in Melodic, so it would be great to get it released there. Thanks in advance.

Failed to retrieve parameters from node for large IntegerRange

ROS2 Foxy, Ubuntu 20.04

I declared a parameter using a descriptor and an IntegerRange of the following:

  Constraints:
    Min value: 0
    Max value: 4294967295
    Step: 1

When I run rqt_reconfigure it lists a few parameters, then stops and prints the following error:

WARN] [1638567416.039450550] [rqt_reconfigure]: Failed to retrieve parameters from node: argument 2 overflowed: value must be in the range -2147483648 to 2147483647

The parameter itself is set to "0".

It seems like rqt_reconfigure is unhappy with the fact that the to_value from IntegerRange is 4294967295 which is higher than 2147483647.

This raises two thoughts:

Why can't the to_value be higher? in ROS2, integer parameters are 64-bit ints, so why limit it to 32-bits?
If rqt_reconfigure fails to retrieve a parameter, would it be possible to skip this parameter and continue trying to list the rest of the parameters? At the moment it fails to display all the rest of the node parameters due to only one tricky parameter.

Thanks!

Text form (on the right) does not set the value

In kinetic (Ubuntu 16.04), the use of the text form on the right side does not set the value. In particular, it works only once, after the use of the bar.
I am not totally sure, but in the past, this bug did not show up.

Qt platform plugin "windows"

Dear team,
I am getting the following error:

> rosrun rqt_reconfigure rqt_reconfigure
This application failed to start because it could not find or load the Qt platform plugin "windows"
in "".

Reinstalling the application may fix this problem.

Details:
Windows 10 (x64) build 19042.1165
ROS Melodic

[To make other gui work (e.g. rqt_bag, rviz), I copied the content of C:\opt\rosdeps\x64\plugins\platforms to C:\opt\ros\melodic\x64\bin]

Crashes when displaying node contains param type=int, min=-1, max=None

Description

rqt_reconfigure node crashes when clicking a node that contains a parameter of type int, minimum value is -1 and maximum value is None (= INT_MAX).
I confirmed the error occurs on ROS noetic.

How to reproduce

For instance, if the parameter definition like below is contained, rqt_reconfigure crashes.

gen.add("param_key", int_t, 0, "description", -1, -1, None)

$ rqt_reconfigure
Floating point exception (core dumped)

I investigated using gdb and it looks there may be a bug in Qt.

$ gdb -ex run --args /usr/bin/python -v /opt/ros/noetic/lib/rqt_reconfigure/rqt_reconfigure
Thread 1 "python" received signal SIGFPE, Arithmetic exception.
0x00007ffff001f0b7 in QStyle::sliderPositionFromValue(int, int, int, int, bool) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5

Unsafe call to yaml.load_all

rqt_reconfigure/src/rqt_reconfigure/param_client_widget.py

Line 143 in 3c3b634

for doc in yaml.load_all(f.read()):

yaml.load_all is deprecated, and this call should be replaced with e.g. yaml.safe_load_all

See https://nvd.nist.gov/vuln/detail/CVE-2017-18342
Cf. ros/ros_comm@29053c4

Cannot set parameters around 1e-10 or lower on the UI

I need to modify some very small parameters related to a covariance matrix. From the UI, I cannot change to very small values.
So far the WA is to do it by command line like this

rosrun dynamic_reconfigure dynparam set /somenode somevalue 1.0e-12

Grouping parameters

Hello!

I am looking for a way to separate parameters in certain node to several groups, in a way similar to ROS1 functionality.

Defining the parameters in YAML file allows nesting parameters in subgroups, and these groups can be defined using dot in parameter names, e.g: node.declare_parameter("group_a.param_b")

I have created the example node to demonstrate the issue. https://gist.github.com/yossioo/c20d2966c9e27e57a3153d9ec176e896

I can see the declared parameters:

$ ros2 param list
/node_w_params:
  group_a.param_b
  group_a.param_c
  param_a
  use_sim_time

Checking the list of parameters shows that the prefixes are indeed recognized by ROS2:

$ ros2 service call /node_w_params/list_parameters rcl_interfaces/srv/ListParameters 
waiting for service to become available...
requester: making request: rcl_interfaces.srv.ListParameters_Request(prefixes=[], depth=0)

response:
rcl_interfaces.srv.ListParameters_Response(result=rcl_interfaces.msg.ListParametersResult(names=['use_sim_time', 'param_a', 'group_a.param_b', 'group_a.param_c'], prefixes=['group_a']))

And yet, the parameters are not grouped in the rqt_reconfigure interface and are simply presented in a single alphabetically ordered list.

Is there a proper way to define parameters so they will be displayed in groups?

rqt_reconfigure resize disabled with qt5

From @nxdefiant on April 24, 2017 10:41

In kinetic the rqt_reconfigure GUI does not allow resize between the left and the right column. This is problematic for e.g. reconfigure params with middle to longer text and reduces the overall usability.

Copied from original issue: ros-visualization/rqt_common_plugins#450

widget selection is using the wrong type

The selection of the matching widget per parameter type in

rqt_reconfigure/src/rqt_reconfigure/param_client_widget.py

Lines 222 to 231 in 1847d22

    
           def add_editor_widgets(self, parameters, descriptors): 
        
               for parameter, descriptor in zip(parameters, descriptors): 
        
                   if parameter.type_ not in EDITOR_TYPES: 
        
                       continue 
        
                   logging.debug('Adding editor widget for {}'.format(parameter.name)) 
        
                   editor_widget = EDITOR_TYPES[parameter.type_]( 
        
                       self._param_client, parameter, descriptor 
        
                   ) 
        
                   self._editor_widgets[parameter.name] = editor_widget 
        
                   editor_widget.display(self.grid)

is using the type of the default parameter instead of the type from the parameter description. This means that typed parameters without a default value do not get a configuration widget.

As en example, the new array configuration from #108 will not work with parameters where ros2 param describe returns

  Type: double array

Editing boolean array makes the plugin crash

Hi there,

I am extensively using the array edition from rqt_reconfigure, and I have noticed that editing an array of booleans makes the plugin crash. This is due to the json parser, which expects booleans to be written as true and false (i.e. lower case), while the bool arrays are by default written as True and False (i.e. the python way).

Adding the following lines in the edit_finished() method in the param_editors.py file solves the problem:

if Parameter.Type.from_parameter_value(self.parameter.value) == Parameter.Type.BOOL_ARRAY:
  params_list = json.loads(params_string.lower())
else:
  params_list = json.loads(params_string)

System: Ubuntu 22.04
Ros2 humble
Local build of rqt_reconfigure on the rolling branch, no modifications.

rqt_reconfigure: After filtering, node selection gets reset even though some nodes were selected

From @130s on January 27, 2013 20:22

Possible bad situation: node boxes are shown on right-hand side but their item on left-hand is not selected. When user selects a node on LH, the corresponding box disappears from RH.

I described the problematic phenomenon in the question on stackoverflow (satisfactory responses from there can help solving this issue too).

Related to issue #17.

Copied from original issue: ros-visualization/rqt_common_plugins#18

Convert synchronous/blocking calls to parameter services to async

Rqt_reconfigure should be updated to use async calls to the parameter service(s). First, it is (incorrectly) assuming that every node supports the parameter services. However, if one creates a parameter client for a node which doesn't provide the corresponding services and then invoke it, the synchronous call will hang. Next, even if a node does support the parameter services, the node may not be spinning (for example, a node created just to make a service call). In this latter case, using a synchronous call to a parameter service will also hang the calling app.

rqt_reconfigure crashes with IndexError

I encounter the following error logs when I create a unique pointer to a dynamic_reconfigure::Server and a nodehandle as a param.

PluginManager._load_plugin() could not load plugin "rqt_reconfigure/Param":
Traceback (most recent call last):
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_gui/plugin_handler.py", line 99, in load
    self._load()
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_gui/plugin_handler_direct.py", line 54, in _load
    self._plugin = self._plugin_provider.load(self._instance_id.plugin_id, self._context)
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_gui/composite_plugin_provider.py", line 71, in load
    instance = plugin_provider.load(plugin_id, plugin_context)
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_gui/composite_plugin_provider.py", line 71, in load
    instance = plugin_provider.load(plugin_id, plugin_context)
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_gui_py/ros_py_plugin_provider.py", line 60, in load
    return super(RosPyPluginProvider, self).load(plugin_id, plugin_context)
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_gui/composite_plugin_provider.py", line 71, in load
    instance = plugin_provider.load(plugin_id, plugin_context)
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_gui/ros_plugin_provider.py", line 101, in load
    return class_ref(plugin_context)
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_reconfigure/param_plugin.py", line 51, in __init__
    self._plugin_widget = ParamWidget(context)
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_reconfigure/param_widget.py", line 100, in __init__
    self._nodesel_widget = NodeSelectorWidget(self, rp, self.sig_sysmsg)
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_reconfigure/node_selector_widget.py", line 97, in __init__
    self._update_nodetree_pernode()
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_reconfigure/node_selector_widget.py", line 332, in _update_nodetree_pernode
    node_name_grn, TreenodeQstdItem.NODE_FULLPATH)
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_reconfigure/treenode_qstditem.py", line 87, in __init__
    self._set_param_name(grn_current_treenode)
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_reconfigure/treenode_qstditem.py", line 235, in _set_param_name
    self._toplevel_treenode_name = self._list_treenode_names[0]
IndexError: list index out of range

[ROS2]rqt_reconfigre UI hangs

ROS2 rqt_reconfigure is not stable. Either UI hangs or can not launched successfully.
Some error logs as follows:
[ERROR] [rqt_reconfigure]: Reconfigure GUI cannot connect to master.
Traceback (most recent call last):
File "/home/intel/workspace/ros2_rqt_ws/build/rqt_gui_py/src/rqt_gui_py/rclpy_spinner.py", line 32, in run
Traceback (most recent call last):
executor.spin_once(timeout_sec=1.0)
File "/home/intel/workspace/ros2_other_ws/build/rqt_reconfigure/src/rqt_reconfigure/node_selector_widget.py", line 444, in _refresh_nodes
File "/home/intel/workspace/ros2_ws/install/rclpy/lib/python3.6/site-packages/rclpy/executors.py", line 695, in spin_once
handler, entity, node = self.wait_for_ready_callbacks(timeout_sec=timeout_sec)
File "/home/intel/workspace/ros2_ws/install/rclpy/lib/python3.6/site-packages/rclpy/executors.py", line 649, in wait_for_ready_callbacks
return next(self._cb_iter)
File "/home/intel/workspace/ros2_ws/install/rclpy/lib/python3.6/site-packages/rclpy/executors.py", line 532, in _wait_for_ready_callbacks
self._prune_nodetree_pernode()
File "/home/intel/workspace/ros2_other_ws/build/rqt_reconfigure/src/rqt_reconfigure/node_selector_widget.py", line 431, in _prune_nodetree_pernode
self._context.handle)
RuntimeError: Failed to initialize wait set: the given context is not valid, either rcl_init() was not called or rcl_shutdown() was called., at /home/intel/workspace/ros2_ws/src/ros2/rcl/rcl/src/rcl/wait.c:130
raise e # TODO Make sure 'raise' here returns or finalizes func.
File "/home/intel/workspace/ros2_other_ws/build/rqt_reconfigure/src/rqt_reconfigure/node_selector_widget.py", line 428, in _prune_nodetree_pernode
nodes = find_nodes_with_params(self._context.node)
File "/home/intel/workspace/ros2_other_ws/build/rqt_reconfigure/src/rqt_reconfigure/param_api.py", line 133, in find_nodes_with_params
for node_name, ns in node.get_node_names_and_namespaces()
File "/home/intel/workspace/ros2_other_ws/build/rqt_reconfigure/src/rqt_reconfigure/param_api.py", line 130, in
filter(lambda node_name: _has_params(node, node_name),
File "/home/intel/workspace/ros2_other_ws/build/rqt_reconfigure/src/rqt_reconfigure/param_api.py", line 122, in _has_params
client.wait_for_service()
File "/home/intel/workspace/ros2_ws/install/rclpy/lib/python3.6/site-packages/rclpy/client.py", line 164, in wait_for_service
return self.service_is_ready()
File "/home/intel/workspace/ros2_ws/install/rclpy/lib/python3.6/site-packages/rclpy/client.py", line 144, in service_is_ready
return _rclpy.rclpy_service_server_is_available(capsule)
RuntimeError: Failed to check service availability: rcl node's context is invalid, at /home/intel/workspace/ros2_ws/src/ros2/rcl/rcl/src/rcl/node.c:476